[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620761429 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620761418 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620756951 **[Test build #122009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122009/testReport)** for PR 28379 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28398: URL: https://github.com/apache/spark/pull/28398#issuecomment-620761779 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620761796 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620761773 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620761796 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620761773 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416810632 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ## @@ -145,6 +156,11 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416810632 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ## @@ -145,6 +156,11 @@ case class

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620761399 **[Test build #122009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122009/testReport)** for PR 28379 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28398: URL: https://github.com/apache/spark/pull/28398#issuecomment-620761779 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620761418 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
SparkQA commented on pull request #28330: URL: https://github.com/apache/spark/pull/28330#issuecomment-620760923 **[Test build #122012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122012/testReport)** for PR 28330 at commit

[GitHub] [spark] SparkQA commented on pull request #28386: [SPARK-26199][SPARK-31517][R] fix strategy for handling ... names in mutate

2020-04-28 Thread GitBox
SparkQA commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-620760984 **[Test build #122011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122011/testReport)** for PR 28386 at commit

[GitHub] [spark] SparkQA commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

2020-04-28 Thread GitBox
SparkQA commented on pull request #28398: URL: https://github.com/apache/spark/pull/28398#issuecomment-620761049 **[Test build #122010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122010/testReport)** for PR 28398 at commit

[GitHub] [spark] sririshindra commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
sririshindra commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416809429 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite

[GitHub] [spark] MaxGekk commented on pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

2020-04-28 Thread GitBox
MaxGekk commented on pull request #28398: URL: https://github.com/apache/spark/pull/28398#issuecomment-620760433 @bersprockets @cloud-fan While working on the fix for legacy timestamp formatters, I have found that the round trip tests for dates are not enough. Need to test in each

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416809229 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ## @@ -145,6 +156,11 @@ case class

[GitHub] [spark] MaxGekk opened a new pull request #28398: [SPARK-31557][SQL][TESTS][FOLLOWUP] Check rebasing in all legacy formatters

2020-04-28 Thread GitBox
MaxGekk opened a new pull request #28398: URL: https://github.com/apache/spark/pull/28398 ### What changes were proposed in this pull request? - Check all available legacy formats in the tests added by https://github.com/apache/spark/pull/28345 - Check dates rebasing in legacy

[GitHub] [spark] sririshindra commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
sririshindra commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416806910 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite

[GitHub] [spark] sririshindra commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
sririshindra commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416807097 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite

[GitHub] [spark] sririshindra commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
sririshindra commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416806448 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -325,34 +325,57 @@ class SQLMetricsSuite

[GitHub] [spark] sririshindra commented on a change in pull request #28330: [SPARK-31377][SQL][TEST] Added unit tests to 'number of output rows metric' for some joins in SQLMetricSuite

2020-04-28 Thread GitBox
sririshindra commented on a change in pull request #28330: URL: https://github.com/apache/spark/pull/28330#discussion_r416806570 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala ## @@ -394,6 +420,21 @@ class SQLMetricsSuite

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620757541 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620757541 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28379: [SPARK-28040][SPARK-28070][R] Write type object s3

2020-04-28 Thread GitBox
SparkQA commented on pull request #28379: URL: https://github.com/apache/spark/pull/28379#issuecomment-620756951 **[Test build #122009 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122009/testReport)** for PR 28379 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416802666 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ## @@ -3425,6 +3425,28 @@ class SQLQuerySuite extends QueryTest with

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416801382 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ## @@ -102,6 +105,11 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620742059 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620742055 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620742055 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620628606 **[Test build #122001 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122001/testReport)** for PR 28397 at commit

[GitHub] [spark] SparkQA commented on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
SparkQA commented on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620740881 **[Test build #122001 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122001/testReport)** for PR 28397 at commit

[GitHub] [spark] dbtsai edited a comment on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-28 Thread GitBox
dbtsai edited a comment on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620738022 @tgravescs the standard "with hadoop" Spark built with Yarn is sufficient to work in our CDH env. Thanks for the review. I'll update the doc and config.md. @viirya

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28395: URL: https://github.com/apache/spark/pull/28395#issuecomment-620738507 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28395: URL: https://github.com/apache/spark/pull/28395#issuecomment-620738507 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] prakharjain09 commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
prakharjain09 commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r416781804 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1895,52 @@ private[spark] class BlockManager(

[GitHub] [spark] prakharjain09 commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
prakharjain09 commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r416781804 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1895,52 @@ private[spark] class BlockManager(

[GitHub] [spark] dbtsai commented on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-28 Thread GitBox
dbtsai commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620738022 @tgravescs the standard "with hadoop" Spark built with Yarn is sufficient to work in our CDH env. Thanks for the review. I'll update the doc and config.md.

[GitHub] [spark] SparkQA removed a comment on pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28395: URL: https://github.com/apache/spark/pull/28395#issuecomment-620614897 **[Test build #121999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121999/testReport)** for PR 28395 at commit

[GitHub] [spark] SparkQA commented on pull request #28395: [SPARK-31549][PYSPARK] Add a develop API invoking collect on Python RDD with user-specified job group

2020-04-28 Thread GitBox
SparkQA commented on pull request #28395: URL: https://github.com/apache/spark/pull/28395#issuecomment-620736970 **[Test build #121999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121999/testReport)** for PR 28395 at commit

[GitHub] [spark] srowen commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
srowen commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416773236 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ## @@ -102,6 +102,8 @@ case class Rand(child:

[GitHub] [spark] maropu commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
maropu commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416770553 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ## @@ -102,6 +102,8 @@ case class Rand(child:

[GitHub] [spark] SparkQA commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
SparkQA commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620728738 **[Test build #122008 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122008/testReport)** for PR 28375 at commit

[GitHub] [spark] srowen commented on a change in pull request #28389: [SPARK-31592]bufferPoolsBySize in HeapMemoryAllocator should be thread safe

2020-04-28 Thread GitBox
srowen commented on a change in pull request #28389: URL: https://github.com/apache/spark/pull/28389#discussion_r416769598 ## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java ## @@ -50,7 +50,7 @@ public MemoryBlock allocate(long

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620725295 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28375: [SPARK-30282][SQL][FOLLOWUP] SHOW TBLPROPERTIES should support views

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28375: URL: https://github.com/apache/spark/pull/28375#issuecomment-620725295 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyE

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-620722571 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyExistsExc

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-620722571 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] holdenk removed a comment on pull request #28331: [WIP][SPARK-20629][CORE] Copy shuffle data when nodes are being shutdown

2020-04-28 Thread GitBox
holdenk removed a comment on pull request #28331: URL: https://github.com/apache/spark/pull/28331#issuecomment-619297810 Jenkins retest this please On Fri, Apr 24, 2020 at 6:11 PM UCB AMPLab wrote: > Test FAILed. > Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620721030 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620721030 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyExistsE

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-620563639 **[Test build #121993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121993/testReport)** for PR 26339 at commit

[GitHub] [spark] SparkQA commented on pull request #26339: [SPARK-27194][SPARK-29302][SQL] For dynamic partition overwrite operation, fix speculation task conflict issue and FileAlreadyExistsException

2020-04-28 Thread GitBox
SparkQA commented on pull request #26339: URL: https://github.com/apache/spark/pull/26339#issuecomment-620721091 **[Test build #121993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121993/testReport)** for PR 26339 at commit

[GitHub] [spark] SparkQA commented on pull request #28392: [SPARK-31594][SQL] Do not display the seed of rand/randn with no argument in output schema

2020-04-28 Thread GitBox
SparkQA commented on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620720359 **[Test build #122007 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122007/testReport)** for PR 28392 at commit

[GitHub] [spark] fanyunbojerry commented on a change in pull request #28389: [SPARK-31592]bufferPoolsBySize in HeapMemoryAllocator should be thread safe

2020-04-28 Thread GitBox
fanyunbojerry commented on a change in pull request #28389: URL: https://github.com/apache/spark/pull/28389#discussion_r416758545 ## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/HeapMemoryAllocator.java ## @@ -50,7 +50,7 @@ public MemoryBlock

[GitHub] [spark] viirya commented on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-28 Thread GitBox
viirya commented on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620717201 @tgravescs I see. That makes sense. So users still need to pay attention on dependencies issue if any when running multiple versions there.

[GitHub] [spark] viirya edited a comment on pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-28 Thread GitBox
viirya edited a comment on pull request #28376: URL: https://github.com/apache/spark/pull/28376#issuecomment-620717201 @tgravescs I see. Thanks. That makes sense. So users still need to pay attention on dependencies issue if any when running multiple versions there.

[GitHub] [spark] huaxingao commented on pull request #28290: [SPARK-29458][SQL][DOCS] Add a paragraph for scalar function in sql getting started

2020-04-28 Thread GitBox
huaxingao commented on pull request #28290: URL: https://github.com/apache/spark/pull/28290#issuecomment-620713716 Thanks! @maropu @srowen This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620711811 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620711811 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
SparkQA commented on pull request #28194: URL: https://github.com/apache/spark/pull/28194#issuecomment-620710970 **[Test build #122006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122006/testReport)** for PR 28194 at commit

[GitHub] [spark] srowen commented on pull request #28290: [SPARK-29458][SQL][DOCS] Add a paragraph for scalar function in sql getting started

2020-04-28 Thread GitBox
srowen commented on pull request #28290: URL: https://github.com/apache/spark/pull/28290#issuecomment-620708879 Merged to master/3.0 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] attilapiros commented on a change in pull request #28094: [SPARK-29303][Web UI] Add UI support for stage level scheduling

2020-04-28 Thread GitBox
attilapiros commented on a change in pull request #28094: URL: https://github.com/apache/spark/pull/28094#discussion_r416743570 ## File path: core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala ## @@ -38,6 +40,34 @@ private[ui] class EnvironmentPage( "Java

[GitHub] [spark] dongjoon-hyun commented on pull request #28397: [SPARK-31519][SQL][2.4] Cast in having aggregate expressions returns the wrong result

2020-04-28 Thread GitBox
dongjoon-hyun commented on pull request #28397: URL: https://github.com/apache/spark/pull/28397#issuecomment-620704036 Hi, @xuanyuanking and @cloud-fan . Could you update the PR description appropriately because it's invalid in branch-2.4. ``` scala> spark.version res7: String =

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28138: [SPARK-31366][DOCS][SQL] Add doc for the aggregation in SQL reference guide

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28138: URL: https://github.com/apache/spark/pull/28138#issuecomment-610096272 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620702413 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620702413 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620701534 **[Test build #122005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122005/testReport)** for PR 28370 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28138: [SPARK-31366][DOCS][SQL] Add doc for the aggregation in SQL reference guide

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28138: URL: https://github.com/apache/spark/pull/28138#issuecomment-620701289 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] huaxingao commented on pull request #28332: [SPARK-31556][SQL][DOCS] Document LIKE clause in SQL Reference

2020-04-28 Thread GitBox
huaxingao commented on pull request #28332: URL: https://github.com/apache/spark/pull/28332#issuecomment-620700495 cc @srowen This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] huaxingao commented on pull request #28290: [SPARK-29458][SQL][DOCS] Add a paragraph for scalar function in sql getting started

2020-04-28 Thread GitBox
huaxingao commented on pull request #28290: URL: https://github.com/apache/spark/pull/28290#issuecomment-620698960 @srowen This PR is ready to be merged. @maropu was suggesting to document more keywords later on. This is

[GitHub] [spark] beliefer commented on a change in pull request #28194: [SPARK-31372][SQL][TEST] Display expression schema for double check.

2020-04-28 Thread GitBox
beliefer commented on a change in pull request #28194: URL: https://github.com/apache/spark/pull/28194#discussion_r416733719 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ExpressionsSchemaSuite.scala ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software

[GitHub] [spark] dongjoon-hyun commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
dongjoon-hyun commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620697820 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] attilapiros commented on a change in pull request #28094: [SPARK-29303][Web UI] Add UI support for stage level scheduling

2020-04-28 Thread GitBox
attilapiros commented on a change in pull request #28094: URL: https://github.com/apache/spark/pull/28094#discussion_r416618745 ## File path: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ## @@ -197,10 +217,16 @@ private[spark] class AppStatusListener(

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28376: [SPARK-31582] [Yarn] Being able to not populate Hadoop classpath

2020-04-28 Thread GitBox
dongjoon-hyun commented on a change in pull request #28376: URL: https://github.com/apache/spark/pull/28376#discussion_r416733376 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala ## @@ -70,6 +70,13 @@ package object config {

[GitHub] [spark] holdenk commented on a change in pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
holdenk commented on a change in pull request #28370: URL: https://github.com/apache/spark/pull/28370#discussion_r416733183 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1829,7 +1895,52 @@ private[spark] class BlockManager(

[GitHub] [spark] dongjoon-hyun commented on pull request #28359: [SPARK-31534][WEBUI][3.0] Text for tooltip should be escaped

2020-04-28 Thread GitBox
dongjoon-hyun commented on pull request #28359: URL: https://github.com/apache/spark/pull/28359#issuecomment-620696335 Thank you, @sarutak and @gengliangwang . Merged to branch-3.0. This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #28388: [SPARK-31553][SQL] Revert "[SPARK-29048] Improve performance on Column.isInCollection() with a large size collection"

2020-04-28 Thread GitBox
dongjoon-hyun commented on pull request #28388: URL: https://github.com/apache/spark/pull/28388#issuecomment-620692526 +1, late LGTM. Thank you for reverting. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28390: URL: https://github.com/apache/spark/pull/28390#issuecomment-620684515 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28390: URL: https://github.com/apache/spark/pull/28390#issuecomment-620684515 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] cloud-fan commented on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
cloud-fan commented on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620684485 It's benchmark only so we don't need to wait for jenkins. Thanks, merging to master/3.0! This is an

[GitHub] [spark] SparkQA removed a comment on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28390: URL: https://github.com/apache/spark/pull/28390#issuecomment-620499465 **[Test build #121987 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121987/testReport)** for PR 28390 at commit

[GitHub] [spark] SparkQA commented on pull request #28390: [SPARK-27340][SS][TESTS][FOLLOW-UP] Rephrase API comments and simplify tests

2020-04-28 Thread GitBox
SparkQA commented on pull request #28390: URL: https://github.com/apache/spark/pull/28390#issuecomment-620683132 **[Test build #121987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121987/testReport)** for PR 28390 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620674459 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620674459 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28369: [SPARK-31527][SQL][TESTS][FOLLOWUP] Add a benchmark test for datetime add/subtract interval operations

2020-04-28 Thread GitBox
SparkQA commented on pull request #28369: URL: https://github.com/apache/spark/pull/28369#issuecomment-620673509 **[Test build #122004 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122004/testReport)** for PR 28369 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620671101 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620671076 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620671076 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620507280 **[Test build #121988 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121988/testReport)** for PR 28370 at commit

[GitHub] [spark] SparkQA commented on pull request #28370: [SPARK-20732][CORE] Decommission cache blocks to other executors when an executor is decommissioned

2020-04-28 Thread GitBox
SparkQA commented on pull request #28370: URL: https://github.com/apache/spark/pull/28370#issuecomment-620669591 **[Test build #121988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121988/testReport)** for PR 28370 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28392: [SPARK-31594][SQL] Do not display rand/randn seed numbers in schema

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620653944 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28392: [SPARK-31594][SQL] Do not display rand/randn seed numbers in schema

2020-04-28 Thread GitBox
AmplabJenkins removed a comment on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620653926 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28392: [SPARK-31594][SQL] Do not display rand/randn seed numbers in schema

2020-04-28 Thread GitBox
AmplabJenkins commented on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620653926 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28392: [SPARK-31594][SQL] Do not display rand/randn seed numbers in schema

2020-04-28 Thread GitBox
SparkQA removed a comment on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620518808 **[Test build #121990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121990/testReport)** for PR 28392 at commit

[GitHub] [spark] srowen commented on pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

2020-04-28 Thread GitBox
srowen commented on pull request #28365: URL: https://github.com/apache/spark/pull/28365#issuecomment-620653088 I doubt we will ever have translations. If that is the only upside to some of the changes, I maybe wouldn't do it. If there are other simple standardizations or simplifications

[GitHub] [spark] SparkQA commented on pull request #28392: [SPARK-31594][SQL] Do not display rand/randn seed numbers in schema

2020-04-28 Thread GitBox
SparkQA commented on pull request #28392: URL: https://github.com/apache/spark/pull/28392#issuecomment-620653293 **[Test build #121990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121990/testReport)** for PR 28392 at commit

[GitHub] [spark] srowen commented on a change in pull request #28392: [SPARK-31594][SQL] Do not display rand/randn seed numbers in schema

2020-04-28 Thread GitBox
srowen commented on a change in pull request #28392: URL: https://github.com/apache/spark/pull/28392#discussion_r416672687 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala ## @@ -102,6 +102,8 @@ case class Rand(child:

<    1   2   3   4   5   6   7   8   9   >