[GitHub] [spark] AmplabJenkins commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631197828 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631197365 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631154251 **[Test build #122862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122862/testReport)** for PR 28584 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631197365 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631197540 **[Test build #122865 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122865/testReport)** for PR 28584 at commit

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631197104 **[Test build #122862 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122862/testReport)** for PR 28584 at commit

[GitHub] [spark] Ngone51 commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
Ngone51 commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631196426 retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu edited a comment on pull request #28574: [SPARK-31752][SQL][DOCS] Add sql doc for interval type

2020-05-19 Thread GitBox
maropu edited a comment on pull request #28574: URL: https://github.com/apache/spark/pull/28574#issuecomment-631140668 Adding a doc for this looks nice and okay to me. How about splitting the Data Types pages into three sub-sections like this? ``` SQL Reference - Data Types --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631195079 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631194884 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631195076 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631194879 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631157795 **[Test build #122864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122864/testReport)** for PR 28584 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631194879 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631194766 **[Test build #122864 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122864/testReport)** for PR 28584 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631151919 **[Test build #122860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122860/testReport)** for PR 28584 at commit

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631194348 **[Test build #122860 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122860/testReport)** for PR 28584 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631193835 Okay, seems already failed. I merged to branch-3.0 as well. This is an automated message from the Apache

[GitHub] [spark] Ngone51 commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
Ngone51 commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631190294 sure, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] jiangxb1987 commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
jiangxb1987 commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631189377 "SPARK-31485: barrier stage should fail if only partial tasks are launched" This test case is flaky, @Ngone51 can you take a look?

[GitHub] [spark] yaooqinn commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-19 Thread GitBox
yaooqinn commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427699845 ## File path: sbin/spark-daemon.sh ## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; -num=5; -if [ -n "$2" ]; then -

[GitHub] [spark] HyukjinKwon commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631188474 Merged to master. I think we can backport this to branch-3.0 if RC2 actually fails. This is an

[GitHub] [spark] HyukjinKwon edited a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon edited a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631188474 Merged to master. I think we can backport this to branch-3.0 if RC2 officially fails. This is

[GitHub] [spark] HyukjinKwon closed pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
HyukjinKwon closed pull request #28572: URL: https://github.com/apache/spark/pull/28572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] kiszk commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
kiszk commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-631184554 late LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631184165 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631184156 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631184156 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631138701 **[Test build #122856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122856/testReport)** for PR 28584 at commit

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631183835 **[Test build #122856 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122856/testReport)** for PR 28584 at commit

[GitHub] [spark] maropu commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-19 Thread GitBox
maropu commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427678940 ## File path: sbin/spark-daemon.sh ## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; -num=5; -if [ -n "$2" ]; then - num=$2

[GitHub] [spark] HyukjinKwon commented on pull request #28569: [SPARK-31748][PYTHON] Document resource module in PySpark doc and rename/move classes

2020-05-19 Thread GitBox
HyukjinKwon commented on pull request #28569: URL: https://github.com/apache/spark/pull/28569#issuecomment-631165795 Thank you all! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] tdas commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-19 Thread GitBox
tdas commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-631158485 LGTM. Primarily because all tests seem to work without the hack in the StreamExecution that force v1 sink execution.

[GitHub] [spark] dongjoon-hyun removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
dongjoon-hyun removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631157380 Retest this please. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631157795 **[Test build #122864 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122864/testReport)** for PR 28584 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631157380 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28569: [SPARK-31748][PYTHON] Document resource module in PySpark doc and rename/move classes

2020-05-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #28569: URL: https://github.com/apache/spark/pull/28569#discussion_r427669935 ## File path: python/pyspark/resource/information.py ## @@ -26,8 +26,10 @@ class ResourceInformation(object): One example is GPUs, where the

[GitHub] [spark] dongjoon-hyun closed pull request #28569: [SPARK-31748][PYTHON] Document resource module in PySpark doc and rename/move classes

2020-05-19 Thread GitBox
dongjoon-hyun closed pull request #28569: URL: https://github.com/apache/spark/pull/28569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins commented on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-631154654 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-631154654 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631154251 **[Test build #122862 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122862/testReport)** for PR 28584 at commit

[GitHub] [spark] dongjoon-hyun removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
dongjoon-hyun removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631153901 Retest this please. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #28578: [SPARK-31756][WEBUI] Add real headless browser support for UI test

2020-05-19 Thread GitBox
SparkQA commented on pull request #28578: URL: https://github.com/apache/spark/pull/28578#issuecomment-631154272 **[Test build #122863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122863/testReport)** for PR 28578 at commit

[GitHub] [spark] dongjoon-hyun removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
dongjoon-hyun removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631150467 Retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] dongjoon-hyun commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631153901 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28544: [SPARK-31387][SQL][test-maven][test-hive1.2] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631152255 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28544: [SPARK-31387][SQL][test-maven][test-hive1.2] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631152255 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631152208 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631152208 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631151919 **[Test build #122860 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122860/testReport)** for PR 28584 at commit

[GitHub] [spark] SparkQA commented on pull request #28544: [SPARK-31387][SQL][test-maven][test-hive1.2] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
SparkQA commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631151915 **[Test build #122861 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122861/testReport)** for PR 28544 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631150467 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631149735 Thank you so much, @jiangxb1987 . This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] dongjoon-hyun commented on pull request #28544: [SPARK-31387][SQL][test-maven][test-hive1.2] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631149318 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #28544: URL: https://github.com/apache/spark/pull/28544#discussion_r427664699 ## File path: sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ## @@ -674,11 +678,15 @@ private

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
dongjoon-hyun commented on a change in pull request #28544: URL: https://github.com/apache/spark/pull/28544#discussion_r427663759 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/ui/HiveThriftServer2ListenerSuite.scala ## @@ -140,6

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-631146414 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631146404 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631146404 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on a change in pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
maropu commented on a change in pull request #28544: URL: https://github.com/apache/spark/pull/28544#discussion_r427662014 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/HiveThriftServer2Listener.scala ## @@ -131,60 +132,81 @@

[GitHub] [spark] AmplabJenkins commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-631146414 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
SparkQA commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631146065 **[Test build #122858 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122858/testReport)** for PR 28544 at commit

[GitHub] [spark] SparkQA commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-19 Thread GitBox
SparkQA commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-631146068 **[Test build #122859 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122859/testReport)** for PR 28527 at commit

[GitHub] [spark] SparkQA commented on pull request #28575: [SPARK-31705][SQL] Push predicate through join by rewriting join condition to conjunctive normal form

2020-05-19 Thread GitBox
SparkQA commented on pull request #28575: URL: https://github.com/apache/spark/pull/28575#issuecomment-631146069 **[Test build #122857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122857/testReport)** for PR 28575 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28544: [SPARK-31387][SQL][test-maven] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631145624 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HeartSaVioR commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-19 Thread GitBox
HeartSaVioR commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-631145268 Personally I don't see any risk on 1, because we haven't make changes on major release (via merging this in), and master is for next minor release which has more risk to

[GitHub] [spark] AmplabJenkins commented on pull request #28575: [SPARK-31705][SQL] Push predicate through join by rewriting join condition to conjunctive normal form

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28575: URL: https://github.com/apache/spark/pull/28575#issuecomment-631144239 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28575: [SPARK-31705][SQL] Push predicate through join by rewriting join condition to conjunctive normal form

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28575: URL: https://github.com/apache/spark/pull/28575#issuecomment-631144239 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] maropu commented on pull request #28527: [SPARK-31709][SQL] Proper base path for database/table location when it is a relative path

2020-05-19 Thread GitBox
maropu commented on pull request #28527: URL: https://github.com/apache/spark/pull/28527#issuecomment-631144107 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #28575: [SPARK-31705][SQL] Push predicate through join by rewriting join condition to conjunctive normal form

2020-05-19 Thread GitBox
maropu commented on pull request #28575: URL: https://github.com/apache/spark/pull/28575#issuecomment-631143972 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] maropu commented on pull request #28574: [SPARK-31752][SQL][DOCS] Add sql doc for interval type

2020-05-19 Thread GitBox
maropu commented on pull request #28574: URL: https://github.com/apache/spark/pull/28574#issuecomment-631140668 Adding a doc for this looks nice and okay to me. How about splitting the Data Types pages into three sub-sections like this? ``` SQL Reference - Data Types --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631139371 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631139371 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
SparkQA commented on pull request #28584: URL: https://github.com/apache/spark/pull/28584#issuecomment-631138701 **[Test build #122856 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122856/testReport)** for PR 28584 at commit

[GitHub] [spark] jiangxb1987 opened a new pull request #28584: [SPARK-31730][CORE][TEST] Fix flaky tests in BarrierTaskContextSuite

2020-05-19 Thread GitBox
jiangxb1987 opened a new pull request #28584: URL: https://github.com/apache/spark/pull/28584 ### What changes were proposed in this pull request? To wait until all the executors have started before submitting any job. This could avoid the flakiness caused by waiting for executors

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631106162 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631106156 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631106156 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631048836 **[Test build #122854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122854/testReport)** for PR 28582 at commit

[GitHub] [spark] SparkQA commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
SparkQA commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631105816 **[Test build #122854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122854/testReport)** for PR 28582 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-631098172 Thank you, @srowen ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631097449 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631097449 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-631097518 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-631097518 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631096629 **[Test build #122852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122852/testReport)** for PR 28572 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-630961488 **[Test build #122853 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122853/testReport)** for PR 28579 at commit

[GitHub] [spark] SparkQA commented on pull request #28579: [SPARK-31757][CORE] Improve HistoryServerDiskManager.updateAccessTime()

2020-05-19 Thread GitBox
SparkQA commented on pull request #28579: URL: https://github.com/apache/spark/pull/28579#issuecomment-631096636 **[Test build #122853 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122853/testReport)** for PR 28579 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
SparkQA removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-630903093 **[Test build #122852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122852/testReport)** for PR 28572 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28583: [SPARK-31764][CORE] JsonProtocol doesn't write RDDInfo#isBarrier

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28583: URL: https://github.com/apache/spark/pull/28583#issuecomment-631091554 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28583: [SPARK-31764][CORE] JsonProtocol doesn't write RDDInfo#isBarrier

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28583: URL: https://github.com/apache/spark/pull/28583#issuecomment-631091554 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28583: [SPARK-31764][CORE] JsonProtocol doesn't write RDDInfo#isBarrier

2020-05-19 Thread GitBox
SparkQA commented on pull request #28583: URL: https://github.com/apache/spark/pull/28583#issuecomment-631090950 **[Test build #122855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122855/testReport)** for PR 28583 at commit

[GitHub] [spark] sarutak opened a new pull request #28583: [SPARK-31764][CORE] JsonProtocol doesn't write RDDInfo#isBarrier

2020-05-19 Thread GitBox
sarutak opened a new pull request #28583: URL: https://github.com/apache/spark/pull/28583 ### What changes were proposed in this pull request? This PR changes JsonProtocol to write RDDInfos#isBarrier. ### Why are the changes needed? JsonProtocol reads RDDInfos#isBarrier

[GitHub] [spark] srowen commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
srowen commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-631072584 I was running tests on this patch in 2.11 and 2.12 and it looked good here too. This is an automated message

[GitHub] [spark] dongjoon-hyun commented on pull request #28577: [SPARK-31399][CORE][2.4] Support indylambda Scala closure in ClosureCleaner

2020-05-19 Thread GitBox
dongjoon-hyun commented on pull request #28577: URL: https://github.com/apache/spark/pull/28577#issuecomment-631050916 Thank you so much, @rednaxelafx and @dbtsai . This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631049476 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631049476 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins removed a comment on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631048558 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-19 Thread GitBox
SparkQA commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631048836 **[Test build #122854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122854/testReport)** for PR 28582 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28572: [SPARK-31750][SQL] Eliminate UpCast if child's dataType is DecimalType

2020-05-19 Thread GitBox
AmplabJenkins commented on pull request #28572: URL: https://github.com/apache/spark/pull/28572#issuecomment-631048558 This is an automated message from the Apache Git Service. To respond to the message, please log on to

<    1   2   3   4   5   6   >