yaooqinn commented on a change in pull request #28580:
URL: https://github.com/apache/spark/pull/28580#discussion_r427699845
##########
File path: sbin/spark-daemon.sh
##########
@@ -74,10 +75,13 @@ shift
spark_rotate_log ()
{
log=$1;
- num=5;
- if [ -n "$2" ]; then
- num=$2
+
+ if [[ ${SPARK_LOG_MAX_FILES} -gt 5 ]] 2>/dev/null; then
+ num=${SPARK_LOG_MAX_FILES}
+ else
+ num=5
Review comment:
not really. the `$2` is not provided via its only caller.
https://github.com/apache/spark/blob/d273a2bb0fac452a97f5670edd69d3e452e3e57e/sbin/spark-daemon.sh#L173-L174
The log max number is always 5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
