maropu commented on a change in pull request #28580:
URL: https://github.com/apache/spark/pull/28580#discussion_r427678940
##########
File path: sbin/spark-daemon.sh
##########
@@ -74,10 +75,13 @@ shift
spark_rotate_log ()
{
log=$1;
- num=5;
- if [ -n "$2" ]; then
- num=$2
+
+ if [[ ${SPARK_LOG_MAX_FILES} -gt 5 ]] 2>/dev/null; then
+ num=${SPARK_LOG_MAX_FILES}
+ else
+ num=5
Review comment:
The change itself looks okay to me, but current users who use the `$2`
argument might get surprised at this change a bit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
