[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631421007 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] MaxGekk commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
MaxGekk commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r427941581 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -454,7 +459,10 @@ abstract class CastBase extends

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631421007 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on a change in pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
MaxGekk commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r427939888 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -59,8 +59,8 @@ object Cast { case (StringType,

[GitHub] [spark] GuoPhilipse commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
GuoPhilipse commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631409003 @cloud-fan @bart-samwel @MaxGekk Could you please help me review it ? This is an automated message from

[GitHub] [spark] SparkQA removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631364664 **[Test build #122885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122885/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631407771 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631407763 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631407763 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631407649 **[Test build #122885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122885/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28544: [SPARK-31387][SQL][test-maven][test-hive1.2] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631400676 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28544: [SPARK-31387][SQL][test-maven][test-hive1.2] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631400676 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28544: [SPARK-31387][SQL][test-maven][test-hive1.2] Handle unknown operation/session ID in HiveThriftServer2Listener

2020-05-20 Thread GitBox
SparkQA commented on pull request #28544: URL: https://github.com/apache/spark/pull/28544#issuecomment-631400010 **[Test build #122892 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122892/testReport)** for PR 28544 at commit

[GitHub] [spark] sarutak commented on a change in pull request #28512: [SPARK-31688][WEBUI] Refactor Pagination framework

2020-05-20 Thread GitBox
sarutak commented on a change in pull request #28512: URL: https://github.com/apache/spark/pull/28512#discussion_r427850966 ## File path: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ## @@ -545,89 +522,21 @@ private[ui] class JobPagedTable( override def

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631388119 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631388110 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631310532 **[Test build #122879 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122879/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631388110 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631387943 **[Test build #122879 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122879/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631384912 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631385623 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427887257 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -4,6 +4,9 @@ select

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-631384912 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] HyukjinKwon closed pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
HyukjinKwon closed pull request #28580: URL: https://github.com/apache/spark/pull/28580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
HyukjinKwon commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-631384154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [spark] GuoPhilipse opened a new pull request #28593: [SPARK-31710][SQL] Add two compatibility flag to cast long to timestamp

2020-05-20 Thread GitBox
GuoPhilipse opened a new pull request #28593: URL: https://github.com/apache/spark/pull/28593 ## What changes were proposed in this pull request? I have changed my git base,so it is a continue for PR #28568 the patch will fail by default for casting long to timestamp, meanwhile

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-631382125 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631381852 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-631382125 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
yaooqinn commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-631381994 @HyukjinKwon updated. thanks for approving This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631381852 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
SparkQA commented on pull request #28580: URL: https://github.com/apache/spark/pull/28580#issuecomment-631381324 **[Test build #122890 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122890/testReport)** for PR 28580 at commit

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631381293 **[Test build #122891 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122891/testReport)** for PR 28534 at commit

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427887257 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -4,6 +4,9 @@ select

[GitHub] [spark] bart-samwel commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427892129 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,50 @@ import

[GitHub] [spark] yaooqinn commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
yaooqinn commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427891086 ## File path: sbin/spark-daemon.sh ## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; -num=5; -if [ -n "$2" ]; then -

[GitHub] [spark] stczwd commented on a change in pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
stczwd commented on a change in pull request #28128: URL: https://github.com/apache/spark/pull/28128#discussion_r427889488 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -940,20 +939,19 @@ object SparkSession extends Logging {

[GitHub] [spark] MaxGekk commented on pull request #28582: [SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
MaxGekk commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631374997 @cloud-fan @HyukjinKwon @bogdanghit Please, review this PR. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631373506 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631373467 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631373519 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631373506 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631373519 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631373467 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427887257 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -4,6 +4,9 @@ select

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631372823 **[Test build #122888 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122888/testReport)** for PR 28534 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427886436 ## File path: sbin/spark-daemon.sh ## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; -num=5; -if [ -n "$2" ]; then -

[GitHub] [spark] SparkQA commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
SparkQA commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631372849 **[Test build #122887 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122887/testReport)** for PR 28582 at commit

[GitHub] [spark] SparkQA commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
SparkQA commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631372855 **[Test build #122889 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122889/testReport)** for PR 27006 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427886436 ## File path: sbin/spark-daemon.sh ## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; -num=5; -if [ -n "$2" ]; then -

[GitHub] [spark] tashoyan commented on pull request #28491: [SPARK-30267][SQL] Interoperability tests with Avro records generated by Avro4s

2020-05-20 Thread GitBox
tashoyan commented on pull request #28491: URL: https://github.com/apache/spark/pull/28491#issuecomment-631371744 I'm fine with both approaches. Compatibility with Avro4s looks like additional value to me. However, if the community disagrees with test-scope dependency on Avro4s, then I

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427884982 ## File path: sbin/spark-daemon.sh ## @@ -23,6 +23,7 @@ # # SPARK_CONF_DIR Alternate conf dir. Default is ${SPARK_HOME}/conf. # SPARK_LOG_DIR

[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427884768 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -4,6 +4,9 @@ select

[GitHub] [spark] yaooqinn commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
yaooqinn commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427884788 ## File path: sbin/spark-daemon.sh ## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; -num=5; -if [ -n "$2" ]; then -

[GitHub] [spark] TJX2014 commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631370684 @cloud-fan hi, Mr fan, Can I remove the related tests in `org.apache.spark.sql.SQLQueryTestSuite`, just because we have same checks in `datetime.sql`

[GitHub] [spark] HyukjinKwon commented on a change in pull request #28580: [SPARK-31759][Deploy] Support configurable max number of rotate logs for spark daemons

2020-05-20 Thread GitBox
HyukjinKwon commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427883652 ## File path: sbin/spark-daemon.sh ## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; -num=5; -if [ -n "$2" ]; then -

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28128: URL: https://github.com/apache/spark/pull/28128#issuecomment-631369428 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28128: URL: https://github.com/apache/spark/pull/28128#issuecomment-631369428 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
SparkQA commented on pull request #28128: URL: https://github.com/apache/spark/pull/28128#issuecomment-631368636 **[Test build #122886 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122886/testReport)** for PR 28128 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28592: URL: https://github.com/apache/spark/pull/28592#issuecomment-631365817 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28128: URL: https://github.com/apache/spark/pull/28128#discussion_r427878719 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -940,20 +939,19 @@ object SparkSession extends Logging {

[GitHub] [spark] AmplabJenkins commented on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28592: URL: https://github.com/apache/spark/pull/28592#issuecomment-631365817 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631365273 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28128: URL: https://github.com/apache/spark/pull/28128#discussion_r427878311 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -1080,6 +1087,8 @@ object SparkSession extends Logging { }

[GitHub] [spark] cloud-fan commented on pull request #28128: [SPARK-31354] SparkContext only register one SparkSession ApplicationEnd listener

2020-05-20 Thread GitBox
cloud-fan commented on pull request #28128: URL: https://github.com/apache/spark/pull/28128#issuecomment-631365269 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631365273 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631364664 **[Test build #122885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122885/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631363588 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on pull request #28491: [SPARK-30267][SQL] Interoperability tests with Avro records generated by Avro4s

2020-05-20 Thread GitBox
cloud-fan commented on pull request #28491: URL: https://github.com/apache/spark/pull/28491#issuecomment-631364864 Promise the compatibility with avro4s is a big thing and needs to be voted by the PMC committee, so that the community will maintain it and clearly document it. If we

[GitHub] [spark] SparkQA commented on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
SparkQA commented on pull request #28592: URL: https://github.com/apache/spark/pull/28592#issuecomment-631364609 **[Test build #122884 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122884/testReport)** for PR 28592 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631302121 **[Test build #122878 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122878/testReport)** for PR 27006 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631363581 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
SparkQA commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631363447 **[Test build #122878 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122878/testReport)** for PR 27006 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #27006: [SPARK-30352][SQL] DataSourceV2: Add CURRENT_CATALOG function

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #27006: URL: https://github.com/apache/spark/pull/27006#issuecomment-631363581 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] gczsjdy commented on a change in pull request #25007: [SPARK-28209][CORE][SHUFFLE] Proposed new shuffle writer API

2020-05-20 Thread GitBox
gczsjdy commented on a change in pull request #25007: URL: https://github.com/apache/spark/pull/25007#discussion_r427875960 ## File path: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java ## @@ -99,74 +105,82 @@

[GitHub] [spark] cloud-fan commented on pull request #28574: [SPARK-31752][SQL][DOCS] Add sql doc for interval type

2020-05-20 Thread GitBox
cloud-fan commented on pull request #28574: URL: https://github.com/apache/spark/pull/28574#issuecomment-631362813 We should think about how to organize the docs. Now we have a page for all date types, a page for all functions, a page for all literal syntax. This PR adds a PR for

[GitHub] [spark] yaooqinn commented on pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
yaooqinn commented on pull request #28592: URL: https://github.com/apache/spark/pull/28592#issuecomment-631362554 cc @cloud-fan thanks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] yaooqinn opened a new pull request #28592: [SPARK-31771][SQL] Disable Narrow TextStyle for datetime pattern 'G/M/L/E/u/Q/q'

2020-05-20 Thread GitBox
yaooqinn opened a new pull request #28592: URL: https://github.com/apache/spark/pull/28592 ### What changes were proposed in this pull request? Five continuous pattern characters with 'G/M/L/E/u/Q/q' means Narrow-Text Style while we turn to use `java.time.DateTimeFormatterBuilder`

[GitHub] [spark] cloud-fan commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427870805 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,50 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427869922 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,50 @@ import

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427859032 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427854635 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427853571 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -1,5 +1,10 @@ -- date time functions +-- [SPARK-31710]

[GitHub] [spark] SparkQA commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
SparkQA commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631342514 **[Test build #122883 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122883/testReport)** for PR 28582 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427852118 ## File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ## @@ -1,5 +1,10 @@ -- date time functions +-- [SPARK-31710]

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427851647 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427851810 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] cloud-fan commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427851368 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] bart-samwel commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427850722 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,50 @@ import

[GitHub] [spark] AmplabJenkins commented on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631338687 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28582: [WIP][SPARK-31762][SQL] Fix perf regression of date/timestamp formatting in toHiveString

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28582: URL: https://github.com/apache/spark/pull/28582#issuecomment-631338687 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on a change in pull request #28576: [SPARK-31755][SQL] allow missing year/hour when parsing date/timestamp string

2020-05-20 Thread GitBox
cloud-fan commented on a change in pull request #28576: URL: https://github.com/apache/spark/pull/28576#discussion_r427847756 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -31,17 +31,50 @@ import

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631336207 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631329021 **[Test build #122882 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122882/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631336194 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
SparkQA commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631336178 **[Test build #122882 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122882/testReport)** for PR 28534 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
AmplabJenkins commented on pull request #28534: URL: https://github.com/apache/spark/pull/28534#issuecomment-631336194 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak commented on pull request #28512: [SPARK-31688][WEBUI] Refactor Pagination framework

2020-05-20 Thread GitBox
sarutak commented on pull request #28512: URL: https://github.com/apache/spark/pull/28512#issuecomment-631335641 Now I'm checking and will leave comment. This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] TJX2014 commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
TJX2014 commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427843241 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

[GitHub] [spark] bart-samwel commented on a change in pull request #28534: [SPARK-31710][SQL]TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and TIMESTAMP_MICROSECONDS to timestamp transfer

2020-05-20 Thread GitBox
bart-samwel commented on a change in pull request #28534: URL: https://github.com/apache/spark/pull/28534#discussion_r427840937 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -401,6 +401,78 @@ case class

<    1   2   3   4   5   >