HyukjinKwon commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427886436
########## File path: sbin/spark-daemon.sh ########## @@ -74,10 +75,13 @@ shift spark_rotate_log () { log=$1; - num=5; - if [ -n "$2" ]; then - num=$2 + + if [[ ${SPARK_LOG_MAX_FILES} -gt 5 ]] 2>/dev/null; then Review comment: Let's validate if this is a (positive) number and show a better error message. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org