HyukjinKwon commented on a change in pull request #28580: URL: https://github.com/apache/spark/pull/28580#discussion_r427884982
########## File path: sbin/spark-daemon.sh ########## @@ -23,6 +23,7 @@ # # SPARK_CONF_DIR Alternate conf dir. Default is ${SPARK_HOME}/conf. # SPARK_LOG_DIR Where log files are stored. ${SPARK_HOME}/logs by default. +# SPARK_LOG_MAX_FILES Max log files of Spark daemons can rotate to, at least 5. Review comment: I think you can just make it default 5. If it's lower then 5, it's okay because it's what the user set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org