[GitHub] [spark] AmplabJenkins removed a comment on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-636623328 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-636623328 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-31 Thread GitBox
SparkQA commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-636622976 **[Test build #123363 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123363/testReport)** for PR 28593 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-636617615 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-636617615 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-05-31 Thread GitBox
SparkQA commented on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-636617351 **[Test build #123362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123362/testReport)** for PR 28686 at commit

[GitHub] [spark] maropu commented on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-05-31 Thread GitBox
maropu commented on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-636615874 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] maropu commented on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-05-31 Thread GitBox
maropu commented on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-636615927 Looks okay to me. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-636505984 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan commented on a change in pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-31 Thread GitBox
cloud-fan commented on a change in pull request #28593: URL: https://github.com/apache/spark/pull/28593#discussion_r433043205 ## File path: docs/sql-migration-guide.md ## @@ -27,6 +27,10 @@ license: | - In Spark 3.1, grouping_id() returns long values. In Spark version 3.0

[GitHub] [spark] dongjoon-hyun commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
dongjoon-hyun commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636614856 Oh, got it. Thanks. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
cloud-fan commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636614381 There are several conflicts in the test suite when I backport to 3.0, I believe there are more conflicts in 2.4. @maropu can you send a new PR for 2.4? thanks!

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28689: [SPARK-31881][K8S][TESTS] Support Hadoop 3.2 K8s integration tests

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28689: URL: https://github.com/apache/spark/pull/28689#issuecomment-636613638 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28689: [SPARK-31881][K8S][TESTS] Support Hadoop 3.2 K8s integration tests

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28689: URL: https://github.com/apache/spark/pull/28689#issuecomment-636613638 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28689: [SPARK-31881][K8S][TESTS] Support Hadoop 3.2 K8s integration tests

2020-05-31 Thread GitBox
SparkQA commented on pull request #28689: URL: https://github.com/apache/spark/pull/28689#issuecomment-636613618 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27979/

[GitHub] [spark] dongjoon-hyun commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
dongjoon-hyun commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636612746 Hi, @cloud-fan . This is a bug since Apache Spark 2.0.x. Could you backport this to `branch-2.4` please, too?

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
jiangxb1987 commented on a change in pull request #28688: URL: https://github.com/apache/spark/pull/28688#discussion_r433040513 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ## @@ -171,8 +171,14 @@ private[spark] class Client(

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
jiangxb1987 commented on a change in pull request #28688: URL: https://github.com/apache/spark/pull/28688#discussion_r433040513 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ## @@ -171,8 +171,14 @@ private[spark] class Client(

[GitHub] [spark] jiangxb1987 commented on a change in pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
jiangxb1987 commented on a change in pull request #28688: URL: https://github.com/apache/spark/pull/28688#discussion_r433040297 ## File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ## @@ -171,8 +171,14 @@ private[spark] class Client(

[GitHub] [spark] maropu commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
maropu commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636611303 Thanks, all! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan closed pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
cloud-fan closed pull request #28681: URL: https://github.com/apache/spark/pull/28681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
cloud-fan commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636611001 thanks, merging to master/3.0! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27402: [SPARK-30679][SQL] REPLACE TABLE can omit the USING clause

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #27402: URL: https://github.com/apache/spark/pull/27402#issuecomment-636610715 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-636610692 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27402: [SPARK-30679][SQL] REPLACE TABLE can omit the USING clause

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #27402: URL: https://github.com/apache/spark/pull/27402#issuecomment-636610715 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-636610692 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-05-31 Thread GitBox
SparkQA commented on pull request #28690: URL: https://github.com/apache/spark/pull/28690#issuecomment-636610385 **[Test build #123360 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123360/testReport)** for PR 28690 at commit

[GitHub] [spark] SparkQA commented on pull request #27402: [SPARK-30679][SQL] REPLACE TABLE can omit the USING clause

2020-05-31 Thread GitBox
SparkQA commented on pull request #27402: URL: https://github.com/apache/spark/pull/27402#issuecomment-636610386 **[Test build #123361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123361/testReport)** for PR 27402 at commit

[GitHub] [spark] cloud-fan opened a new pull request #27402: [SPARK-30679][SQL] REPLACE TABLE can omit the USING clause

2020-05-31 Thread GitBox
cloud-fan opened a new pull request #27402: URL: https://github.com/apache/spark/pull/27402 ### What changes were proposed in this pull request? This PR updates the parser rule to allow `REPLACE TABLE` statement to omit the `USING` clause. This is extracted from

[GitHub] [spark] sarutak opened a new pull request #28690: [SPARK-31882][WEBUI] DAG-viz is not rendered correctly with pagination

2020-05-31 Thread GitBox
sarutak opened a new pull request #28690: URL: https://github.com/apache/spark/pull/28690 ### What changes were proposed in this pull request? This PR fix an issue related to DAG-viz. Because DAG-viz for a job fetches link urls for each stage from the stage table, rendering can

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-636608930 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-636608930 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-636550166 **[Test build #123355 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123355/testReport)** for PR 28647 at commit

[GitHub] [spark] SparkQA commented on pull request #28647: [SPARK-31828][SQL] Retain table properties at CreateTableLikeCommand

2020-05-31 Thread GitBox
SparkQA commented on pull request #28647: URL: https://github.com/apache/spark/pull/28647#issuecomment-636608382 **[Test build #123355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123355/testReport)** for PR 28647 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark SQL exceptions more Pythonic

2020-05-31 Thread GitBox
HyukjinKwon commented on pull request #28661: URL: https://github.com/apache/spark/pull/28661#issuecomment-636607739 Merged to master and branch-3.0. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] SparkQA commented on pull request #28689: [SPARK-31881][K8S][TESTS] Support Hadoop 3.2 K8s integration tests

2020-05-31 Thread GitBox
SparkQA commented on pull request #28689: URL: https://github.com/apache/spark/pull/28689#issuecomment-636607129 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/27979/

[GitHub] [spark] maropu commented on a change in pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-05-31 Thread GitBox
maropu commented on a change in pull request #28683: URL: https://github.com/apache/spark/pull/28683#discussion_r433036289 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2065,6 +2065,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] maropu commented on a change in pull request #28683: [SPARK-31875][SQL] Provide a option to disable user supplied Hints

2020-05-31 Thread GitBox
maropu commented on a change in pull request #28683: URL: https://github.com/apache/spark/pull/28683#discussion_r433036289 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2065,6 +2065,16 @@ object SQLConf { .booleanConf

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-636604160 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-636604160 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-636564586 **[Test build #123357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123357/testReport)** for PR 28607 at commit

[GitHub] [spark] SparkQA commented on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

2020-05-31 Thread GitBox
SparkQA commented on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-636603727 **[Test build #123357 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123357/testReport)** for PR 28607 at commit

[GitHub] [spark] iRakson commented on pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-31 Thread GitBox
iRakson commented on pull request #28439: URL: https://github.com/apache/spark/pull/28439#issuecomment-636602632 @sarutak Thank you for reviewing. I will update PR with test cases and suggested code changes. This is an

[GitHub] [spark] iRakson commented on a change in pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-31 Thread GitBox
iRakson commented on a change in pull request #28439: URL: https://github.com/apache/spark/pull/28439#discussion_r433033635 ## File path: streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ## @@ -17,30 +17,44 @@ package

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
dongjoon-hyun commented on a change in pull request #28681: URL: https://github.com/apache/spark/pull/28681#discussion_r433031791 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/objects.scala ## @@ -276,12 +276,12 @@ case class MapElementsExec( }

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636599803 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HeartSaVioR commented on a change in pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-05-31 Thread GitBox
HeartSaVioR commented on a change in pull request #28635: URL: https://github.com/apache/spark/pull/28635#discussion_r433030860 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/MSSQLConnectionProvider.scala ## @@ -0,0 +1,94 @@

[GitHub] [spark] AmplabJenkins commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636599803 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636599581 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636599581 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
SparkQA commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636599309 **[Test build #123354 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123354/testReport)** for PR 28681 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636544091 **[Test build #123354 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123354/testReport)** for PR 28681 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636599098 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636543164 **[Test build #123353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123353/testReport)** for PR 28681 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636599095 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636560939 **[Test build #123356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123356/testReport)** for PR 28679 at commit

[GitHub] [spark] SparkQA commented on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
SparkQA commented on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636598964 **[Test build #123356 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123356/testReport)** for PR 28679 at commit

[GitHub] [spark] SparkQA commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
SparkQA commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636599076 **[Test build #123353 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123353/testReport)** for PR 28681 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636599095 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28689: [SPARK-31881][K8S][TESTS] Support Hadoop 3.2 K8s integration tests

2020-05-31 Thread GitBox
SparkQA commented on pull request #28689: URL: https://github.com/apache/spark/pull/28689#issuecomment-636598512 **[Test build #123359 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123359/testReport)** for PR 28689 at commit

[GitHub] [spark] dongjoon-hyun opened a new pull request #28689: [SPARK-31881][K8S][TESTS] Support Hadoop 3.2 K8s integration tests

2020-05-31 Thread GitBox
dongjoon-hyun opened a new pull request #28689: URL: https://github.com/apache/spark/pull/28689 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ###

[GitHub] [spark] iRakson commented on a change in pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-31 Thread GitBox
iRakson commented on a change in pull request #28439: URL: https://github.com/apache/spark/pull/28439#discussion_r433030317 ## File path: streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ## @@ -49,147 +63,152 @@ private[ui] abstract class

[GitHub] [spark] iRakson commented on a change in pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-31 Thread GitBox
iRakson commented on a change in pull request #28439: URL: https://github.com/apache/spark/pull/28439#discussion_r433030132 ## File path: streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ## @@ -49,147 +63,152 @@ private[ui] abstract class

[GitHub] [spark] sarutak commented on pull request #28680: [SPARK-31871][CORE][UI] Display the canvas element icon for sorting column

2020-05-31 Thread GitBox
sarutak commented on pull request #28680: URL: https://github.com/apache/spark/pull/28680#issuecomment-636597515 @liucht-inspur It's funny that those icons are found in the current `master`.

[GitHub] [spark] HyukjinKwon commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-31 Thread GitBox
HyukjinKwon commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-636596558 I agree all with the practical points. I don't target to change our existing practices - I believe what you guys said are what the Apache Spark community is already doing

[GitHub] [spark] yaooqinn edited a comment on pull request #27943: [SPARK-31179] Fast fail the connection while last connection failed in fast fail time window

2020-05-31 Thread GitBox
yaooqinn edited a comment on pull request #27943: URL: https://github.com/apache/spark/pull/27943#issuecomment-636594123 I have applied this patch to our in-house spark distribution and run for more than one week. Sometimes, making things worse, especially, when the shuffle server JUST in

[GitHub] [spark] yaooqinn commented on pull request #27943: [SPARK-31179] Fast fail the connection while last connection failed in fast fail time window

2020-05-31 Thread GitBox
yaooqinn commented on pull request #27943: URL: https://github.com/apache/spark/pull/27943#issuecomment-636594123 I have applied this patch to our in-house spark distribution and run for more than one week. Sometimes, making things worse, especially, when the shuffle server JUST in GC STW

[GitHub] [spark] sarutak commented on a change in pull request #28439: [SPARK-30119][WEBUI] Add Pagination Support to Streaming Page

2020-05-31 Thread GitBox
sarutak commented on a change in pull request #28439: URL: https://github.com/apache/spark/pull/28439#discussion_r433005877 ## File path: streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ## @@ -49,147 +63,152 @@ private[ui] abstract class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636589406 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636589135 **[Test build #123358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123358/testReport)** for PR 28688 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636589224 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636589402 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
SparkQA commented on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636589399 **[Test build #123358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123358/testReport)** for PR 28688 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636589224 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
SparkQA commented on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636589135 **[Test build #123358 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123358/testReport)** for PR 28688 at commit

[GitHub] [spark] HeartSaVioR commented on pull request #28523: [SPARK-31706][SQL] add back the support of streaming update mode

2020-05-31 Thread GitBox
HeartSaVioR commented on pull request #28523: URL: https://github.com/apache/spark/pull/28523#issuecomment-636588332 First of all, I'd rather say I'm not in favor of "veto" due to drawbacks described already - personally I have been rarely voted -1 for the code change, even I was enough

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636588341 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636588341 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636538193 **[Test build #123352 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123352/testReport)** for PR 28681 at commit

[GitHub] [spark] caneGuy commented on pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
caneGuy commented on pull request #28688: URL: https://github.com/apache/spark/pull/28688#issuecomment-636587945 @jiangxb1987 i reopen this for https://github.com/apache/spark/pull/26503 thanks This is an automated message

[GitHub] [spark] caneGuy opened a new pull request #28688: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
caneGuy opened a new pull request #28688: URL: https://github.com/apache/spark/pull/28688 When we submit application to federation yarn cluster. Since getYarnClusterMetrics is not implemented. The submission will exit with failure.

[GitHub] [spark] SparkQA commented on pull request #28681: [SPARK-31854][SQL] Invoke in MapElementsExec should not propagate null

2020-05-31 Thread GitBox
SparkQA commented on pull request #28681: URL: https://github.com/apache/spark/pull/28681#issuecomment-636587851 **[Test build #123352 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123352/testReport)** for PR 28681 at commit

[GitHub] [spark] karuppayya commented on pull request #28686: [SPARK-31877][SQL]Avoid stats computation for Hive table

2020-05-31 Thread GitBox
karuppayya commented on pull request #28686: URL: https://github.com/apache/spark/pull/28686#issuecomment-636581844 @viirya @dongjoon-hyun @maropu @gatorsmile Can any of you help review the change. Thank you This is an

[GitHub] [spark] GuoPhilipse commented on pull request #28593: [SPARK-31710][SQL] Fail casting numeric to timestamp by default

2020-05-31 Thread GitBox
GuoPhilipse commented on pull request #28593: URL: https://github.com/apache/spark/pull/28593#issuecomment-636581461 Thanks maropu, will check it This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] caneGuy commented on pull request #26503: [SPARK-29880][CORE][YARN] Handle submit exception when submit to federation cluster

2020-05-31 Thread GitBox
caneGuy commented on pull request #26503: URL: https://github.com/apache/spark/pull/26503#issuecomment-636577732 @jiangxb1987 thanks, i will push a new commit today This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28687: [WIP][SPARK-31878][SQL] Create date formatter only once in `HiveResult`

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28687: URL: https://github.com/apache/spark/pull/28687#issuecomment-636569605 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28687: [WIP][SPARK-31878][SQL] Create date formatter only once in `HiveResult`

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28687: URL: https://github.com/apache/spark/pull/28687#issuecomment-636569605 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28687: [WIP][SPARK-31878][SQL] Create date formatter only once in `HiveResult`

2020-05-31 Thread GitBox
SparkQA commented on pull request #28687: URL: https://github.com/apache/spark/pull/28687#issuecomment-636568967 **[Test build #123351 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123351/testReport)** for PR 28687 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28687: [WIP][SPARK-31878][SQL] Create date formatter only once in `HiveResult`

2020-05-31 Thread GitBox
SparkQA removed a comment on pull request #28687: URL: https://github.com/apache/spark/pull/28687#issuecomment-636530422 **[Test build #123351 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123351/testReport)** for PR 28687 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-636564830 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-636564830 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28607: [SPARK-24634][SS] Add a new metric regarding number of inputs later than watermark plus allowed delay

2020-05-31 Thread GitBox
SparkQA commented on pull request #28607: URL: https://github.com/apache/spark/pull/28607#issuecomment-636564586 **[Test build #123357 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123357/testReport)** for PR 28607 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636561161 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636561161 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28679: [SPARK-31870][SQL][TESTS] Fix "Do not optimize skew join if additional shuffle" test having no skew join

2020-05-31 Thread GitBox
SparkQA commented on pull request #28679: URL: https://github.com/apache/spark/pull/28679#issuecomment-636560939 **[Test build #123356 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123356/testReport)** for PR 28679 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #28678: [SPARK-31874][SQL] Use `FastDateFormat` as the legacy fractional formatter

2020-05-31 Thread GitBox
HyukjinKwon commented on pull request #28678: URL: https://github.com/apache/spark/pull/28678#issuecomment-636558883 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] wangyum commented on a change in pull request #28575: [SPARK-31705][SQL] Push predicate through join by rewriting join condition to conjunctive normal form

2020-05-31 Thread GitBox
wangyum commented on a change in pull request #28575: URL: https://github.com/apache/spark/pull/28575#discussion_r432966520 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ## @@ -1372,6 +1376,108 @@ object

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28687: [WIP][SPARK-31878][SQL] Create date formatter only once in `HiveResult`

2020-05-31 Thread GitBox
AmplabJenkins removed a comment on pull request #28687: URL: https://github.com/apache/spark/pull/28687#issuecomment-636558311 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28687: [WIP][SPARK-31878][SQL] Create date formatter only once in `HiveResult`

2020-05-31 Thread GitBox
AmplabJenkins commented on pull request #28687: URL: https://github.com/apache/spark/pull/28687#issuecomment-636558311 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon closed pull request #28661: [SPARK-31849][PYTHON][SQL] Make PySpark SQL exceptions more Pythonic

2020-05-31 Thread GitBox
HyukjinKwon closed pull request #28661: URL: https://github.com/apache/spark/pull/28661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

  1   2   3   4   5   >