[GitHub] [spark] AmplabJenkins commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839915821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839915832 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42981/ --

[GitHub] [spark] AmplabJenkins commented on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839915826 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42979/ --

[GitHub] [spark] SparkQA commented on pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
SparkQA commented on pull request #32518: URL: https://github.com/apache/spark/pull/32518#issuecomment-839914752 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42977/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839913239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839912309 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42978/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-12 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-839911339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] yaooqinn commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631194854 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] [spark] srowen commented on pull request #32505: [SPARK-35373][BUILD] Check Maven artifact checksum in build/mvn

2021-05-12 Thread GitBox
srowen commented on pull request #32505: URL: https://github.com/apache/spark/pull/32505#issuecomment-839908551 I may merge this to master first to see if there are issues, then back-port it if it seems OK. We probably do want this as part of maintenance branches. -- This is an

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839907834 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42978/ -- This is an automated message from the Apache

[GitHub] [spark] yaooqinn commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839907616 thanks @dongjoon-hyun, I've updated PR with your comments addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
yaooqinn commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631191285 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala ## @@ -74,7 +74,7 @@ import

[GitHub] [spark] SparkQA commented on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
SparkQA commented on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839905998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
dongjoon-hyun edited a comment on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839898915 Hi, @gengliangwang and @sigmod . The last commit seems to break JAVA 11 consistently. Could you take a look at this? Thanks!

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
dongjoon-hyun edited a comment on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839898915 Hi, @gengliangwang and @sigmod . The last commit seems to break JAVA 11. Could you take a look at this? Thanks!

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
dongjoon-hyun edited a comment on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839898915 Hi, @gengliangwang and @sigmod . The last commit seems to break JAVA 11. Could you take a look at this? Thanks! -- This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
dongjoon-hyun commented on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839898915 Hi, @gengliangwang and @sigmod . The last commit seems to break JAVA 11. Could you take a look at this? -- This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839697574 **[Test build #138452 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138452/testReport)** for PR 32515 at commit

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839892464 **[Test build #138452 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138452/testReport)** for PR 32515 at commit

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631171488 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala ## @@ -46,16 +46,17 @@ import

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631175068 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -1203,4 +1204,22 @@ object SparkSession extends Logging {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631174479 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala ## @@ -1203,4 +1204,22 @@ object SparkSession extends Logging {

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631171488 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala ## @@ -46,16 +46,17 @@ import

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631171488 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala ## @@ -46,16 +46,17 @@ import

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631169547 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensionsProvider.scala ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32515: URL: https://github.com/apache/spark/pull/32515#discussion_r631166233 ## File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSessionExtensions.scala ## @@ -74,7 +74,7 @@ import

[GitHub] [spark] SparkQA removed a comment on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839693179 **[Test build #138450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138450/testReport)** for PR 32515 at commit

[GitHub] [spark] shahidki31 commented on a change in pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
shahidki31 commented on a change in pull request #32498: URL: https://github.com/apache/spark/pull/32498#discussion_r631162814 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -759,6 +759,10 @@ case class

[GitHub] [spark] dongjoon-hyun commented on pull request #32519: [SPARK-35347][SQL][FOLLOWUP] Throw exception when cannot find the method

2021-05-12 Thread GitBox
dongjoon-hyun commented on pull request #32519: URL: https://github.com/apache/spark/pull/32519#issuecomment-839879568 BTW, please revise the PR title, @viirya . `RuntimeException` is also a exception. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839879369 **[Test build #138450 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138450/testReport)** for PR 32515 at commit

[GitHub] [spark] shahidki31 commented on a change in pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
shahidki31 commented on a change in pull request #32498: URL: https://github.com/apache/spark/pull/32498#discussion_r631162814 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala ## @@ -759,6 +759,10 @@ case class

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32520: URL: https://github.com/apache/spark/pull/32520#discussion_r631160558 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSQueryTestSuite.scala ## @@ -83,12 +83,6 @@ class TPCDSQueryTestSuite extends

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32520: URL: https://github.com/apache/spark/pull/32520#discussion_r631160095 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala ## @@ -36,6 +36,12 @@ trait TPCDSBase extends SharedSparkSession with

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839867454 **[Test build #138460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138460/testReport)** for PR 32498 at commit

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
dongjoon-hyun edited a comment on pull request #32518: URL: https://github.com/apache/spark/pull/32518#issuecomment-839841587 > LGTM. Should we eventually do this in Hadoop, cc @steveloughran and @dongjoon-hyun ? Thank you for review, @dbtsai . The following two are Spark

[GitHub] [spark] SparkQA commented on pull request #32503: [WIP] better error message

2021-05-12 Thread GitBox
SparkQA commented on pull request #32503: URL: https://github.com/apache/spark/pull/32503#issuecomment-839864333 **[Test build #138458 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138458/testReport)** for PR 32503 at commit

[GitHub] [spark] SparkQA commented on pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-12 Thread GitBox
SparkQA commented on pull request #32494: URL: https://github.com/apache/spark/pull/32494#issuecomment-839864385 **[Test build #138459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138459/testReport)** for PR 32494 at commit

[GitHub] [spark] SparkQA commented on pull request #32515: [SPARK-35380][SQL] Loading SparkSessionExtensions from ServiceLoader

2021-05-12 Thread GitBox
SparkQA commented on pull request #32515: URL: https://github.com/apache/spark/pull/32515#issuecomment-839864289 **[Test build #138457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138457/testReport)** for PR 32515 at commit

[GitHub] [spark] SparkQA commented on pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
SparkQA commented on pull request #32518: URL: https://github.com/apache/spark/pull/32518#issuecomment-839864189 **[Test build #138456 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138456/testReport)** for PR 32518 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839861221 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138449/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839861223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins commented on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839861221 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138449/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839861223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32518: URL: https://github.com/apache/spark/pull/32518#discussion_r631119466 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -396,6 +396,8 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] [spark] shahidki31 commented on a change in pull request #32494: [SPARK-35362][SQL] Update null count in the column stats for UNION operator stats estimation

2021-05-12 Thread GitBox
shahidki31 commented on a change in pull request #32494: URL: https://github.com/apache/spark/pull/32494#discussion_r631128836 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/UnionEstimation.scala ## @@ -88,9 +88,18 @@

[GitHub] [spark] SparkQA removed a comment on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839659078 **[Test build #138449 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138449/testReport)** for PR 32482 at commit

[GitHub] [spark] SparkQA commented on pull request #32482: [SPARK-35332][SQL] Make cache plan disable configs configurable

2021-05-12 Thread GitBox
SparkQA commented on pull request #32482: URL: https://github.com/apache/spark/pull/32482#issuecomment-839847895 **[Test build #138449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138449/testReport)** for PR 32482 at commit

[GitHub] [spark] SparkQA commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839846869 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42976/ --

[GitHub] [spark] dongjoon-hyun commented on pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
dongjoon-hyun commented on pull request #32518: URL: https://github.com/apache/spark/pull/32518#issuecomment-839841587 > LGTM. Should we eventually do this in Hadoop, cc @steveloughran and @dongjoon-hyun ? Thank you for review, @dbtsai . The following two are Spark configurations.

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32518: URL: https://github.com/apache/spark/pull/32518#discussion_r631119466 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -396,6 +396,8 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32518: [SPARK-35383][CORE] Improve s3a magic committer support by inferring missing configs

2021-05-12 Thread GitBox
dongjoon-hyun commented on a change in pull request #32518: URL: https://github.com/apache/spark/pull/32518#discussion_r631119318 ## File path: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ## @@ -1237,6 +1238,53 @@ class SparkContextSuite extends SparkFunSuite

[GitHub] [spark] SparkQA removed a comment on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839732396 **[Test build #138453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138453/testReport)** for PR 32292 at commit

[GitHub] [spark] SparkQA commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839833251 **[Test build #138453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138453/testReport)** for PR 32292 at commit

[GitHub] [spark] SparkQA commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839817350 **[Test build #138455 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138455/testReport)** for PR 32292 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839813460 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138448/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32520: URL: https://github.com/apache/spark/pull/32520#issuecomment-839813464 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42975/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32520: URL: https://github.com/apache/spark/pull/32520#issuecomment-839813464 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42975/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839813460 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138448/

[GitHub] [spark] SparkQA commented on pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
SparkQA commented on pull request #32520: URL: https://github.com/apache/spark/pull/32520#issuecomment-839807672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] cloud-fan closed pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
cloud-fan closed pull request #32476: URL: https://github.com/apache/spark/pull/32476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] cloud-fan commented on pull request #32476: [SPARK-35349][SQL] Add code-gen for left/right outer sort merge join

2021-05-12 Thread GitBox
cloud-fan commented on pull request #32476: URL: https://github.com/apache/spark/pull/32476#issuecomment-839804392 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] gengliangwang commented on pull request #32292: [SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
gengliangwang commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839801210 @cloud-fan @maropu Sorry for the delay. This one is ready for review now. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] srowen commented on pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-12 Thread GitBox
srowen commented on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-839796652 Merged to master. Thanks again @luhenry for hanging in there - just wanted to be pretty sure about the change. It's a good one. @zhengruifeng this change is in. -- This

[GitHub] [spark] srowen closed pull request #32415: [SPARK-35295][ML] Replace fully com.github.fommil.netlib by dev.ludovic.netlib:2.0

2021-05-12 Thread GitBox
srowen closed pull request #32415: URL: https://github.com/apache/spark/pull/32415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] srowen commented on pull request #32455: [SPARK-35253][SQL][BUILD] Bump up the janino version to v3.1.4

2021-05-12 Thread GitBox
srowen commented on pull request #32455: URL: https://github.com/apache/spark/pull/32455#issuecomment-839795206 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] srowen closed pull request #32455: [SPARK-35253][SQL][BUILD] Bump up the janino version to v3.1.4

2021-05-12 Thread GitBox
srowen closed pull request #32455: URL: https://github.com/apache/spark/pull/32455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] srowen commented on pull request #32485: [SPARK-35357][GRAPHX] Allow to turn off the normalization applied by static PageRank utilities

2021-05-12 Thread GitBox
srowen commented on pull request #32485: URL: https://github.com/apache/spark/pull/32485#issuecomment-839794229 Merged to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] srowen closed pull request #32485: [SPARK-35357][GRAPHX] Allow to turn off the normalization applied by static PageRank utilities

2021-05-12 Thread GitBox
srowen closed pull request #32485: URL: https://github.com/apache/spark/pull/32485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [spark] srowen commented on pull request #31776: [SPARK-34661][SQL] Clean up `OriginalType` and `DecimalMetadata ` usage in Parquet related code

2021-05-12 Thread GitBox
srowen commented on pull request #31776: URL: https://github.com/apache/spark/pull/31776#issuecomment-839792934 Unless @wangyum has comments, I can merge to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] cloud-fan commented on a change in pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
cloud-fan commented on a change in pull request #32520: URL: https://github.com/apache/spark/pull/32520#discussion_r631062829 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala ## @@ -36,6 +36,12 @@ trait TPCDSBase extends SharedSparkSession with

[GitHub] [spark] SparkQA removed a comment on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839620790 **[Test build #138448 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138448/testReport)** for PR 32452 at commit

[GitHub] [spark] SparkQA commented on pull request #32452: [SPARK-35243][SQL] Support columnar execution on ANSI interval types

2021-05-12 Thread GitBox
SparkQA commented on pull request #32452: URL: https://github.com/apache/spark/pull/32452#issuecomment-839789596 **[Test build #138448 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138448/testReport)** for PR 32452 at commit

[GitHub] [spark] tgravescs commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
tgravescs commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839785104 changes look fine, assume it was manually tested -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] cloud-fan closed pull request #32499: [SPARK-29145][SQL][FOLLOWUP] Clean up code about support sub-queries in join conditions

2021-05-12 Thread GitBox
cloud-fan closed pull request #32499: URL: https://github.com/apache/spark/pull/32499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] cloud-fan commented on pull request #32499: [SPARK-29145][SQL][FOLLOWUP] Clean up code about support sub-queries in join conditions

2021-05-12 Thread GitBox
cloud-fan commented on pull request #32499: URL: https://github.com/apache/spark/pull/32499#issuecomment-839785448 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839780679 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138451/

[GitHub] [spark] AmplabJenkins commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839780679 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138451/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839693253 **[Test build #138451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138451/testReport)** for PR 32504 at commit

[GitHub] [spark] SparkQA commented on pull request #32504: [SPARK-35013][CORE] Don't allow to set spark.driver.cores=0

2021-05-12 Thread GitBox
SparkQA commented on pull request #32504: URL: https://github.com/apache/spark/pull/32504#issuecomment-839779483 **[Test build #138451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138451/testReport)** for PR 32504 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32292: [WIP][SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839769164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42974/

[GitHub] [spark] AmplabJenkins commented on pull request #32292: [WIP][SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839769164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42974/ --

[GitHub] [spark] SparkQA commented on pull request #32292: [WIP][SPARK-35162][SQL] New SQL functions: TRY_ADD/TRY_DIVIDE

2021-05-12 Thread GitBox
SparkQA commented on pull request #32292: URL: https://github.com/apache/spark/pull/32292#issuecomment-839769113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839768172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138441/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839768168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138445/

[GitHub] [spark] SparkQA commented on pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
SparkQA commented on pull request #32520: URL: https://github.com/apache/spark/pull/32520#issuecomment-839768710 **[Test build #138454 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138454/testReport)** for PR 32520 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839768169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138447/

[GitHub] [spark] AmplabJenkins commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839768168 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138445/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839768169 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138447/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
AmplabJenkins commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839768172 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138441/ -- This

[GitHub] [spark] maropu commented on a change in pull request #32454: [SPARK-35327][SQL][TESTS] Filters out the TPC-DS queries that can cause flaky test results

2021-05-12 Thread GitBox
maropu commented on a change in pull request #32454: URL: https://github.com/apache/spark/pull/32454#discussion_r631021871 ## File path: sql/core/src/test/scala/org/apache/spark/sql/TPCDSBase.scala ## @@ -24,7 +24,7 @@ import org.apache.spark.sql.test.SharedSparkSession trait

[GitHub] [spark] maropu opened a new pull request #32520: [SPARK-35385][SQL][TESTS] Skip duplicate queries in the TPCDS-related tests

2021-05-12 Thread GitBox
maropu opened a new pull request #32520: URL: https://github.com/apache/spark/pull/32520 ### What changes were proposed in this pull request? This PR proposes to skip the "q6", "q34", "q64", "q74", "q75", "q78" queries in the TPCDS-related tests because the TPCDS v2.7

[GitHub] [spark] SparkQA commented on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
SparkQA commented on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839752937 **[Test build #138447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138447/testReport)** for PR 32496 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32496: [SPARK-35207][SQL] Normalize hash function behavior with negative zero

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32496: URL: https://github.com/apache/spark/pull/32496#issuecomment-839579496 **[Test build #138447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138447/testReport)** for PR 32496 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839573760 **[Test build #138445 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138445/testReport)** for PR 32498 at commit

[GitHub] [spark] SparkQA commented on pull request #32498: [SPARK-35368][SQL] Update histogram statistics for RANGE operator for stats estimation

2021-05-12 Thread GitBox
SparkQA commented on pull request #32498: URL: https://github.com/apache/spark/pull/32498#issuecomment-839751330 **[Test build #138445 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138445/testReport)** for PR 32498 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA removed a comment on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839535644 **[Test build #138441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138441/testReport)** for PR 32478 at commit

[GitHub] [spark] SparkQA commented on pull request #32478: [SPARK-35063][SQL] Group exception messages in sql/catalyst

2021-05-12 Thread GitBox
SparkQA commented on pull request #32478: URL: https://github.com/apache/spark/pull/32478#issuecomment-839742044 **[Test build #138441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138441/testReport)** for PR 32478 at commit

[GitHub] [spark] gengliangwang closed pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
gengliangwang closed pull request #32439: URL: https://github.com/apache/spark/pull/32439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [spark] gengliangwang commented on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
gengliangwang commented on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839739715 Thanks, merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32439: [SPARK-35298][SQL] Migrate to transformWithPruning for rules in Optimizer.scala

2021-05-12 Thread GitBox
AmplabJenkins removed a comment on pull request #32439: URL: https://github.com/apache/spark/pull/32439#issuecomment-839733785 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138439/

<    1   2   3   4   5   6   7   8   >