Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r43419153
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -112,8 +139,13 @@ object LinearDataGenerator {
x.foreach
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9325#issuecomment-151756841
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9325#issuecomment-151744040
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42930781
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42923610
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42923796
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42923827
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +124,58 @@ object LinearDataGenerator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8972#discussion_r42700978
--- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
---
@@ -176,6 +176,21 @@ class KMeans @Since("1.5.0") (
@Si
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9180#discussion_r42701567
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/LinearDataGenerator.scala ---
@@ -125,6 +125,59 @@ object LinearDataGenerator
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149671660
@Lewuathe Can you create the JIRA with detail? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8972#issuecomment-149749287
Jenkins, ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9180#issuecomment-149727573
Or you can make them sparse by randomly choosing most of the features
zeros.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8972#issuecomment-149749214
Jenkins please test this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42339518
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42402026
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42402047
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-149295691
Thanks. Merged into master.
Please submit another PR to address the minor issues in the comment. We
would like to see that when solver is `auto`, the `normal
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401790
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401838
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401879
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42401980
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,603 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42328431
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r42327468
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +96,641 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148769776
@Lewuathe
They should be the same, but there is no test proving it.
Since in
```scala
test("linear regression with weighted sa
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-148321601
I'll be able to merge this PR once the following two issues are addressed,
1) Have a test to verify that `L1` with normal will throw
`IllegalArugmentExcpetion
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41899983
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41899604
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808787
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808876
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811201
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811297
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808590
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41809540
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810342
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810413
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41806842
--- Diff: R/pkg/R/mllib.R ---
@@ -45,12 +45,13 @@ setClass("PipelineModel", representation(model =
"jobj"))
#' summary(model)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41806833
--- Diff: R/pkg/R/mllib.R ---
@@ -45,12 +45,13 @@ setClass("PipelineModel", representation(model =
"jobj"))
#' summary(model)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41806848
--- Diff: R/pkg/R/mllib.R ---
@@ -45,12 +45,13 @@ setClass("PipelineModel", representation(model =
"jobj"))
#' summary(model)
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811015
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810986
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811080
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810586
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41808061
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810042
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810020
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-147546487
@Lewuathe LGTM except those minor issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41807118
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -73,7 +73,9 @@ private[shared] object SharedParamsCodeGen
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810438
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41809032
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -130,9 +131,54 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41810212
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r4184
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811141
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811124
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811137
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r41811067
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -93,525 +94,559 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-145968799
@Lewuathe What's the current status of this? We would like to have it in
Spark 1.6. Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8563#issuecomment-145967711
@nilmeier
I would like you to do it for readability, and I will make another pass on
algorithms and math this weekend. Thanks.
---
If your project is set up
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41108645
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41108858
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41109096
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41109078
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41109118
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41108769
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41109171
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8563#discussion_r41109156
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -402,4 +445,402 @@ class BlockMatrix @Since("
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40767420
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -541,36 +536,38 @@ private class LeastSquaresAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40767083
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -20,6 +20,7 @@ package
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8853#discussion_r40767101
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -20,6 +20,7 @@ package org.apache.spark.ml.regression
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144101215
I know `ml.feature` is mostly for feature engineering, but I don't think
`ml.util` is a good place. How about make it as first citizen in `ml`? I will
implement
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40746290
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -169,6 +181,33 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8853#issuecomment-144266021
Okay. It makes sense. But it's still private, and cleans up some code, do u
think it worths to merge it first and we can think about where is the best
place to have
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40569761
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -199,8 +238,8 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518453
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -92,13 +93,14 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518589
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -166,22 +171,25 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518573
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -166,22 +171,25 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518881
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -140,6 +141,17 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518874
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -140,6 +141,17 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518860
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -140,6 +141,17 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518531
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -113,34 +115,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518479
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -113,34 +115,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518507
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -113,34 +115,37 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518538
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -150,14 +155,14 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518823
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -357,4 +357,17 @@ private[ml] trait HasWeightCol extends Params
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40519224
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -199,8 +238,8 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40519125
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -169,6 +181,33 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40519092
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -169,6 +181,33 @@ class LinearRegression(override val uid: String
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518407
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -92,13 +93,14 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518673
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -302,29 +314,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518653
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -206,30 +213,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518663
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -255,29 +264,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518641
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -206,30 +213,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518652
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -206,30 +213,32 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518708
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -396,29 +413,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518699
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -350,28 +364,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518703
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -350,28 +364,31 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518680
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -334,13 +348,13 @@ class LinearRegressionSuite extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8884#discussion_r40518599
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
---
@@ -190,13 +198,12 @@ class LinearRegressionSuite extends
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/8884#issuecomment-143085746
Vote for adding a new param called "solver". In the unit test, we have to
test two code paths as well; otherwise, the previous LBFGS behavior will not be
te
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39947613
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -520,29 +544,32 @@ private class LeastSquaresAggregator
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/8631#discussion_r39995497
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -520,30 +544,33 @@ private class LeastSquaresAggregator
1101 - 1200 of 1777 matches
Mail list logo
