[GitHub] spark pull request: [SPARK-6511] [Documentation] Explain how to us...

2015-06-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6729#issuecomment-110501538 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [minor] [build] Use custom temp directory duri...

2015-06-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6653#issuecomment-109605849 @vanzin @srowen this broke the Spark 1.3 builds, so I revert it in the Spark 1.3 branch. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-7042] [BUILD] use the standard akka art...

2015-06-06 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6492#issuecomment-109606433 Yep LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-05 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-109173399 Hey Josh- I had this thought too, but I figured we can do it incrementally. On Thu, Jun 4, 2015 at 10:32 PM, Josh Rosen notificati...@github.com wrote

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31745029 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-2774] Set preferred locations for reduc...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4576#issuecomment-108750698 I am cleaning up old PR's and would propose to close this issue pending further discussion. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5694#issuecomment-108749526 Hey @brennonyork - sorry it took so long to review this. I can iterate on this much more closely over the next few days. I took a close look

[GitHub] spark pull request: [SPARK-4006] Block Manager - Double Register C...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2854#issuecomment-108751032 @tsliwowicz can you please close this pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-04 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31696016 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: SPARK-4585. Spark dynamic executor allocation ...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4051#issuecomment-108749911 For some reason this didn't close. @sryza can you close this issue? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-3650] Fix TriangleCount handling of rev...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2495#issuecomment-108749807 I'd like to close this issue pending further updates. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: SPARK-5425: Use synchronised methods in system...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/4222#issuecomment-108749998 @jacek-lewandowski can you close this issue? It didnt' close properly because of the way github auto-closes patches into release branches. --- If your project is set

[GitHub] spark pull request: [SPARK-2387][Core]Remove Stage's barrier

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3430#issuecomment-108749762 I'd propose to close this issue. It's a fairly large change and needs more discussion before being seriously considered to be part of spark. --- If your project

[GitHub] spark pull request: [SPARK-3172] [SPARK-3577] improve shuffle spil...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2504#issuecomment-108750834 This has gone stale so I'd like to close this issue pending further discussion. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3431] [WIP] Parallelize Scala/Java test...

2015-06-04 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/3564#issuecomment-108750767 I'd like to close this issue for now pending further development. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-7743] [SQL] Parquet 1.7

2015-06-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6597#issuecomment-108666438 @rxin user apps aren't isolated though, so it isn't free to upgrade dependencies. But I agree we should upgrade this one, it's buggy and a pretty old version of a fast

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-06-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6328#discussion_r31645833 --- Diff: project/MimaExcludes.scala --- @@ -34,6 +34,20 @@ import com.typesafe.tools.mima.core.ProblemFilters._ object MimaExcludes { def

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31694485 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31694637 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31694123 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31694783 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31694092 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-7017][Build][Project Infra]: Refactor d...

2015-06-03 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/5694#discussion_r31694598 --- Diff: dev/run-tests.py --- @@ -0,0 +1,417 @@ +#!/usr/bin/env python2 + +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-7743] [SQL] Parquet 1.7

2015-06-03 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6597#issuecomment-108669702 Oh I see- then it really doesn't interfere. Users can just add the existing one. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-8027] [SPARKR] Add maven profile to bui...

2015-06-02 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6567#discussion_r31561598 --- Diff: dev/create-release/create-release.sh --- @@ -228,14 +228,14 @@ if [[ ! $@ =~ --skip-package ]]; then # We increment the Zinc port each

[GitHub] spark pull request: [SPARKR-8027] [SPARKR] Move man pages creation...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6593#issuecomment-108094494 Yeah this seems strictly better --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8057][Core]Call TaskAttemptContext.getT...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6599#issuecomment-108145411 I think this affects embedded applications that pull in the spark core jar, and then try to run against a hadoop 2 cluster. Is that right @zsxwing? --- If your

[GitHub] spark pull request: [SPARK-8057][Core]Call TaskAttemptContext.getT...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6599#issuecomment-108146461 There are a large number of applications that embed Spark and they are some of Spark's most active users (e.g. Palantir, etc). If this makes it so that none of them

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-108182952 BTW - this is also important to do soon because of the fact that we publish snapshot releases now from both master and 1.4 branches. --- If your project is set up

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-108182864 @vanzin just updated to the newest RC. I kept racing with changes that were getting back-ported, so I gave up until the branch stabilized a bit. We can do

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-108189943 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [Minor]make the launcher project name consiste...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6603#issuecomment-108202939 Sure, sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8021] [SQL] [PYSPARK] make Python read/...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6578#issuecomment-107990804 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-8021] [SQL] [PYSPARK] make Python read/...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6578#issuecomment-107993570 This failed a totally unrelated streaming test, so I think it's okay. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-8038][SQL][PySpark] Fix when function o...

2015-06-02 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6580#issuecomment-108005849 Jenkins, retest this pleaas.e --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: Use addJar instead of setJars in SparkR

2015-06-01 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6568#issuecomment-107774267 Yeah this makes sense. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7890] [DOCS] Document that Spark 2.11 n...

2015-05-29 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6470#discussion_r31339059 --- Diff: docs/building-spark.md --- @@ -130,9 +130,7 @@ To produce a Spark package compiled with Scala 2.11, use the `-Dscala-2.11` prop dev

[GitHub] spark pull request: [SPARK-7890] [DOCS] Document that Spark 2.11 n...

2015-05-29 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6470#issuecomment-106903496 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-7930][CORE][STREAMING] Fixed shutdown h...

2015-05-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6482#discussion_r31293664 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -139,8 +139,8 @@ private[spark] class DiskBlockManager(blockManager

[GitHub] spark pull request: [SPARK-7930][CORE][STREAMING] Fixed shutdown h...

2015-05-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6482#issuecomment-106652213 Looks good, /cc @vanzin if he is interested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7933] Remove Patrick's username/pw from...

2015-05-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6485#issuecomment-106656457 Thanks - that was a dummy password I used there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-7931][STREAMING] Do not restart receive...

2015-05-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6483#issuecomment-106696198 I will adjust for the comment on merging, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-7890] [DOCS] Document that Spark 2.11 n...

2015-05-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6470#discussion_r31300185 --- Diff: docs/building-spark.md --- @@ -130,10 +130,6 @@ To produce a Spark package compiled with Scala 2.11, use the `-Dscala-2.11` prop dev

[GitHub] spark pull request: [SPARK-7930][CORE][STREAMING] Fixed shutdown h...

2015-05-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6482#issuecomment-106693882 Pulling this in despite style nit to cut RC3 (@vanzin still appreciate a post-hoc review if/when you have time). --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-7895][Streaming][Examples] Move Kafka e...

2015-05-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6436#issuecomment-106192382 LGTM as well - seems like there is one small unrelated change though in here. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-7895][Streaming][Examples] Move Kafka e...

2015-05-28 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6436#discussion_r31205831 --- Diff: examples/src/main/scala/org/apache/spark/examples/streaming/KafkaWordCount.scala --- @@ -96,7 +96,7 @@ object KafkaWordCountProducer

[GitHub] spark pull request: [SPARK-7895][Streaming][Examples] Move Kafka e...

2015-05-28 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6436#issuecomment-106446186 Okay, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7873] Allow KryoSerializerInstance to c...

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6415#issuecomment-106158088 Okay, merging this - thanks guys. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: SPARK-7896. Allow ChainedBuffer to store more ...

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6440#issuecomment-106158073 @zsxwing mind doing a final sign off on this? This is the last thing before we can cut RC3. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-7907] [SQL] Rename ThriftServer to JDBC...

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6448#issuecomment-106118077 LGTM - minor suggestion to add a space here in the presentation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-7907] [SQL] Rename ThriftServer to JDBC...

2015-05-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6448#discussion_r31193485 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala --- @@ -55,7 +55,7 @@ private[ui

[GitHub] spark pull request: [SPARK-7907] [SQL] Rename ThriftServer to JDBC...

2015-05-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6448#discussion_r31193477 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerPage.scala --- @@ -47,7 +47,7 @@ private[ui] class

[GitHub] spark pull request: [SPARK-7907] [SQL] Rename ThriftServer to JDBC...

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6448#issuecomment-106123100 After some more thought I was thinking maybe: 1. Have the top level tab be SQL. 2. Have the section title say JDBC/ODBC Server --- If your project is set

[GitHub] spark pull request: [SPARK-7558] Demarcate tests in unit-tests.log

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6441#issuecomment-106164290 Can we exclude guava from tachyon in the test dependency? - Patrick On Wed, May 27, 2015 at 8:56 PM, andrewor14 notificati...@github.com wrote

[GitHub] spark pull request: SPARK-7896. Allow ChainedBuffer to store more ...

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6440#issuecomment-106174764 Okay - I am going to merge this and make the suggested change by @zsxwing. Wouldn't normally do this but it's blocking the RC3 for Spark 1.4.0 and I'd like to kick off

[GitHub] spark pull request: [SPARK-7558] Demarcate tests in unit-tests.log

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6441#issuecomment-106101709 Can you use the same patterns for the start and finish thresholds? Any reason to use `===` and then `***`? ``` = TEST OUTPUT

[GitHub] spark pull request: Updated the Running Tests section in README....

2015-05-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6446#issuecomment-106108092 Hey Taka, So actually, I think the docs here are correct. You tried to first do mvn package and then do dev/run-tests. That's why it broke. In reality users can either

[GitHub] spark pull request: [WIP][SPARK-7562][SPARK-6444][SQL] Improve err...

2015-05-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6405#discussion_r31108410 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -124,12 +124,45 @@ case class GroupExpression

[GitHub] spark pull request: [WIP][SPARK-7562][SPARK-6444][SQL] Improve err...

2015-05-27 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6405#discussion_r31108438 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -124,12 +124,45 @@ case class GroupExpression

[GitHub] spark pull request: [SPARK-7873] [WIP] Fix another bug related to ...

2015-05-26 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6415#issuecomment-105622629 /cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-7873] [WIP] Fix another bug related to ...

2015-05-26 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6415#issuecomment-105622792 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7042][BUILD] use the standard akka arti...

2015-05-25 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6341#issuecomment-105285474 LGTM - just for documentation, the changes I made to akka are available here: https://github.com/pwendell/akka/commits/2.2.3-shaded-proto The only

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-24 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-105070762 Jenkins, retest this please (actually one more just to make sure MIMA is still passing) --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-24 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-105070450 This is a pretty straightforward change so I'm just going to pull it in. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-7805] [SQL] Move SQLTestUtils.scala and...

2015-05-24 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6334#issuecomment-104985402 LGTM - thanks @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7845] [Build] Bump Hadoop 1 tests to ...

2015-05-24 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6384#issuecomment-104985324 LGTM pending tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7777][Streaming] Handle the case when t...

2015-05-23 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6372#issuecomment-104850450 @tdas FYI you didn't merge this. Did you intend to? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-104546054 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7771] [SPARK-7779] Dynamic allocation: ...

2015-05-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6301#issuecomment-104795446 LGTM - makes sense to lower these thresholds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Fix install jira-python

2015-05-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6367#issuecomment-104822088 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-6811] Copy SparkR lib in make-distribut...

2015-05-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6373#issuecomment-104847426 make-distribution changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [MINOR] Add SparkR to create-release script

2015-05-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6371#issuecomment-104847472 Thanks merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7836] [SPARK-7822] Python API of window...

2015-05-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6364#issuecomment-104847712 I think this still needs sign off from @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-104427703 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-10836 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-104439676 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-104524055 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-21 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/spark/pull/6328 [SPARK-7801] [BUILD] Updating versions to SPARK 1.5.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/pwendell/spark spark-1.5-update

[GitHub] spark pull request: [SPARK-7801] [BUILD] Updating versions to SPAR...

2015-05-21 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6328#issuecomment-104398048 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7320] [SQL] Add Cube / Rollup for dataf...

2015-05-20 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6257#issuecomment-104031935 I had to revert this due to a test issue, see the JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-7389] [core]Tachyon integration improve...

2015-05-19 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5908#issuecomment-103679615 I think this will have to go into master branch since it is way past the deadline and people have already started testing this code. For more information about

[GitHub] spark pull request: [SPARK-7389] [core]Tachyon integration improve...

2015-05-19 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/5908#issuecomment-103679798 Also this still needs an LGTM from @rxin or some active committer. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-7726] Fix Scaladoc false errors

2015-05-19 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6260#issuecomment-103637647 LGTM - I tested the reproduction and it worked fine. I can pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-7624] Revert #4147

2015-05-18 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6172#issuecomment-103195982 /cc @kayousterhout --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [MINOR] Add 1.3, 1.3.1 to master branch EC2 sc...

2015-05-16 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6215#issuecomment-102749939 Yeah LGTM. The issue is that I usually update these on release branches before we cut a release, so the master branch has fallen out of date. --- If your project

[GitHub] spark pull request: [SPARK-7660] Wrap SnappyOutputStream to work a...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6176#issuecomment-102290375 @JoshRosen does it make sense to re-enable those flakey tests in this patch? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-7491][SQL] Allow configuration of class...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6167#issuecomment-102547052 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-7655][Core][SQL] Remove 'scala.concurre...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6200#issuecomment-102551578 I'm not an expert on this code but it LGTM - it seems like the goal here is to isolate the thread pool used by the broadcasts. --- If your project is set up

[GitHub] spark pull request: [SPARK-7655][Core][SQL] Remove 'scala.concurre...

2015-05-15 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6200#discussion_r30455086 --- Diff: core/src/main/scala/org/apache/spark/rpc/akka/AkkaRpcEnv.scala --- @@ -247,6 +249,10 @@ private[spark] class AkkaRpcEnvFactory extends

[GitHub] spark pull request: [SPARK-7563] OutputCommitCoordinator.stop() sh...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6197#issuecomment-102558573 LGTM (seems pretty straightforward) - I can pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-7563] OutputCommitCoordinator.stop() sh...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6197#issuecomment-102558672 I pulled this into 1.4. I did not pull it into 1.3 due to a conflict. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-7676] Bug fix and cleanup of stage time...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6202#issuecomment-102545735 I think @kayousterhout is right - we can remove the feature since it's only useful in a small number of cases. On Fri, May 15, 2015 at 3:54 PM, Kousuke

[GitHub] spark pull request: [SPARK-7660] Wrap SnappyOutputStream to work a...

2015-05-15 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6176#discussion_r30454162 --- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala --- @@ -154,8 +154,53 @@ class SnappyCompressionCodec(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-7660] Wrap SnappyOutputStream to work a...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6176#issuecomment-102547304 Josh this LGTM - if there are no outstanding comments we should try to get this in since it's one of the few remaining blockers. --- If your project is set up

[GitHub] spark pull request: [SPARK-7660] Wrap SnappyOutputStream to work a...

2015-05-15 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/6176#discussion_r30454537 --- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala --- @@ -154,8 +154,53 @@ class SnappyCompressionCodec(conf: SparkConf) extends

[GitHub] spark pull request: [SPARK-4556] [BUILD] binary distribution assem...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6186#issuecomment-102507663 Yeah I think so - we've had this around for a long time and I use it heavily as part of releases. I've actually made some effort to support backwards compatibility

[GitHub] spark pull request: [SPARK-6154][streaming] Add Kafka modules to t...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6149#issuecomment-102499925 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6154][streaming] Add Kafka modules to t...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6149#issuecomment-102458322 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-6154][streaming] Add Kafka modules to t...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6149#issuecomment-102458359 @dragos yeah I think it's fine - let's see if tests pass and I will merge it. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-7660] Wrap SnappyOutputStream to work a...

2015-05-15 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/6176#issuecomment-102458474 @JoshRosen ah totally understand - got it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    1   2   3   4   5   6   7   8   9   10   >