[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r320541077 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319953081 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319953013 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319953154 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319952695 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319951300 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319950056 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r319949113 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r318533829 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r318533114 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r318532966 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r318532780 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r318529700 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions

cloud-fan commented on a change in pull request #20965: [SPARK-21870][SQL] Split aggregation code into small functions URL: https://github.com/apache/spark/pull/20965#discussion_r318525635 ## File path: