[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463454135 ## File path: sql/core/src/test/resources/sql-tests/inputs/group-by-filter.sql ## @@ -36,8 +36,11 @@ SELECT COUNT(id) FILTER (WHERE hiredate = date

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463449645 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -207,13 +257,30 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463448075 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -118,6 +118,49 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463448075 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -118,6 +118,49 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463441087 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -207,13 +257,30 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463395906 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -207,13 +257,30 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r463395762 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -207,13 +257,30 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r462958983 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -184,8 +227,8 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r462958305 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -144,28 +192,23 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r462957711 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -144,28 +192,23 @@ import

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r462957297 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -207,13 +256,35 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r462917670 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -207,13 +256,35 @@ object

[GitHub] [spark] cloud-fan commented on a change in pull request #29291: [SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

cloud-fan commented on a change in pull request #29291: URL: https://github.com/apache/spark/pull/29291#discussion_r462915233 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteDistinctAggregates.scala ## @@ -144,28 +192,23 @@ import