[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-26 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r512385606 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -27,7 +27,8 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-26 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511785233 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-26 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511784684 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala ## @@ -53,16 +53,18 @@ trait AnalysisTest extends

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-26 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511782477 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala ## @@ -439,7 +438,7 @@ case class RowToColumnarExec(child: SparkPlan)

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-26 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511781341 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala ## @@ -771,22 +771,23 @@ class AnalysisSuite

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-26 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511733174 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-26 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511733414 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-25 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511711363 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-25 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511710832 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-25 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511710003 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-25 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511708600 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-25 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r511708238 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/PruneHiveTablePartitions.scala ## @@ -29,22 +29,9 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-22 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r510549621 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ## @@ -182,7 +182,7 @@ class Analyzer( Review

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-22 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r510548134 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala ## @@ -28,7 +28,8 @@ import

[GitHub] [spark] leanken commented on a change in pull request #30097: [SPARK-33140][SQL] remove SQLConf and SparkSession in all sub-class of Rule[QueryPlan]

2020-10-22 Thread GitBox
leanken commented on a change in pull request #30097: URL: https://github.com/apache/spark/pull/30097#discussion_r510548134 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveInlineTables.scala ## @@ -28,7 +28,8 @@ import