Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-162099720
So I changed this a bit @dbtsai (mostly just avoid wrapping the call in one
place) - let me know what you think.
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161096854
**[Test build #46983 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46983/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161097041
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161097044
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161085782
**[Test build #46983 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46983/consoleFull)**
for PR 9524 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161030561
**[Test build #46966 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46966/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161031415
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161031411
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-161031402
**[Test build #46966 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46966/consoleFull)**
for PR 9524 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-159577543
**[Test build #46677 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46677/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-159577586
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-159577588
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45806031
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -85,7 +85,7 @@ final class CategoricalSplit private[ml] (
/**
* If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-159522953
**[Test build #46677 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46677/consoleFull)**
for PR 9524 at commit
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45781057
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -85,7 +85,7 @@ final class CategoricalSplit private[ml] (
/**
* If
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45668718
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45668650
--- Diff: mllib/pom.xml ---
@@ -125,6 +125,10 @@
org.apache.spark
spark-test-tags_${scala.binary.version}
+
+
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45669138
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45669679
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/Split.scala ---
@@ -85,7 +85,7 @@ final class CategoricalSplit private[ml] (
/**
* If
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45668289
--- Diff: mllib/pom.xml ---
@@ -125,6 +125,10 @@
org.apache.spark
spark-test-tags_${scala.binary.version}
+
+
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9524#discussion_r45669204
--- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala
---
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-158359278
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-158346630
**[Test build #46411 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46411/consoleFull)**
for PR 9524 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-158358994
**[Test build #46411 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46411/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-158359281
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
GitHub user holdenk reopened a pull request:
https://github.com/apache/spark/pull/9524
[SPARK-10387][ML][WIP] Add code gen for gbt
This PR adds code gen for GBT in ML. It does this using quasi quotes since
they give nice compile time type messages. The API could also use some
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-158343945
@dbtsai : I've fixed the issue with generating large trees (depth > 10)
that I found while doing the performance testing.
---
If your project is set up for it, you can
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-157306569
@holdenk Ping me when you address the issue and reopen it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-157281355
Mind closing and reopening when it is ready?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-157281738
Sure thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user holdenk closed the pull request at:
https://github.com/apache/spark/pull/9524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154672307
**[Test build #45278 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45278/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154672657
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154738601
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154738590
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154748281
**[Test build #45289 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45289/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154748475
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154738488
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154738716
**[Test build #45289 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45289/consoleFull)**
for PR 9524 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154775878
I think the mesos test failure was unrelated, jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154775922
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154775926
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154776182
**[Test build #45297 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45297/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154776724
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154776726
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154776803
**[Test build #45298 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45298/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154773216
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154773212
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154773299
**[Test build #45294 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45294/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154775823
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154775811
**[Test build #45294 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45294/consoleFull)**
for PR 9524 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154778091
**[Test build #45298 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45298/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154778100
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154780369
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154780356
**[Test build #45297 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45297/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154567482
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154564354
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154564403
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154567471
**[Test build #45264 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45264/consoleFull)**
for PR 9524 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154566863
**[Test build #45264 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45264/consoleFull)**
for PR 9524 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154651583
**[Test build #45278 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45278/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154650846
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154650835
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154505864
Please don't use macros and quasiquotes. They are slow and not IDE
friendly. We replaced them with Janino in SQL.
---
If your project is set up for it, you can reply to
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154510939
@rxin Ok I'll update this to use Janino although I'll miss my compile time
type checking I figured I'd probably have to do that. In the meantime does the
API look like
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154511927
there isn't really compile time type checking -- it just has syntax
checking to ensure it's a valid tree...
---
If your project is set up for it, you can reply to this
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/9524
[SPARK-10387][ML][WIP] Add code gen for gbt
This PR adds code gen for GBT in ML. It does this using quasi quotes since
they give nice compile time type messages. The API could also use some
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154495912
Build started sha1 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154495806
Build triggered. sha1 is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154497567
**[Test build #45231 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45231/consoleFull)**
for PR 9524 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154522152
**[Test build #45231 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45231/consoleFull)**
for PR 9524 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154522232
Build finished. 6703 tests run, 0 skipped, 1 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154522235
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45231/
---
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154513243
ah ok - well less of a loss then. I'll switch it around of course.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/9524#issuecomment-154547057
streaming test failure seems unrelated but won't retrigger since need to
rewrite the codegen anyways.
---
If your project is set up for it, you can reply to this email
75 matches
Mail list logo
