Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175296938
Merging with master
Btw, I verified that the doc generates in the same way.
---
If your project is set up for it, you can reply to this email and have your
r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175292057
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175292054
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175291858
**[Test build #50134 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50134/consoleFull)**
for PR 10216 at commit
[`8396aef`](https://g
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175290621
I hate copy'paste code, so glad to be able to kill some (and not make more
of making Python wrappers) :)
---
If your project is set up for it, you can reply to this em
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175288849
LGTM pending tests.
Thanks a lot for this PR---this is awesome!
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175288337
**[Test build #50134 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50134/consoleFull)**
for PR 10216 at commit
[`8396aef`](https://gi
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175284908
@jkbradley thanks addressed those small issues :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175275448
Just a few small comments now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r50913777
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -171,12 +169,10 @@ def get$Name(self):
Mixin for Decision Tree parameters.
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r50913787
--- Diff: python/pyspark/ml/regression.py ---
@@ -627,13 +600,6 @@ def __init__(self, featuresCol="features",
labelCol="label", predictionCol="pred
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r50913760
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -171,12 +169,10 @@ def get$Name(self):
Mixin for Decision Tree parameters.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175221074
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175221080
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175220787
**[Test build #50122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50122/consoleFull)**
for PR 10216 at commit
[`0d28922`](https://g
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175218475
Ohh, right! Thanks for remembering. Should I make another pass?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175211615
**[Test build #50122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50122/consoleFull)**
for PR 10216 at commit
[`0d28922`](https://gi
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-175162340
@jkbradley I mean there is also the shared params code gen, so we would
want to update the generated params as well (right now the change only affects
the manual params
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r50784366
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -40,6 +40,15 @@ def __init__(self, parent, name, doc, expectedType=None):
self.doc = str(d
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r50784271
--- Diff: python/pyspark/ml/classification.py ---
@@ -93,9 +93,7 @@ def __init__(self, featuresCol="features",
labelCol="label", predictionCol="pred
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-174756531
@holdenk I'm not quite sure what you mean, but I'll comment in a few places
to make sure I make my idea clear.
---
If your project is set up for it, you can reply to
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r50784244
--- Diff: python/pyspark/ml/classification.py ---
@@ -72,7 +72,6 @@ class LogisticRegression(JavaEstimator, HasFeaturesCol,
HasLabelCol, HasPredicti
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-174730511
@jkbradley sounds interesting - would probably want to change the code
generated params as well then to match but yah I'll take a crack at that this
week.
---
If your
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-174721577
@holdenk Sorry for the delay. This looks great, but I was wondering if it
could be improved even further: Would it be possible to add a method in the
```__init__```
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-174671838
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-174671836
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-174671672
**[Test build #50013 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50013/consoleFull)**
for PR 10216 at commit
[`53edd3d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-174665707
**[Test build #50013 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50013/consoleFull)**
for PR 10216 at commit
[`53edd3d`](https://gi
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-172950923
ping @jkbradley if you've got the time to look at this that would be
awesome.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-172238341
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-172238338
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-172238296
**[Test build #49533 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49533/consoleFull)**
for PR 10216 at commit
[`c4a2919`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-172237210
**[Test build #49533 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49533/consoleFull)**
for PR 10216 at commit
[`c4a2919`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170712382
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170712385
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170712103
**[Test build #49176 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49176/consoleFull)**
for PR 10216 at commit
[`7aecb59`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170707227
**[Test build #49176 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49176/consoleFull)**
for PR 10216 at commit
[`7aecb59`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170156115
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170156117
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170156009
**[Test build #49032 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49032/consoleFull)**
for PR 10216 at commit
[`e0f3f00`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170154669
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170154671
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170154583
**[Test build #49031 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49031/consoleFull)**
for PR 10216 at commit
[`8e8cbae`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170154012
**[Test build #49032 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49032/consoleFull)**
for PR 10216 at commit
[`e0f3f00`](https://gi
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r49249638
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -39,6 +39,15 @@ def __init__(self, parent, name, doc):
self.name = str(name)
se
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-170152333
**[Test build #49031 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49031/consoleFull)**
for PR 10216 at commit
[`8e8cbae`](https://gi
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r49247124
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -39,6 +39,15 @@ def __init__(self, parent, name, doc):
self.name = str(name)
se
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r49247152
--- Diff: python/pyspark/ml/tests.py ---
@@ -163,6 +163,14 @@ def setParams(self, seed=None):
class ParamTests(PySparkTestCase):
+def
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r49246995
--- Diff: python/pyspark/ml/classification.py ---
@@ -93,9 +93,7 @@ def __init__(self, featuresCol="features",
labelCol="label", predictionCol="pred
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-169957991
@holdenk Sorry for late response, please see my inline comments.
This patch works well, but I think we should to ensure it conforms to the
structure of the basic
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r49175186
--- Diff: python/pyspark/ml/tests.py ---
@@ -163,6 +163,14 @@ def setParams(self, seed=None):
class ParamTests(PySparkTestCase):
+
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r49175013
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -39,6 +39,15 @@ def __init__(self, parent, name, doc):
self.name = str(name)
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/10216#discussion_r49174887
--- Diff: python/pyspark/ml/classification.py ---
@@ -93,9 +93,7 @@ def __init__(self, featuresCol="features",
labelCol="label", predictionCol="pred
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-169808529
cc @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-169604721
re-ping @yanboliang if you have any thoughts on this approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-168056587
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-168056585
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-168056500
**[Test build #48492 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48492/consoleFull)**
for PR 10216 at commit
[`384fd0d`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-168054348
**[Test build #48492 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48492/consoleFull)**
for PR 10216 at commit
[`384fd0d`](https://gi
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-168050219
ping @yanboliang if you have a chance to look at this would be appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-164526041
cc @JoshRosen & @yanboliang who have probably had to deal with a fair
amount of this boilerplate code in the past.
---
If your project is set up for it, you can reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-163108450
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-163108449
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-163108369
**[Test build #47408 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47408/consoleFull)**
for PR 10216 at commit
[`a976b78`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10216#issuecomment-163107144
**[Test build #47408 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47408/consoleFull)**
for PR 10216 at commit
[`a976b78`](https://gi
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/10216
[SPARK-10509][PYSPARK] Reduce excessive param boiler plate code
The current python ml params require cut-and-pasting the param setup and
description between the class & ```__init__``` methods. Remo
67 matches
Mail list logo
