Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8706
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139568547
[Test build #1742 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1742/console)
for PR 8706 at commit
[`e6524b8`](https://github
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139533234
[Test build #1742 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1742/consoleFull)
for PR 8706 at commit
[`e6524b8`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139531014
[Test build #42328 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42328/console)
for PR 8706 at commit
[`e6524b8`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139531070
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139531073
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139503962
[Test build #42328 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42328/consoleFull)
for PR 8706 at commit
[`e6524b8`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139503529
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139503511
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139501943
All the rest of the comments look good and I've implemented them in the
next push. There's no good answer on some of these indentations, but I tried to
standardize it mor
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39256157
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1818,26 +1815,25 @@ public Integer call(String s) throws Exception {
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139407207
LGTM, just minor things. Not super sold on the alignment style (seems most
of existing code does it differently), but don't really care either way.
---
If your project i
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39225456
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaReceiverAPISuite.java ---
@@ -95,50 +94,49 @@ public Void call(JavaRDD rdd) throws Exception {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39225379
--- Diff:
streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java ---
@@ -1818,26 +1815,25 @@ public Integer call(String s) throws Exception {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39224664
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -973,7 +978,7 @@ public void repartition() {
List> result1 = repartitioned1.glom
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39225018
--- Diff:
sql/core/src/test/java/test/org/apache/spark/sql/JavaApplySchemaSuite.java ---
@@ -130,26 +132,27 @@ public void dataFrameRDDOperations() {
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39224677
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -982,7 +987,7 @@ public void repartition() {
List> result2 = repartitioned2.glom
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8706#discussion_r39224515
--- Diff: core/src/test/java/org/apache/spark/JavaAPISuite.java ---
@@ -214,10 +216,10 @@ public int getPartition(Object key) {
Assert.assertTrue(repar
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139401920
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139401917
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139401829
[Test build #42290 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42290/console)
for PR 8706 at commit
[`3ecaf9f`](https://github.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139361792
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139362231
[Test build #42290 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42290/consoleFull)
for PR 8706 at commit
[`3ecaf9f`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8706#issuecomment-139361717
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/8706
[SPARK-10547] [TEST] Streamline / improve style of Java API tests
Fix a few Java API test style issues: unused generic types, exceptions,
wrong assert argument order
You can merge this pull request
25 matches
Mail list logo