Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8872
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-187324256
No worries, thanks for addressing them. I'm merging this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186534096
@andrewor14 Sorry for the mess up, I kept thinking the code was ready just
needed to rebase and address comments. The rebase and comments did cause some
style problems
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53546468
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -442,9 +443,12 @@ private[spark] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186486243
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186486247
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186485951
**[Test build #51582 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51582/consoleFull)**
for PR 8872 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186459730
**[Test build #51582 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51582/consoleFull)**
for PR 8872 at commit
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186454509
retest please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186454538
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186453924
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186453926
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-186443529
@tnachen I don't think this patch is quite ready to be merged yet; the code
quality can still improve in a few places I pointed out in my comments.
---
If your
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53531547
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -442,9 +443,12 @@ private[spark] class
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53531469
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -452,38 +456,42 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53530854
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -452,38 +456,42 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53530824
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -496,28 +504,29 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53530197
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -452,38 +456,42 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r53530010
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -452,38 +456,42 @@ private[spark] class
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-184461120
@andrewor14 PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-184295000
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-184295002
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-184294723
**[Test build #51312 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51312/consoleFull)**
for PR 8872 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-184237515
**[Test build #51312 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51312/consoleFull)**
for PR 8872 at commit
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-183898284
We already have some shared logic of using multiple resources from
different roles, it just wasn't plugged in when I wrote the cluster scheduler.
I think now we have
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r52843425
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -525,14 +531,14 @@ private[spark] class
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r52843376
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -525,14 +531,14 @@ private[spark] class
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-178501728
For the record,
[SPARK-10444](https://issues.apache.org/jira/browse/SPARK-10444)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r51481128
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
---
@@ -0,0 +1,139 @@
+/*
--- End diff --
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r51481006
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -525,14 +531,14 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r51480776
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -497,28 +505,28 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r51480535
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -456,34 +460,36 @@ private[spark] class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-178195492
@tnachen echoing my comment from another PR: it seems that this feature is
already supported in client mode but not in cluster mode. Is there something we
can do
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176599538
Looks like there are more rules to scala style now, it's finally passing!
@andrewor14 PTAL
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176383856
**[Test build #50293 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50293/consoleFull)**
for PR 8872 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176381627
**[Test build #50292 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50292/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176381644
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176380674
**[Test build #50292 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50292/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176384707
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176381648
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176384712
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176384693
**[Test build #50293 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50293/consoleFull)**
for PR 8872 at commit
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176377522
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176563517
**[Test build #50326 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50326/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176563905
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176563907
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-176525823
**[Test build #50326 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50326/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-173841919
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-173841915
**[Test build #49914 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49914/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-173841921
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-173841613
**[Test build #49914 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49914/consoleFull)**
for PR 8872 at commit
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-173931173
I tested this and can confirm it works as expected. I merged #10370 prior
to testing.
---
If your project is set up for it, you can reply to this email and have your
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r50540694
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -358,9 +358,10 @@ private[spark] class
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-173932754
There's an ongoing discussions regarding one minor point. I don't have
other comments, so LGTM.
---
If your project is set up for it, you can reply to this email and
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-172524412
@tnachen, this PR would need to be rebased on master. At any rate, if there
are fixes in cluster-mode that make it work now, they are not part of this PR
yet.
---
If
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-17198
Sorry I missed your comment. I'll give it a go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r49891184
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -358,9 +358,10 @@ private[spark] class
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-168781103
@andrewor14 @dragos I think we figured out the testing problem at this
point, I've tested this locally myself so @dragos if you like to try it out let
me know,
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-164580763
@tnachen can you provide some guidance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-163901420
I'd love to move this forward, but I need to know how you tested this (and
replicate). ping @tnachen
---
If your project is set up for it, you can reply to this email
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r47407104
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -358,9 +358,10 @@ private[spark] class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r47406920
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -358,9 +358,10 @@ private[spark] class
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-161336155
So, I like the code as it is now. I'm having trouble running Spark on Mesos
in cluster mode, as always, so I didn't manage to test it, but that's most
likely unrelated
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-160075491
@andrewor14 PTAL, it should be ready.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-156846731
**[Test build #45958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45958/consoleFull)**
for PR 8872 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-156858796
**[Test build #45958 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45958/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-156858834
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-156858833
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152947042
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152946954
**[Test build #44796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44796/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152947044
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r43587599
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -358,9 +358,10 @@ private[spark] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152918280
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152918579
**[Test build #44794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44794/consoleFull)**
for PR 8872 at commit
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152918251
@andrewor14 @dragos all comments should be addressed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152918784
**[Test build #44794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44794/consoleFull)**
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152922261
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152922265
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152922644
**[Test build #44796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44796/consoleFull)**
for PR 8872 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152151363
@tnachen can you address the comments? I would like to get this merged.
Also it's still failing style tests.
---
If your project is set up for it, you can reply to
Github user BrickXu commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-152114579
@tnachen thanks very much, I will merge this PR in our private spark repo,
and report issues ASAP if it does not work well.
Thanks again!
---
If your project is
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r42725306
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -443,9 +444,13 @@ private[spark] class
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r42724448
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/mesos/MesosClusterSchedulerSuite.scala
---
@@ -72,4 +78,56 @@ class MesosClusterSchedulerSuite
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r42724611
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -358,9 +358,10 @@ private[spark] class
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r42725607
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -457,34 +462,37 @@ private[spark] class
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r42725390
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -497,28 +505,28 @@ private[spark] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147898639
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147898616
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147899923
@dragos added unit test and fixed desc and comments now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900140
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900138
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900088
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900098
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900293
[Test build #43695 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43695/consoleFull)
for PR 8872 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900555
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900558
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-147900552
[Test build #43695 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43695/console)
for PR 8872 at commit
Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/8872#issuecomment-145809075
@tnachen this looks ok, but we need a better description. It's not clear
what exactly is the problem, so not sure how to manually test it.
Also, please add a
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r40827123
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala
---
@@ -189,7 +189,7 @@ private[mesos] trait
Github user dragos commented on a diff in the pull request:
https://github.com/apache/spark/pull/8872#discussion_r40827416
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
---
@@ -542,9 +549,7 @@ private[spark] class
1 - 100 of 109 matches
Mail list logo
