Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165866167
Many thanks @yhuai @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9981
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165853135
Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165844815
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165355697
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165355692
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165355282
**[Test build #47896 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47896/consoleFull)**
for PR 9981 at commit
[`7674658`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165333683
**[Test build #47896 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47896/consoleFull)**
for PR 9981 at commit
[`7674658`](https://gith
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165331594
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165327971
@gatorsmile thanks.. unfortunately this run also failed very early on in
the cycle :(:-
---
If your project is set up for it, you can reply to this email and have y
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165325984
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165325981
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165321334
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165316117
@yhuai Hi Yin, failure does not seem related to the change. Can we please
retest ?
---
If your project is set up for it, you can reply to this email and have your
r
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165315299
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165315250
**[Test build #47871 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47871/consoleFull)**
for PR 9981 at commit
[`7674658`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165315298
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165301815
**[Test build #47871 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47871/consoleFull)**
for PR 9981 at commit
[`7674658`](https://gith
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165299339
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165298181
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165298182
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165295575
Let's trigger a new test run since the last one was several days ago.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165295658
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-165295523
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-164896536
@yhuai Hi Yin, given we have a consistent column naming (ci) in both
selectExpr and function case, do the changes look ok to you ?
If we want to change the colum
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r47004826
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
Sh
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46981968
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
SharedSQ
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46920864
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
Sh
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46919957
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
Shar
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46918098
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
Sh
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46916540
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
Sh
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46916085
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
SharedSQ
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46916005
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
Sh
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46914788
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -73,6 +73,10 @@ class JsonFunctionsSuite extends QueryTest with
SharedSQ
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162735827
@yhuai Hi Yin, Wenchen has looked over the changes. Can you please let me
know what you think ?
---
If your project is set up for it, you can reply to this email an
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162171565
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162171566
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162171536
**[Test build #47219 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47219/consoleFull)**
for PR 9981 at commit
[`7674658`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162163215
**[Test build #47219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47219/consoleFull)**
for PR 9981 at commit
[`7674658`](https://gith
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162162999
@cloud-fan thanks a lot. addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162161817
overall LGTM, some minor comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46755983
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -176,6 +176,15 @@ class DataFrameSuite extends QueryTest with
SharedSQLC
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46755970
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -149,12 +149,12 @@ class Analyzer(
exprs.zipW
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162151401
@cloud-fan Hi Wenchen, can you please take a look and let me know what you
think ? Thanks.
---
If your project is set up for it, you can reply to this email and hav
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162143873
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162143874
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162143837
**[Test build #47215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47215/consoleFull)**
for PR 9981 at commit
[`0e6d6d9`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-162137151
**[Test build #47215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47215/consoleFull)**
for PR 9981 at commit
[`0e6d6d9`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161924084
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161923871
**[Test build #47192 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47192/consoleFull)**
for PR 9981 at commit
[`af3963c`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161924088
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46658806
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -111,8 +110,11 @@ class Column(protected[sql] val expr: Expression)
extends Log
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161907413
**[Test build #47192 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47192/consoleFull)**
for PR 9981 at commit
[`af3963c`](https://gith
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/9981#discussion_r46658297
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -111,8 +110,11 @@ class Column(protected[sql] val expr: Expression)
extends Loggi
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161905952
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161902467
@cloud-fan Hi Wenchen, changed as per your suggestion. Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161902504
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user dilipbiswal reopened a pull request:
https://github.com/apache/spark/pull/9981
[SPARK-11619][SQL] cannot use UDTF in DataFrame.selectExpr
Description of the problem from @cloud-fan
Actually this line:
https://github.com/apache/spark/blob/branch-1.5/sql/core/src
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161204110
yea, we should introduce a new case and add `UnresolvedAlias` only for
`UnresolvedFunction`
---
If your project is set up for it, you can reply to this email and have
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161203128
@cloud-fan Thank you very much. Actually the the ResolveAliases already has
the code to inject MultiAlias for resolved Generators. So we are good (thanks
!!)
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-161172585
This still looks hacky to me. How about this:
add an extra case in `Column.named` to delay the aliasing job of
`UnresolvedFunction` like
`case func: Unresolved
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-160877804
@cloud-fan Hi Wenchen, I was thinking about this and want to run an idea by
you. Is it ok if we add the logic to inject the MultiAlias in our analyzer. As
an experim
Github user dilipbiswal closed the pull request at:
https://github.com/apache/spark/pull/9981
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-160509630
@cloud-fan Sure.. I will close this PR for now. If you think of a better
approach and need my help in anyway pl let me know. Thanks for your feedback.
---
If your p
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-160507517
Thanks for working on it!
Actually I'm not sure if this is the right appraoch... We still hande
`explode` and `json_tuple` specially, what's worse, we hardcode
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-160486254
ping @cloud-fan @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159893338
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159893336
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159893213
**[Test build #46762 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46762/consoleFull)**
for PR 9981 at commit
[`9bee82b`](https://git
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159861751
yea, there are some flaky tests, we are working on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159858923
@cloud-fan Actually you had advised me to do that a while back. However it
does not seem to work...
Thanks for triggering the test. Do you have any idea about thi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159858285
**[Test build #46762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46762/consoleFull)**
for PR 9981 at commit
[`9bee82b`](https://gith
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159855325
you can also try comment "retest this please"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159829308
@cloud-fan failed again in the same way. Looks like its some intermittent
issue and its more friendly to me :-). Wenchen, is there a way i can issue a
retest request
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159823505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159823369
**[Test build #46747 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46747/consoleFull)**
for PR 9981 at commit
[`9bee82b`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159823502
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159812459
**[Test build #46747 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46747/consoleFull)**
for PR 9981 at commit
[`9bee82b`](https://gith
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159810727
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159806047
@cloud-fan can you please help trigger a retest. Looks like an unrelated
failure
---
If your project is set up for it, you can reply to this email and have your
rep
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159804528
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159804507
**[Test build #46737 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46737/consoleFull)**
for PR 9981 at commit
[`9bee82b`](https://git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159804527
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159793615
**[Test build #46737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46737/consoleFull)**
for PR 9981 at commit
[`9bee82b`](https://gith
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159768483
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/4
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159768481
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159768441
**[Test build #46719 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46719/consoleFull)**
for PR 9981 at commit
[`9620468`](https://git
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159750986
**[Test build #46719 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46719/consoleFull)**
for PR 9981 at commit
[`9620468`](https://gith
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159749020
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9981#issuecomment-159748762
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
90 matches
Mail list logo
