Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-196016688
@tnachen Keeping up with the pace of changes to Spark code was a bit too
much.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user radekg closed the pull request at:
https://github.com/apache/spark/pull/9608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-178263971
@radekg @tnachen I'd just like to point out that Spark no longer uses Akka
as its underlying RPC system, so a lot of the work done here may no longer
apply.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-169001635
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-169001637
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-169001463
**[Test build #48764 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48764/consoleFull)**
for PR 9608 at commit
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168972745
@tnachen what would be the best place to publish such documentation?
Regarding `worth nothing` comment. The whole concept behind this pr is to allow
running spark master
Github user radekg commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r48834671
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -854,7 +854,8 @@ private[spark] object Utils extends Logging {
* Get the local
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168982029
**[Test build #48764 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48764/consoleFull)**
for PR 9608 at commit
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r48770592
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -245,10 +245,19 @@ object SparkEnv extends Logging {
val securityManager =
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r48771144
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -854,7 +854,8 @@ private[spark] object Utils extends Logging {
* Get the local
Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168780854
I think it's also note documenting this of how it can possibly work with
bridge mode. Also I think it's worth noting that user must explicitly map the
ports before hand
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168351836
**[Test build #48573 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48573/consoleFull)**
for PR 9608 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168351853
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168351854
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168345176
**[Test build #48573 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48573/consoleFull)**
for PR 9608 at commit
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-168344020
I will need to verify this patch with torrent broadcast.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167826085
I have 3 tests failing locally but I don't think these are related to my
changes. `scalastyle` seems to be ok now. Failing tests:
```
- launch simple
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167826650
**[Test build #48416 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48416/consoleFull)**
for PR 9608 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167847920
**[Test build #48416 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48416/consoleFull)**
for PR 9608 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167848079
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167848076
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167755475
I will take a look at those scalastyle errors.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167645599
**[Test build #48370 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48370/consoleFull)**
for PR 9608 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167643636
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167643628
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167648846
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167648836
**[Test build #48370 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48370/consoleFull)**
for PR 9608 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-167648843
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user radekg commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r48442211
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -122,7 +122,8 @@ private[netty] class NettyRpcEnv(
@Nullable
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-164947432
@radekg also please rebase to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-164606160
@dragos @tnachen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r47593516
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -152,6 +153,17 @@ private[spark] class HttpServer(
}
}
+
Github user 3ourroom commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r47606048
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -122,7 +122,8 @@ private[netty] class NettyRpcEnv(
@Nullable
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r47605974
--- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala
---
@@ -122,7 +122,8 @@ private[netty] class NettyRpcEnv(
@Nullable
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-16205
I've added the code for 1.6. It works (tasks are successfully finishing).
However, I am not 100% sure what is the impact of this change. Would be great
if somebody
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-16247
Regarding the `TorrentBroadcast`. I think there is to be some magic done
around `blockManager.port`.
---
If your project is set up for it, you can reply to this email
Github user skonto commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-159863822
I verified the example for spark version spark 1.5.1. It seems to work
fine. It makes possible the bidirectional communication between mesos
master/notebook within a
Github user radekg commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-159867250
@skonto no, the NettyRpcEnv has not been tested yet, let me have a look
today / tomorrow. I'll post an update here.
---
If your project is set up for it, you can reply
Github user tnachen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r45654941
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -42,10 +42,11 @@ private[spark] class HttpFileServer(
fileDir.mkdir()
Github user radekg commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r45681436
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -42,10 +42,11 @@ private[spark] class HttpFileServer(
fileDir.mkdir()
Github user skonto commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-157761772
guys...i tried to verify it check
https://issues.apache.org/jira/browse/SPARK-11638 for the details.
---
If your project is set up for it, you can reply to this email
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r44526124
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -810,7 +810,7 @@ private[spark] object Utils extends Logging {
* Get the
Github user radekg commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r44562422
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -810,7 +810,7 @@ private[spark] object Utils extends Logging {
* Get the local
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r44526017
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -42,10 +42,11 @@ private[spark] class HttpFileServer(
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r44539552
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -810,7 +810,7 @@ private[spark] object Utils extends Logging {
* Get the
Github user radekg commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r44533312
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -810,7 +810,7 @@ private[spark] object Utils extends Logging {
* Get the local
Github user radekg commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r44533187
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -42,10 +42,11 @@ private[spark] class HttpFileServer(
fileDir.mkdir()
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9608#discussion_r44597535
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -810,7 +810,7 @@ private[spark] object Utils extends Logging {
* Get the
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9608#issuecomment-155590082
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user radekg opened a pull request:
https://github.com/apache/spark/pull/9608
[SPARK-11638] [Mesos + Docker Bridge networking]: Run Spark on Mesos,â¦
⦠in Docker with Bridge networking
Provides `spark.driver.advertisedPort`, `spark.fileserver.advertisedPort`,
51 matches
Mail list logo
