Github user NarineK closed the pull request at:
https://github.com/apache/spark/pull/9667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-218707819
**[Test build #58470 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58470/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-218707828
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-218707823
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-218706899
**[Test build #58470 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58470/consoleFull)**
for PR 9667 at commit
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173381317
I've pushed all the suggestions and changes.
@jkbradley I have a concern with respect to: weight: Vector and
lossHistory: Array[Double] which is originally being
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173067794
**[Test build #49743 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49743/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173068103
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173068101
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173060199
**[Test build #49743 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49743/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173044681
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173044668
**[Test build #49738 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49738/consoleFull)**
for PR 9667 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173043912
**[Test build #49738 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49738/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173044676
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r48997464
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -133,7 +133,7 @@ class GradientDescent private[spark]
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r48998009
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -122,8 +122,8 @@ class GradientDescent private[spark]
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r49015700
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -122,8 +122,8 @@ class GradientDescent private[spark]
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r49019476
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -122,8 +122,8 @@ class GradientDescent private[spark]
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r49001507
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -178,7 +178,7 @@ object GradientDescent extends Logging {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r49001704
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -122,8 +122,8 @@ class GradientDescent private[spark]
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169114349
@NarineK Apologies for the lack of response here! We've had limited review
bandwidth. I like providing this information to users. However, we have some
of it
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169152558
Yes, that's the main issue, especially since these features are already in
spark.ml.
---
If your project is set up for it, you can reply to this email and have your
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169143891
@jkbradley Thanks for explanation! With regards to this particular PR, Do I
understand correct, that you don't want to add a new feature to the
soon-to-be-deprecated
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169134436
There has been a lot of confusion about the spark.ml vs spark.mllib APIs,
so we want to achieve feature parity in spark.ml. There are no set plans to
deprecate
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169178623
Originally, I needed that information for the neuronal network. I extended
it so that the ANN can expose it too.
I think in general it would be good to have the
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169126422
@jkbradley Could you suggest why do you think that it does not worth having
the output from `mlllib` optimizers? Are planning to deprecate all optimizers
from `mllib`
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169167949
Thanks for your feedback!
@jkbradley : Which package do you exactly mean with DataFrame's spark.ml ?
I can see
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169169854
Maybe I misunderstood the need here. Do you want to use the optimizers for
your own custom algorithms? Or do you want to get info back from MLlib
algorithms like
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-169193588
I see. Adding this seems reasonable since some spark.ml algorithms depend
on these APIs. However, I want to avoid breaking the public optimization APIs
in
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r48920477
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -133,7 +133,7 @@ class GradientDescent private[spark]
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r48920506
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -178,7 +178,7 @@ object GradientDescent extends Logging {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/9667#discussion_r48920464
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -122,8 +122,8 @@ class GradientDescent private[spark]
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156389221
**[Test build #45857 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45857/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156400176
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156400180
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156410369
Hi there,
If we want to have many output variables, we'll need to add wrapper class
e.g. OptimizeResult which will embrace all those output variables.
Since
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156379692
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156382535
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156382506
**[Test build #45854 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45854/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156382540
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156380484
**[Test build #45854 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45854/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156386218
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156386314
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156400055
**[Test build #45857 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45857/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156227937
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156227909
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156211034
**[Test build #45760 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45760/consoleFull)**
for PR 9667 at commit
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156228151
It seems that there is a problem in java for many output parameters.
Introducing a Result output object would be probably better.
---
If your project is set up
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156232189
**[Test build #45769 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45769/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156232202
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156232201
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156229203
**[Test build #45769 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45769/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156211041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156211040
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156205556
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156205544
**[Test build #45758 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45758/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156205554
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156208759
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156208789
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156209143
**[Test build #45760 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45760/consoleFull)**
for PR 9667 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156170216
**[Test build #45748 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45748/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156169522
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156169555
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156172806
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156172793
**[Test build #45748 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45748/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156172808
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156153828
@mengxr , @avulanov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156155024
**[Test build #45745 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45745/consoleFull)**
for PR 9667 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156159282
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156159267
**[Test build #45745 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45745/consoleFull)**
for PR 9667 at commit
GitHub user NarineK opened a pull request:
https://github.com/apache/spark/pull/9667
[SPARK-11696] [ML, MLlib] Optimization: Extend optimizer output
Hi there,
I've added two simple parameter for the start:
1. the number of iterations
2. The loss after the last
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156154361
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156154397
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156202678
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156202654
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156202690
Here is an example from scipy:
http://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.OptimizeResult.html#scipy.optimize.OptimizeResult
---
If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-156203501
**[Test build #45758 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45758/consoleFull)**
for PR 9667 at commit
77 matches
Mail list logo