[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-158001295 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-158001301 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-158000863 **[Test build #46314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46314/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-19 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9726#discussion_r45426470 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -44,20 +44,21 @@ import

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9726#discussion_r45398570 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -736,39 +645,4 @@ trait ScalaReflection {

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9726 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9726#discussion_r45398455 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -44,20 +44,21 @@ import

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9726#discussion_r45307851 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -736,39 +645,4 @@ trait ScalaReflection {

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157972689 **[Test build #46314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46314/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157363022 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157354774 **[Test build #46070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46070/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157354977 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157354973 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157364779 **[Test build #46083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46083/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157399730 **[Test build #46083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46083/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157400218 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157400223 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-157304816 **[Test build #46070 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46070/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-16 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9726#discussion_r44998171 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -18,34 +18,22 @@ package

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-15 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/9726 [SPARK-11750][SQL] revert SPARK-11727 and code clean up After some experiment, I found it's not convenient to have separate encoder builders: `FlatEncoder` and `ProductEncoder`. For example, when

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9726#discussion_r44889803 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -718,39 +630,4 @@ trait ScalaReflection {

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9726#discussion_r44889853 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects.scala --- @@ -288,14 +287,13 @@ case class WrapOption(optionType:

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-15 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-156918831 cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-156919553 **[Test build #45980 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/45980/consoleFull)** for PR 9726 at commit

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-156945881 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11750][SQL] revert SPARK-11727 and code...

2015-11-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9726#issuecomment-156945880 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your