[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-24 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45804928 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-24 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159427506 Thanks for clarifying my question upthread. This looks good to me, so I'm going to merge to master and branch-1.6. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-24 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45775844 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159051902 **[Test build #46547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46547/consoleFull)** for PR 9793 at commit

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159090248 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159090250 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159090033 **[Test build #46547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46547/consoleFull)** for PR 9793 at commit

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45698452 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45698964 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45699105 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45693587 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45408343 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -468,6 +468,13 @@ public long spill() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-157639998 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-157639888 **[Test build #46178 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46178/consoleFull)** for PR 9793 at commit

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-157639996 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-17 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-157611751 cc @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-17 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/9793 [SPARK-11805] free the array in UnsafeExternalSorter during spilling After calling spill() on SortedIterator, the array inside InMemorySorter is not needed, it should be freed during spilling, this

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-157613131 **[Test build #46178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46178/consoleFull)** for PR 9793 at commit