Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10289
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-167114060
Merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166856069
**[Test build #2251 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2251/consoleFull)**
for PR 10289 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166878686
**[Test build #2251 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2251/consoleFull)**
for PR 10289 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166881220
I'm going to go ahead and merge this today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166644123
**[Test build #48202 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48202/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166709517
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166709431
**[Test build #48202 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48202/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166709515
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166765714
Can I retest this? Timeout may occur in pyspark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48238449
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48238546
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -43,12 +45,21 @@ import org.apache.spark.util.Utils
class
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48234885
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48234838
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -43,12 +45,21 @@ import org.apache.spark.util.Utils
class
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166388741
Yeah, this looks fine. I wonder if there's something safer that we can do
in the future. What I want is the following but I don't think scalastyle is
powerful
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166440250
Hm, I suppose we could do something in `SparkFunSuite`:
```
final def beforeAll(): Unit = {
super.beforeAll()
doBeforeAll()
}
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166441235
Yeah, though then you can't fix this for test classes that extend test
classes... not sure if that exists today but could. My gut is that it's not
worth it but yes that
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48200103
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -43,12 +45,21 @@ import org.apache.spark.util.Utils
class
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48199984
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166439578
I suppose the superclass could catch the case where beforeAll wasn't called
but afterAll was, but not the latter. I also don't know how to implement this
without
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48209450
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala ---
@@ -43,12 +45,21 @@ import org.apache.spark.util.Utils
class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r48209783
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166280174
OK, this looks good to me. It's fixing the original problem and fixing
potential problems of the same form elsewhere.
---
If your project is set up for it, you can
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166118389
**[Test build #48072 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48072/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166131447
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166131449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-166131397
**[Test build #48072 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48072/consoleFull)**
for PR 10289 at commit
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165960572
I will fix this merge issue this weekend.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165721057
**[Test build #47995 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47995/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165748813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165748810
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165748707
**[Test build #47995 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47995/consoleFull)**
for PR 10289 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165800366
@kiszk your last merge to this branch seems to have gone wrong. This has a
lot of unrelated changes now. Can you try backing out the bad commits and force
pushing? or
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165947512
**[Test build #48047 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48047/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165947641
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165947639
**[Test build #48047 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48047/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165947642
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r47920442
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/ExternalSorterSuite.scala
---
@@ -235,7 +235,7 @@ class ExternalSorterSuite extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r47917288
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/ExternalSorterSuite.scala
---
@@ -235,7 +235,7 @@ class ExternalSorterSuite extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r47917308
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLlibTestSparkContext.scala ---
@@ -38,12 +38,15 @@ trait MLlibTestSparkContext extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r47922285
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/util/MLlibTestSparkContext.scala ---
@@ -38,12 +38,15 @@ trait MLlibTestSparkContext extends
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r47920869
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165482323
@kiszk I think it's looking good, minus some style problem that's making
the build fail, and a few minor comments. I think it's pretty nice to clean up
the original bug
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r47917486
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10289#discussion_r47922105
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/BaseYarnClusterSuite.scala ---
@@ -116,7 +120,7 @@ abstract class BaseYarnClusterSuite
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165521411
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165523301
**[Test build #2224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2224/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165521415
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165566493
**[Test build #2224 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2224/consoleFull)**
for PR 10289 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165319314
**[Test build #47884 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47884/consoleFull)**
for PR 10289 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165319124
**[Test build #47884 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47884/consoleFull)**
for PR 10289 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165319317
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165319320
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165330330
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165330331
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165317600
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165328555
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165328554
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165331170
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-165331171
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user 3ourroom commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164742037
NAVER - http://www.naver.com/
3ourr...@naver.com ëê» ë³´ë´ì ë©ì¼ ì´ ë¤ìê³¼ ê°ì ì´ì
ë¡
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164740892
@holdenk yeah I think that explains the problem in `BlockManagerSuite`,
good catch. I'm not sure why the other one is a problem though; not overriding
`afterEach` is
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164779119
@srowen, OK, I will correct this pattern everywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164802842
There are two potential bugs
1. A method of the super class is not called in `beforeEach()`,
`afterEach()`, `beforeAll()`, and `afterAll()`
2. Although
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164632168
@JoshRosen neither of those suites override the afterAll , but neither of
them call the super's afterEach function (which they both override and that is
where the
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164442285
Ah, I knew I was forgetting something. I agree this should already be
handled. @kiszk are you sure it's actually not working or just thought it
looked like it didn't?
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164373129
I think that this was supposed to be handled by the `ResetSystemProperties`
mixin; do either of these suites fail to call the superclass's `afterEach()` or
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10289#issuecomment-164369953
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user kiszk opened a pull request:
https://github.com/apache/spark/pull/10289
[SPARK-12311][CORE] Restore previous value of "os.arch" property in test
suites after forcing to set specific value to "os.arch" property
Restore the original value of os.arch property after each
69 matches
Mail list logo
