Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-170757373
@gatorsmile let's close the limit push down pull requests. We will need to
design this more properly because it is expensive to push down large limits.
---
If your
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-170757756
Sure, let me close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/10454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167138258
The new fix contains two parts:
1) Since the full outer join will remove the duplicates, we are unable to
add the extra `limit` to both sides. As long as we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167077729
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167077728
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167077669
**[Test build #48298 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48298/consoleFull)**
for PR 10454 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167066005
**[Test build #48298 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48298/consoleFull)**
for PR 10454 at commit
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48376815
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,26 @@ object PushPredicateThroughJoin
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48388692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48391896
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48388339
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48388764
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48395965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48389162
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48388578
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167014215
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167014216
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48392176
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48393687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48388871
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167014161
**[Test build #48263 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48263/consoleFull)**
for PR 10454 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-167005833
**[Test build #48263 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48263/consoleFull)**
for PR 10454 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48385881
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48386444
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48386195
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48386235
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48377203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,26 @@ object PushPredicateThroughJoin
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48386499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48387575
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48387290
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/10454
[SPARK-12505] [SQL] Pushdown a Limit on top of an Outer-Join
"Rule that applies to a Limit on top of an OUTER Join. The original Limit
won't go away after applying this rule, but additional
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-166981787
**[Test build #48252 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48252/consoleFull)**
for PR 10454 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48378249
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,26 @@ object PushPredicateThroughJoin
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-166988730
Can you add an example in the description to illustrate this optimization?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-166993610
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-166993615
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10454#issuecomment-166993285
**[Test build #48252 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/48252/consoleFull)**
for PR 10454 at commit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/10454#discussion_r48400022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -858,6 +859,30 @@ object PushPredicateThroughJoin
39 matches
Mail list logo
