Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207534124
LGTM
Merging with master
Thanks all for the PR and reviews!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207310177
+1/LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207267295
LGTM too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207230076
LGTM cc @jkbradley @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207229686
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207229588
**[Test build #55324 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55324/consoleFull)**
for PR 12116 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207229684
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207225438
**[Test build #55324 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55324/consoleFull)**
for PR 12116 at commit
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58981236
--- Diff: python/pyspark/ml/regression.py ---
@@ -433,12 +440,12 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58975356
--- Diff: python/pyspark/ml/regression.py ---
@@ -425,6 +429,9 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207189042
+1 @jkbradley
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58975014
--- Diff: python/pyspark/ml/regression.py ---
@@ -454,12 +461,12 @@ def __init__(self, featuresCol="features",
labelCol="label", predictionCol="pred
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58974996
--- Diff: python/pyspark/ml/regression.py ---
@@ -454,12 +461,12 @@ def __init__(self, featuresCol="features",
labelCol="label", predictionCol="pred
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58974920
--- Diff: python/pyspark/ml/regression.py ---
@@ -433,12 +440,12 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58974903
--- Diff: python/pyspark/ml/regression.py ---
@@ -433,12 +440,12 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207120288
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207120293
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207119947
**[Test build #55253 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55253/consoleFull)**
for PR 12116 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-207114160
**[Test build #55253 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55253/consoleFull)**
for PR 12116 at commit
Github user wangmiao1981 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58909275
--- Diff: python/pyspark/ml/regression.py ---
@@ -425,6 +425,10 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58828338
--- Diff: python/pyspark/ml/regression.py ---
@@ -425,6 +425,10 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206596097
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206596100
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206596003
**[Test build #55155 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55155/consoleFull)**
for PR 12116 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206593568
**[Test build #55155 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55155/consoleFull)**
for PR 12116 at commit
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206535714
I'd recommend updating the docstring test to look at the variance column
and print its value for one row.
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206531808
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206531813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206531610
**[Test build #55142 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55142/consoleFull)**
for PR 12116 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206528368
**[Test build #55142 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55142/consoleFull)**
for PR 12116 at commit
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206527679
Jenkins add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206449257
@holdenk I am think what tests should be added. Do you have any suggestions?
Thanks!
Miao
---
If your project is set up for it, you can reply to
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206152870
@wangmiao1981 might still be good to add a simple test? But yes we should
run this in jenkins if one of the commiters can whitelist.
---
If your project is set up for
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-206145891
@jkbradley Can you add me to white list to trigger the integration test?
Thanks!
Miao
---
If your project is set up for it, you can reply to
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-205896732
@holdenk Thanks for your comments! I will make changes accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-205678416
Two minor comments, we could also probably add a simple test to the
existing decission tree tests in tests.py (nothing too complicated just make
sure the value is
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58493156
--- Diff: python/pyspark/ml/regression.py ---
@@ -433,12 +433,12 @@ class DecisionTreeRegressor(JavaEstimator,
HasFeaturesCol, HasLabelCol, HasPredi
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58492921
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -146,7 +146,9 @@ def get$Name(self):
("weightCol", "weight column name. If
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-205520304
@holdenk I made the changes and tested the gen code. Can you review it?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user wangmiao1981 commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-205513619
@holdenk Thanks for pointing it out. I will revise it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-205433663
Hi @wangmiao1981 thanks for starting this always good to see more people
working to keep the Python API up to date :) For the params that live in
`shared.py` they are
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12116#issuecomment-204578685
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user wangmiao1981 opened a pull request:
https://github.com/apache/spark/pull/12116
[SPARK-12569][PySpark][ML]:DecisionTreeRegressor: provide variance of
prediction: Python AP
## What changes were proposed in this pull request?
A new column VarianceCol has been
44 matches
Mail list logo
