Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/172
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-38870717
Thanks. I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-38860147
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13528/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-38860146
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-38854191
Merged build started. One or more automated tests failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-38854174
Merged build triggered. One or more automated tests failed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-38853784
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user petko-nikolov commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r11018500
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,46 @@ class BitSet(numBits: Int) extends Serializable {
Github user petko-nikolov commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r11018505
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,46 @@ class BitSet(numBits: Int) extends Serializable {
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-38775516
Hey @petko-nikolov
thanks for updating it. This looks pretty good to me. Just had a couple
more comments on coding style. It would be great if you can update it, and
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r11012411
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,46 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r11012402
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,46 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user petko-nikolov commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-37996618
Hey @rxin,
Thanks for the comments! I updated the PR to reflect your remarks. Would be
happy to take it a look again :)
---
If your project is set up for i
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-37970799
Hi @petko-nikolov,
Thanks a lot for contributing this patch! I left some comments to help the
code conform to Spark coding style, and on test coverage. It would be gr
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718634
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/BitSetSuite.scala ---
@@ -69,4 +69,45 @@ class BitSetSuite extends FunSuite {
assert(bitse
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718623
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/BitSetSuite.scala ---
@@ -69,4 +69,45 @@ class BitSetSuite extends FunSuite {
assert(bitse
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718582
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718568
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718473
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718405
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718417
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/172#discussion_r10718388
--- Diff: core/src/main/scala/org/apache/spark/util/collection/BitSet.scala
---
@@ -88,6 +88,53 @@ class BitSet(numBits: Int) extends Serializable {
newB
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/172#issuecomment-37949024
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
GitHub user petko-nikolov opened a pull request:
https://github.com/apache/spark/pull/172
[SPARK-1268] Adding XOR and AND-NOT operations to
spark.util.collection.BitSet
Symmetric difference (xor) in particular is useful for computing some
distance metrics (e.g. Hamming). Unit tests
24 matches
Mail list logo
