Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-178214178
Going to merge this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/10961
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51299173
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -282,6 +328,21 @@ public void reset() {
/**
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51299238
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -354,6 +435,33 @@ public void reset() {
/**
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51299048
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -126,12 +147,25 @@ public ArrayData copy() {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51299383
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java
---
@@ -59,19 +62,44 @@ public static Object
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51301088
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -354,6 +435,33 @@ public void reset() {
/**
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51305930
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -126,12 +147,25 @@ public ArrayData copy() {
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-176938191
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51232873
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -282,6 +328,21 @@ public void reset() {
/**
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51232913
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -354,6 +435,33 @@ public void reset() {
/**
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-176618365
cc @davies for a more detailed review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51232647
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -126,12 +147,25 @@ public ArrayData copy() {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51232603
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -126,12 +147,25 @@ public ArrayData copy() {
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51233211
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java
---
@@ -59,19 +62,44 @@ public static Object
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51233270
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVectorUtils.java
---
@@ -59,19 +62,44 @@ public static Object
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51167501
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -170,7 +204,14 @@ public float getFloat(int ordinal) {
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51168028
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -217,6 +269,41 @@ public final long getLong(int
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-176348260
**[Test build #50287 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50287/consoleFull)**
for PR 10961 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-176415361
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-176415357
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-176414955
**[Test build #50287 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50287/consoleFull)**
for PR 10961 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10961#issuecomment-175917592
**[Test build #50241 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/50241/consoleFull)**
for PR 10961 at commit
GitHub user nongli opened a pull request:
https://github.com/apache/spark/pull/10961
[SPARK-13043][SQL] Implement remaining catalyst types in ColumnarBatch.
This includes: float, boolean, short, decimal and calendar interval.
Decimal is mapped to long or byte array
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51088280
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -217,6 +269,41 @@ public final long getLong(int
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51088303
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -217,6 +269,41 @@ public final long getLong(int
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51088273
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java
---
@@ -217,6 +269,41 @@ public final long getLong(int
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51087484
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala ---
@@ -148,6 +148,28 @@ object DecimalType extends AbstractDataType {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10961#discussion_r51087836
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -170,7 +204,14 @@ public float getFloat(int ordinal) {
29 matches
Mail list logo
