Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215254295
LGTM. Merging this. Thanks @olarayej
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215253254
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215253259
@shivaram I've changed default value to drop=F as you suggested. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215253147
**[Test build #57187 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57187/consoleFull)**
for PR 11318 at commit
[`36163e1`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215253256
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215249525
**[Test build #57187 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57187/consoleFull)**
for PR 11318 at commit
[`36163e1`](https://gi
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215236672
Thanks @olarayej for updating this. I think the code looks good. The only
thing I'm not sure of is the default value for `[` - I see that you have gone
through SparkR'
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215181464
@shivaram @sun-rui @felixcheung This one's ready. Shall we merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215181387
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215181390
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215181259
**[Test build #57151 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57151/consoleFull)**
for PR 11318 at commit
[`290a2cf`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215175593
**[Test build #57151 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57151/consoleFull)**
for PR 11318 at commit
[`290a2cf`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215172309
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215172314
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215172303
**[Test build #57150 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57150/consoleFull)**
for PR 11318 at commit
[`fc07e85`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215171548
**[Test build #57150 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57150/consoleFull)**
for PR 11318 at commit
[`fc07e85`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215168434
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215168402
**[Test build #57146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57146/consoleFull)**
for PR 11318 at commit
[`def5987`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215168432
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-215162422
**[Test build #57146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57146/consoleFull)**
for PR 11318 at commit
[`def5987`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214930907
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214930902
**[Test build #57063 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57063/consoleFull)**
for PR 11318 at commit
[`b169e14`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214930910
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214930486
**[Test build #57063 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57063/consoleFull)**
for PR 11318 at commit
[`b169e14`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214927529
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214927527
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214927523
**[Test build #57060 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57060/consoleFull)**
for PR 11318 at commit
[`1a4ca8b`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-214927177
**[Test build #57060 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57060/consoleFull)**
for PR 11318 at commit
[`1a4ca8b`](https://gi
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-203678123
@sun-rui @shivaram Shall we merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199464512
@sun-rui Done with the style issues. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199464033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199464026
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199463713
**[Test build #53696 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53696/consoleFull)**
for PR 11318 at commit
[`9ab303a`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199412481
**[Test build #53696 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53696/consoleFull)**
for PR 11318 at commit
[`9ab303a`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199409485
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199409488
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199409473
**[Test build #53693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53693/consoleFull)**
for PR 11318 at commit
[`13dfcbb`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199408688
**[Test build #53693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53693/consoleFull)**
for PR 11318 at commit
[`13dfcbb`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199405391
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199405395
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199405382
**[Test build #53691 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53691/consoleFull)**
for PR 11318 at commit
[`b576fba`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199404366
**[Test build #53691 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53691/consoleFull)**
for PR 11318 at commit
[`b576fba`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199403491
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199403494
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199403484
**[Test build #53689 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53689/consoleFull)**
for PR 11318 at commit
[`0473d03`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-199402918
**[Test build #53689 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53689/consoleFull)**
for PR 11318 at commit
[`0473d03`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197619524
**[Test build #53357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53357/consoleFull)**
for PR 11318 at commit
[`6ebe948`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197619725
Build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197607687
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197624198
@olarayej, there are still similar coding style issues:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user olarayej commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r56418618
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197619726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197579448
**[Test build #53360 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53360/consoleFull)**
for PR 11318 at commit
[`017fcdb`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197579586
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197607692
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197566393
@felixcheung @shivaram @sun-rui I have addressed all your comments. Do we
have a consensus on the default value for drop? I'd say drop=T makes sense cuz
R does it that
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197556372
**[Test build #53357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53357/consoleFull)**
for PR 11318 at commit
[`6ebe948`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197607512
**[Test build #53359 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53359/consoleFull)**
for PR 11318 at commit
[`adc977f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197566084
**[Test build #53360 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53360/consoleFull)**
for PR 11318 at commit
[`017fcdb`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197559021
**[Test build #53359 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53359/consoleFull)**
for PR 11318 at commit
[`adc977f`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-197579582
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55832602
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55831536
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1271,12 +1280,8 @@ setMethod("[", signature(x = "DataFrame", i =
"Column"),
#' subset(df, select = c(1,2))
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55830076
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-195316072
https://stat.ethz.ch/R-manual/R-devel/library/base/html/Extract.data.frame.html
here for reference
---
If your project is set up for it, you can reply to this email a
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-195211016
Hmm, just as #11336 wouldn't it be confusing then to return a Column,
particularly since Column in SparkR is pretty restricted, unlike in R?
---
If your project is
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55792469
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname sub
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r5528
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/11318#discussion_r55777422
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1217,29 +1217,38 @@ setMethod("[[", signature(x = "DataFrame", i =
"numericOrcharacter"),
#' @rdname subset
Github user olarayej commented on the pull request:
https://github.com/apache/spark/pull/11318#issuecomment-194128322
@felixcheung @sun-rui @shivaram Can you folks please take a look at this
one? Thank you!
---
If your project is set up for it, you can reply to this email and have yo
71 matches
Mail list logo
