Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11534
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195091525
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195074808
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195074477
**[Test build #52850 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52850/consoleFull)**
for PR 11534 at commit
[`2752655`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195074806
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195050842
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195050846
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195050637
**[Test build #52845 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52845/consoleFull)**
for PR 11534 at commit
[`2e8b531`](https://g
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55741963
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -407,11 +399,49 @@ private[spark] class BlockManager(
}
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195024308
**[Test build #52850 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52850/consoleFull)**
for PR 11534 at commit
[`2752655`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55739221
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -407,11 +399,49 @@ private[spark] class BlockManager(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55735901
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -407,11 +399,49 @@ private[spark] class BlockManager(
}
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195010289
LGTM, can't wait to merge this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55735303
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,138 +805,113 @@ private[spark] class BlockManager(
//
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55735070
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -739,46 +696,105 @@ private[spark] class BlockManager(
blockId
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-195006923
**[Test build #52845 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52845/consoleFull)**
for PR 11534 at commit
[`2e8b531`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55733263
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -422,108 +462,52 @@ private[spark] class BlockManager(
Option(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194667138
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194667136
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-19444
**[Test build #52787 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52787/consoleFull)**
for PR 11534 at commit
[`e3a4c22`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194647478
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194647472
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194646709
**[Test build #52797 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52797/consoleFull)**
for PR 11534 at commit
[`08bc93b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194644310
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194644312
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194644148
**[Test build #52791 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52791/consoleFull)**
for PR 11534 at commit
[`0147471`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194642413
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194642411
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194642013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194642023
**[Test build #52794 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52794/consoleFull)**
for PR 11534 at commit
[`e2ee2e2`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194642010
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194641750
**[Test build #52792 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52792/consoleFull)**
for PR 11534 at commit
[`84e4d76`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194618554
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194618552
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194618341
**[Test build #52777 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52777/consoleFull)**
for PR 11534 at commit
[`94d2bd6`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194601341
**[Test build #52797 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52797/consoleFull)**
for PR 11534 at commit
[`08bc93b`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55620372
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194600693
@andrewor14, let me take another shot at reducing that duplication and I'll
get back to you.
---
If your project is set up for it, you can reply to this email and ha
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55620146
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194600377
**[Test build #52794 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52794/consoleFull)**
for PR 11534 at commit
[`e2ee2e2`](https://gi
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194600143
@JoshRosen This looks great. The only concern I have is the duplicate code
in `doPutIterator` and `doPutBytes`. In the future if we find a bug in one of
them and for
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619604
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -701,16 +666,15 @@ private[spark] class BlockManager(
blockId:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194598943
**[Test build #52792 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52792/consoleFull)**
for PR 11534 at commit
[`84e4d76`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619576
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619575
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -701,16 +666,15 @@ private[spark] class BlockManager(
blockId:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619390
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +742,193 @@ private[spark] class BlockManager(
//
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619301
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -318,19 +291,26 @@ private[spark] class MemoryStore(blockManager:
B
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619205
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -114,89 +106,70 @@ private[spark] class MemoryStore(blockManager:
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619226
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +742,193 @@ private[spark] class BlockManager(
//
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619176
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -318,19 +291,26 @@ private[spark] class MemoryStore(blockManager:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194596386
**[Test build #52791 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52791/consoleFull)**
for PR 11534 at commit
[`0147471`](https://gi
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55618676
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -26,18 +26,14 @@ import org.apache.spark.util.{ShutdownHookManager,
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55618661
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -916,11 +945,9 @@ private[spark] class BlockManager(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55618498
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +742,193 @@ private[spark] class BlockManager(
//
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194593904
**[Test build #52787 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52787/consoleFull)**
for PR 11534 at commit
[`e3a4c22`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55618229
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +742,193 @@ private[spark] class BlockManager(
//
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55618054
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +742,193 @@ private[spark] class BlockManager(
//
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55617710
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -548,16 +521,9 @@ private[spark] class BlockManager(
* This does n
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55617427
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +742,193 @@ private[spark] class BlockManager(
//
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55617424
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55617134
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -916,11 +945,9 @@ private[spark] class BlockManager(
}
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55617159
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55616812
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -701,16 +666,15 @@ private[spark] class BlockManager(
blockId:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55616774
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -701,16 +666,15 @@ private[spark] class BlockManager(
blockId:
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55616553
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +742,193 @@ private[spark] class BlockManager(
//
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55616267
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55615777
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -548,16 +521,9 @@ private[spark] class BlockManager(
* This does
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55615659
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55615052
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55614897
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -407,11 +399,49 @@ private[spark] class BlockManager(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55613252
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -407,11 +399,49 @@ private[spark] class BlockManager(
}
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55612253
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55611895
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -428,77 +458,46 @@ private[spark] class BlockManager(
Option(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194570815
**[Test build #52777 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52777/consoleFull)**
for PR 11534 at commit
[`94d2bd6`](https://gi
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55610963
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -407,11 +399,49 @@ private[spark] class BlockManager(
}
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55610821
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -407,11 +399,49 @@ private[spark] class BlockManager(
}
Github user nongli commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194558289
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55476210
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +752,193 @@ private[spark] class BlockManager(
//
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55476161
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +752,193 @@ private[spark] class BlockManager(
//
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55473498
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +752,193 @@ private[spark] class BlockManager(
// loc
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55473363
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -789,117 +752,193 @@ private[spark] class BlockManager(
// loc
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55472870
--- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala ---
@@ -17,112 +17,100 @@
package org.apache.spark.storage
-import
Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55471546
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -34,13 +35,15 @@ private case class MemoryEntry(value: Any, size: Long,
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194092278
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194092280
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194092098
**[Test build #52707 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/52707/consoleFull)**
for PR 11534 at commit
[`66796b5`](https://g
86 matches
Mail list logo
