Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220404935
Thanks. Merged into master and 2.0 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220279912
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220279910
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220279764
**[Test build #58858 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58858/consoleFull)**
for PR 13191 at commit
[`efe88cc`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220270951
**[Test build #58858 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58858/consoleFull)**
for PR 13191 at commit
[`efe88cc`](https://gi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220270668
Jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have th
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-22024
Test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220244417
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/13191#issuecomment-220244160
cc @dbtsai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
GitHub user pravingadakh opened a pull request:
https://github.com/apache/spark/pull/13191
[SPARK-14613][ML] Add @Since into the matrix and vector classes in
spark-mllib-local
## What changes were proposed in this pull request?
This PR add `@Since` annotations in `Vectors.s
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-218703280
See https://github.com/apache/spark/pull/13074 for the module change. I'm
also moving other common annotations
---
If your project is set up for it, you can reply to th
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-218674561
@srowen Yes, please go ahead. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-218417159
@pravingadakh if you're busy, I may resubmit this change on your behalf to
try to get it in for 2.0
---
If your project is set up for it, you can reply to this email an
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-217447705
@pravingadakh go ahead - would be good to get this in for 2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-216322117
Aah ok, got it thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-216321325
Meaning, let's leave aside the actual original change in the PR, which is
to annotate some methods as `@Since` a release. Let's make the structural
change to move the an
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-216320984
> OK, let's try this PR again but only with the tag changes first.
@srowen I'm little confused here, could you please elaborate a bit here?
What tag change
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215972386
OK, let's try this PR again but only with the tag changes first. (You're
even welcome to make a separate JIRA that blocks this one, since that much is a
fairly separable
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215839125
@dbtsai @srowen My mistake, apparently changes in `modules.py` does not
cause build failure. And I was unable to reproduce the locally (even after
rebasing with la
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61619894
--- Diff: common/network-common/pom.xml ---
@@ -66,7 +66,7 @@
org.apache.spark
- spark-test-tags_${scala.binary.version
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215829721
@pravingadakh The changes in `modules.py` is just helping Jenkins to
understand the dependencies, and I don't get it why this will break the build.
Is there any
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215822661
@srowen I undid the changes done in `dev/sparktestsupport/modules.py`, ran
the sbt test build locally with `build/sbt -Pyarn -Phadoop-2.3 -Phive
-Pkinesis-asl -Ph
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215816102
> Seems we are moving ExtendedYarnTest to src/test, but we are not making
others depend on the test jar?
Haven't looked in detail (and missed this in my not-so-
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215756534
Yeah these are separable. Really, adding the annotation requires the build
change, and the latter grew to dominate the change.
Hm, I had suggested using `tests`
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215746254
In sql/hive's pom, we have
```
org.apache.spark
spark-sql_${scala.binary.version}
test-jar
${project.version}
te
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215745750
Seems we are moving ExtendedYarnTest to src/test, but we are not making
others depend on the test jar? Also, can we separate the build change with
adding Since tag to tho
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215683478
Hm, is the issue that the SBT build won't see these classes now that
they're test-scope? they are properly test scope though. If really necessary we
could, I suppose, br
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215615904
I have reverted this commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215615493
Sorry. I am going to revert it. I believe it breaks the build. Seems those
build changes are not related to adding Since tag.
---
If your project is set up for it, you c
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215615096
Looks like this one breaks the pr builder?
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57289/testReport/org.apache.spark.network/ChunkFetchIntegrati
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215587478
Thanks. Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215587557
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215587555
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215587391
**[Test build #57276 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57276/consoleFull)**
for PR 12416 at commit
[`8b57dc0`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215583165
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215583167
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215582963
**[Test build #57273 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57273/consoleFull)**
for PR 12416 at commit
[`f81616e`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215554998
**[Test build #57276 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57276/consoleFull)**
for PR 12416 at commit
[`8b57dc0`](https://gi
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215553142
LGTM except one minor styling issue. Once that is updated, and tests pass,
I'll go ahead and merge it. Thank you very much.
---
If your project is set up for it, you ca
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61496950
--- Diff: project/SparkBuild.scala ---
@@ -50,10 +50,11 @@ object BuildCommons {
).map(ProjectRef(buildLocation, _))
val allProjects@Seq(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215547993
**[Test build #57273 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57273/consoleFull)**
for PR 12416 at commit
[`f81616e`](https://gi
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215545617
@pravingadakh Yes. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215543380
@dbtsai Is this something you had in mind? Zip file contains the patch for
modules.
[tags.patch.zip](https://github.com/apache/spark/files/241333/tags.patch.zi
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215531609
@pravingadakh I think you need to update `dev/sparktestsupport/modules.py`.
See
https://github.com/apache/spark/commit/efaf7d18205f5ae3a1c767942ee7d7320f7410de
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215515903
@srowen Reverted back the python module changes. Rebasing Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215515057
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215515060
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215514782
**[Test build #57259 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57259/consoleFull)**
for PR 12416 at commit
[`cc220fc`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215476234
**[Test build #57259 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57259/consoleFull)**
for PR 12416 at commit
[`cc220fc`](https://gi
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-215459923
We are close on this, thank you @pravingadakh . I think we need a rebase,
and to undo the Python changes to "test_tags" since it actually wasn't the same
"test tags" bei
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214870752
Beside the comment from other people, I think you need to update the module
dependencies in `sparktestsupport/modules.py` such that when tag is changed,
all the modules
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61141159
--- Diff: dev/run-tests.py ---
@@ -128,7 +128,7 @@ def determine_tags_to_exclude(changed_modules):
tags = []
for m in modules.all_modules:
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61141217
--- Diff: dev/run-tests.py ---
@@ -128,7 +128,7 @@ def determine_tags_to_exclude(changed_modules):
tags = []
for m in modules.all_modules:
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61140431
--- Diff: dev/run-tests.py ---
@@ -128,7 +128,7 @@ def determine_tags_to_exclude(changed_modules):
tags = []
for m in modules.all_modules:
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61139825
--- Diff: dev/run-tests.py ---
@@ -128,7 +128,7 @@ def determine_tags_to_exclude(changed_modules):
tags = []
for m in modules.all_modules:
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214720347
@dbtsai Comments addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214716823
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214716820
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214716607
**[Test build #56992 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56992/consoleFull)**
for PR 12416 at commit
[`9321df5`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214684661
**[Test build #56992 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56992/consoleFull)**
for PR 12416 at commit
[`9321df5`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214682468
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214682469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214682463
**[Test build #56991 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56991/consoleFull)**
for PR 12416 at commit
[`f7a608f`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214682326
**[Test build #56991 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56991/consoleFull)**
for PR 12416 at commit
[`f7a608f`](https://gi
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61006720
--- Diff: project/SparkBuild.scala ---
@@ -53,7 +53,7 @@ object BuildCommons {
core, graphx, mllib, mllibLocal, repl, networkCommon, networkShuffle,
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214560261
@pravingadakh I think you need to update `dev/sparktestsupport/modules.py`
for Jenkins build as well. Thanks.
---
If your project is set up for it, you can reply to thi
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61004682
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Vectors.scala ---
@@ -561,10 +589,11 @@ object DenseVector {
* @param indices index arra
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61004014
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -415,13 +443,14 @@ object DenseMatrix {
* Comp
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r61003884
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -154,11 +172,12 @@ sealed trait Matrix extends Serializable {
* @p
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214548556
@vanzin I guess using java doc `/* @since /*` style, it's harder to
document the public variables in the constructor. Just my 0.02 cents.
---
If your project is set u
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214451544
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214451547
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214451279
**[Test build #56898 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56898/consoleFull)**
for PR 12416 at commit
[`9b36881`](https://g
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214450081
I was going to ask why do we need an annotation for this (instead of
javadoc's `@since`), but since that's already used in other places in the code,
it's kind of a moot
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214386803
**[Test build #56898 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56898/consoleFull)**
for PR 12416 at commit
[`9b36881`](https://gi
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214386251
@srowen Done rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-214266854
@pravingadakh sorry this needs a rebase now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60827833
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -154,11 +172,12 @@ sealed trait Matrix extends Serializable {
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213725055
This looks correct to my eyes. The Since annotation is in place as a
non-test class; the existing test classes are moved into the test source root.
The parent pom now de
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60827197
--- Diff:
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
@@ -154,11 +172,12 @@ sealed trait Matrix extends Serializable {
* @p
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213723361
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213723359
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213723024
**[Test build #56796 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56796/consoleFull)**
for PR 12416 at commit
[`1da5e91`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213700495
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213700473
**[Test build #56795 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56795/consoleFull)**
for PR 12416 at commit
[`714afac`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213700491
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213698709
**[Test build #56796 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56796/consoleFull)**
for PR 12416 at commit
[`1da5e91`](https://gi
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213696139
**[Test build #56795 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56795/consoleFull)**
for PR 12416 at commit
[`714afac`](https://gi
Github user pravingadakh commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213668195
@dbtsai I'll update the PR soon, I have been overwhelmed by office work :(
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-213476037
Ping @pravingadakh for update. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-212542315
Build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-212542242
**[Test build #56378 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56378/consoleFull)**
for PR 12416 at commit
[`05b755b`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12416#issuecomment-212542318
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60448721
--- Diff: common/tags/pom.xml ---
@@ -46,5 +46,24 @@
target/scala-${scala.binary.version}/classes
target/scala-${scala.binary.versi
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60448406
--- Diff: common/tags/pom.xml ---
@@ -46,5 +46,24 @@
target/scala-${scala.binary.version}/classes
target/scala-${scala.binary
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60447168
--- Diff: common/tags/pom.xml ---
@@ -46,5 +46,24 @@
target/scala-${scala.binary.version}/classes
target/scala-${scala.binary.versi
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60447033
--- Diff: pom.xml ---
@@ -270,9 +270,8 @@
org.apache.spark
-spark-test-tags_${scala.binary.version}
+
Github user pravingadakh commented on a diff in the pull request:
https://github.com/apache/spark/pull/12416#discussion_r60446515
--- Diff: common/tags/pom.xml ---
@@ -46,5 +46,24 @@
target/scala-${scala.binary.version}/classes
target/scala-${scala.binary
1 - 100 of 129 matches
Mail list logo
