Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61944570
[Test build #22993 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22993/consoleFull)
for PR 3073 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61944583
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-62017270
Core changes LGTM -- @andrewor14 would you mind completing the review on
the ui/listener-related parts?
---
If your project is set up for it, you can reply to this
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-62029538
Yeah I'll look at this shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19970793
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala ---
@@ -32,10 +32,30 @@ private[spark] class FetchFailedException(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19971126
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/FetchFailedException.scala ---
@@ -32,10 +32,30 @@ private[spark] class FetchFailedException(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19971370
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1598,10 +1598,21 @@ private[spark] object Utils extends Logging {
/**
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19971588
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1598,10 +1598,21 @@ private[spark] object Utils extends Logging {
/**
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19971716
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1598,10 +1598,21 @@ private[spark] object Utils extends Logging {
/**
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19974754
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1598,10 +1598,21 @@ private[spark] object Utils extends Logging {
/**
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19974868
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -89,9 +89,22 @@ case class ExceptionFailure(
className: String,
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19975040
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -195,7 +197,29 @@ private[ui] class FailedStageTable(
override
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19975082
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ---
@@ -195,7 +197,29 @@ private[ui] class FailedStageTable(
override
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-62051677
Left a few minor comments. Json changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-62088838
[Test build #23034 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23034/consoleFull)
for PR 3073 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19993020
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1598,10 +1598,21 @@ private[spark] object Utils extends Logging {
/**
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19993694
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -83,15 +83,48 @@ case class FetchFailed(
* :: DeveloperApi ::
* Task
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-62093800
[Test build #23034 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23034/consoleFull)
for PR 3073 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-62093802
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19994775
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -83,15 +83,48 @@ case class FetchFailed(
* :: DeveloperApi ::
* Task
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-62099815
Alright I'm merging this into master and 1.2, thanks @zsxwing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3073
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61791757
[Test build #22933 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22933/consoleFull)
for PR 3073 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61800381
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61800371
[Test build #22933 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22933/consoleFull)
for PR 3073 at commit
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19915085
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19915282
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19915771
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19916464
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19920257
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61915529
[Test build #22974 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22974/consoleFull)
for PR 3073 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19921717
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19923183
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61921496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61921492
[Test build #22974 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22974/consoleFull)
for PR 3073 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61925256
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19927620
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,32 @@ case class FetchFailed(
case class ExceptionFailure(
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61930719
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61931144
[Test build #22990 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22990/consoleFull)
for PR 3073 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61935171
[Test build #22990 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22990/consoleFull)
for PR 3073 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61935173
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61936727
Jenkins, retest this please.
`org.apache.spark.streaming.flume.FlumeStreamSuite.flume input stream` is fine
in my machine.
---
If your project is set up for it, you
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19789688
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61613785
New screenshots after increasing the max height:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61614142
[Test build #22871 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22871/consoleFull)
for PR 3073 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61623936
[Test build #22871 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22871/consoleFull)
for PR 3073 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61623944
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19831278
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19850783
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19852021
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19852208
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19852247
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -636,9 +635,14 @@ private[spark] object JsonProtocol {
case
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19852749
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19852777
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19853387
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19857645
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/3073
[SPARK-4204][Core][WebUI] Change Utils.exceptionString to contain the inner
exceptions and make the error information in Web UI more friendly
This PR fixed `Utils.exceptionString` to output the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61472813
[Test build #22812 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22812/consoleFull)
for PR 3073 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61482240
[Test build #22812 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22812/consoleFull)
for PR 3073 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61482250
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19787843
--- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala ---
@@ -88,10 +88,11 @@ case class FetchFailed(
case class ExceptionFailure(
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19787979
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1598,10 +1598,19 @@ private[spark] object Utils extends Logging {
/**
Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3073#discussion_r19788012
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1598,10 +1598,19 @@ private[spark] object Utils extends Logging {
/**
Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/3073#issuecomment-61601779
The core changes look good to me, save for the one comment on
compatibility. I would rather not review the UI and JsonProtocol changes in
detail, though, as I am not so
64 matches
Mail list logo
