Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7266
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-130005875
LGTM, merging with master.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128479758
[Test build #40068 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40068/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128456457
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128460224
[Test build #40059 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40059/consoleFull)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128469546
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128469341
[Test build #258 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/258/consoleFull)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128469523
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128445637
Those 2 small items are the only issues I see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128461415
[Test build #40059 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40059/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128461426
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128479885
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128470190
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128469891
[Test build #40068 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40068/consoleFull)
for PR 7266 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128470184
[Test build #258 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/258/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128469031
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128468978
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128457394
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128459118
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128459098
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r36439156
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/SharedParamsCodeGen.scala
---
@@ -53,6 +53,8 @@ private[shared] object SharedParamsCodeGen
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r36439160
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -49,6 +50,37 @@ class StringIndexerSuite extends SparkFunSuite
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128456967
[Test build #40054 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40054/consoleFull)
for PR 7266 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128457391
[Test build #40054 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40054/console)
for PR 7266 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128467964
Catalyst failure seems likely unrelated, jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128456487
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128202432
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128202112
[Test build #39957 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39957/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128194435
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128194461
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128194882
[Test build #39952 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39952/consoleFull)
for PR 7266 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128195201
[Test build #39952 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39952/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128195211
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128196610
[Test build #39957 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39957/consoleFull)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128196525
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-128196578
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r36038366
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -49,6 +50,37 @@ class StringIndexerSuite extends SparkFunSuite
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126966262
I was taking another look at it, and I like the setup. But one thing I had
not thought of was a third option: creating a new label/index which all unseen
values are
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126883960
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126884206
[Test build #186 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/186/consoleFull)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126884002
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126883871
jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126884751
@jkbradley if you have a chance to look at this PR too its in the same
class/file as the last one.
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126884538
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126884565
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126885271
[Test build #39348 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39348/consoleFull)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-12671
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-12652
[Test build #186 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/186/console)
for PR 7266 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126888932
[Test build #39348 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/39348/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-126888955
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-122115515
[Test build #37544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37544/consoleFull)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-122114222
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-122114203
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-122123401
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-122123331
[Test build #37544 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37544/console)
for PR 7266 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-121006573
cc @jkbradley for review since created the jira.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-120141170
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34302818
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -65,12 +66,15 @@ class StringIndexer(override val uid: String)
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34303073
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -32,7 +32,8 @@ import org.apache.spark.util.collection.OpenHashMap
Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-120142587
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-120141080
[Test build #36964 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36964/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-120134316
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-120134290
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34298625
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -65,12 +66,15 @@ class StringIndexer(override val uid: String) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-120134564
[Test build #36964 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36964/consoleFull)
for PR 7266 at commit
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34204209
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/param/shared/sharedParams.scala ---
@@ -234,6 +234,21 @@ private[ml] trait HasFitIntercept extends
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34204516
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -32,7 +32,8 @@ import org.apache.spark.util.collection.OpenHashMap
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34204885
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -32,7 +32,8 @@ import org.apache.spark.util.collection.OpenHashMap
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34204476
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -49,6 +50,38 @@ class StringIndexerSuite extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119746833
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34204982
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -65,12 +66,15 @@ class StringIndexer(override val uid: String)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119746811
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119747141
[Test build #36848 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36848/consoleFull)
for PR 7266 at commit
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34205128
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -65,12 +66,15 @@ class StringIndexer(override val uid: String) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119753543
[Test build #36848 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36848/console)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119753618
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34209405
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -65,12 +66,15 @@ class StringIndexer(override val uid: String)
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34209522
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -32,7 +32,8 @@ import org.apache.spark.util.collection.OpenHashMap
Github user feynmanliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/7266#discussion_r34206345
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -127,14 +135,27 @@ class StringIndexerModel private[ml] (
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/7266
[SPARK-8764][ML] string indexer should take option to handle unseen values
As a precursor to adding a public constructor add an option to handle
unseen values by skipping rather than throwing an
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119350835
[Test build #36715 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36715/console)
for PR 7266 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119337334
[Test build #36715 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/36715/consoleFull)
for PR 7266 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119335714
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119335682
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7266#issuecomment-119350932
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
85 matches
Mail list logo
