Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031787
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031800
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031805
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/r/MLUtils.scala
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031781
--- Diff: R/pkg/inst/tests/test_mllib.R ---
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031795
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031811
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/r/MLUtils.scala
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031804
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031777
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031775
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-122993245
[Test build #37854 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37854/consoleFull)
for PR 7483 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123005829
[Test build #37854 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37854/console)
for PR 7483 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123006031
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031784
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/r/MLUtils.scala
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35031793
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,53 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-122992903
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-122992984
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35062705
--- Diff: R/pkg/inst/tests/test_mllib.R ---
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123124299
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123124286
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123124337
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123124539
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123131223
So I checked this and its works pretty well i.e. capturing `glm` only if
`DataFrame` is passed to it. However right now the help function doesn't work
as it doesn't
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35064841
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user ericl commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123131497
@shivaram done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123131980
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123131963
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35059644
--- Diff: R/pkg/NAMESPACE ---
@@ -10,6 +10,10 @@ export(sparkR.init)
export(sparkR.stop)
export(print.jobj)
+# MLlib integration
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35061506
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35061570
--- Diff: R/pkg/inst/tests/test_mllib.R ---
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123118044
Overall it looks good. I'm still a bit concerned about overriding the `glm`
function in base `R`. Let me try a few options to see if there is a way to
onlycapture it
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35061955
--- Diff: R/pkg/NAMESPACE ---
@@ -10,6 +10,10 @@ export(sparkR.init)
export(sparkR.stop)
export(print.jobj)
+# MLlib integration
Github user ericl commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123120127
@shivaram I think it already only captures if data = DataFrame.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35062025
--- Diff: R/pkg/inst/tests/test_mllib.R ---
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35062035
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35061986
--- Diff: R/pkg/inst/tests/test_mllib.R ---
@@ -0,0 +1,34 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123121044
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123121068
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123121250
@ericl if that is the case its great - let me test this locally to just to
make sure.
---
If your project is set up for it, you can reply to this email and have your
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123104751
LGTM. Other features could be addressed in follow-up PRs, e.g., model class
in R that provides model coefficients. Ping @shivaram @davies for another pass.
---
If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35059512
--- Diff: R/pkg/NAMESPACE ---
@@ -10,6 +10,10 @@ export(sparkR.init)
export(sparkR.stop)
export(print.jobj)
+# MLlib integration
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123108332
Just one comment about `export`, otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123132380
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123132372
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35065099
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123132527
[Test build #37897 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37897/consoleFull)
for PR 7483 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123133284
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/7483#discussion_r35065716
--- Diff: R/pkg/R/mllib.R ---
@@ -0,0 +1,65 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123134196
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123134204
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123134949
[Test build #37900 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37900/consoleFull)
for PR 7483 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123138721
[Test build #37897 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37897/console)
for PR 7483 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123138878
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123141471
[Test build #37900 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37900/console)
for PR 7483 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123141514
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123142067
Thanks @ericl -- LGTM. Merging this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/7483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/7483#issuecomment-123145080
@ericl One minor thing -- It looks like your github account doesn't have
the email address you are using in your commit messages, so the merge script
can't figure out
57 matches
Mail list logo
