Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217608216
Thank you very much !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217602652
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12893
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217488982
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217488980
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217488726
**[Test build #57998 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57998/consoleFull)**
for PR 12893 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217463479
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217465397
**[Test build #57998 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57998/consoleFull)**
for PR 12893 at commit
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217443570
test please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217330185
LGTM, pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217329536
@cloud-fan : I have change the codes, can you review it again? Thanks very
much.
---
If your project is set up for it, you can reply to this email and have your
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62280265
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -883,7 +895,7 @@ class Column(protected[sql] val expr: Expression)
extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62279165
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -883,7 +895,7 @@ class Column(protected[sql] val expr: Expression)
extends
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217286258
Hello Wenchen: I have gone through all the alias method in Column, delegate
to the the "name" method. Can you help check?
BTW, I am just curious why we
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62203218
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,18 @@ class TypedColumn[-T, U](
}
new TypedColumn[T,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62158438
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,18 @@ class TypedColumn[-T, U](
}
new TypedColumn[T,
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-217083169
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62151072
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,25 @@ class TypedColumn[-T, U](
}
new TypedColumn[T,
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62150990
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,25 @@ class TypedColumn[-T, U](
}
new TypedColumn[T,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62140732
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,25 @@ class TypedColumn[-T, U](
}
new TypedColumn[T,
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62140703
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,25 @@ class TypedColumn[-T, U](
}
new TypedColumn[T,
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12893#discussion_r62136859
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -68,6 +68,25 @@ class TypedColumn[-T, U](
}
new TypedColumn[T,
Github user kevinyu98 commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-216911919
@cloud-fan can you help take a look at this pr? Thanks very much !
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user kevinyu98 opened a pull request:
https://github.com/apache/spark/pull/12893
[Spark-15051] [SQL] Create a TypedColumn alias
## What changes were proposed in this pull request?
Currently when we try to create an alias against an aggregator TypedColumn,
it is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12893#issuecomment-216794943
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
25 matches
Mail list logo
