Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88430604
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88466712
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88471774
Jenkins, retest this please. (Timeout again.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88435493
[Test build #29538 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29538/consoleFull)
for PR 5119 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88473571
[Test build #29544 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29544/consoleFull)
for PR 5119 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88519712
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88519685
[Test build #29544 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29544/consoleFull)
for PR 5119 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88066908
I'm ready to merge this but still haven't heard anything on the `archive`
element. Unless there's a need for it, it should be removed.
---
If your project is set up for
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r27537871
--- Diff: pom.xml ---
@@ -1472,6 +1473,25 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88300495
The overall approach LGTM, but I would suggest adding a better comment
since it's non-obvious what is going on.
---
If your project is set up for it, you can reply to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88143800
[Test build #29488 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29488/consoleFull)
for PR 5119 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88210535
Jenkins, retest this please. (Timeout, but doesn't look like any stuck
test; it was almost done with Python tests when it stopped.)
---
If your project is set up for it,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88211619
[Test build #29498 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29498/consoleFull)
for PR 5119 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88194205
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88253403
[Test build #29498 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29498/consoleFull)
for PR 5119 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88253426
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-88254495
I like this. Let me give @pwendell a day or so to comment since it touches
the build but I think this is a good change.
---
If your project is set up for it, you can
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87403955
It leaves out the `log4j.properties` of every test JAR, to stop it
contaminating downstream tests. you don't want to be trying to debug exactly
which log4j file is
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87436152
To clarify something: do you expect there to be a {{log4j.properties}} file
in the slider assembly JAR? because there isn't one, not in trunk@ 0e2753ff :
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87470545
Yes that all looks correct with regard to `log4j.properties`. The remaining
issue I think is the `archive` stanza, which I think does not need to be
added.
---
If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r27344740
--- Diff: pom.xml ---
@@ -1472,6 +1473,38 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87188264
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87188249
[Test build #29341 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29341/consoleFull)
for PR 5119 at commit
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-86937523
I did a clean build and it didn't work, at least not with the command.
{code}
mvn clean install -DskipTests -Pyarn -Phadoop-2.4 -Dhadoop.version=2.6.0
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-86947139
Hm, could be a Maven version thing; I'm on 3.2. Are you looking at `target`
or what is actually installed in `.m2`? I was looking at `target`. Heh, yeah
maybe see what
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87034493
I commented it out again and did work, so I am now concluding I trust maven
even less than before. Pushed a new commit with the JAR execution omitted.
---
If your
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87167803
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87167964
Looking good except I still don't think the `archive` stanza is needed.
The manifest isn't used in Spark and since it gets mashed down in the assembly
JAR I tend to not
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87167789
Jenkins, add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-87168977
[Test build #29341 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/29341/consoleFull)
for PR 5119 at commit
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-86659856
As an experiment, I changed the plugin declaration to exclude the main JAR
phase, that is, commented out this bit:
```xml
execution
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-86735602
Hm, so I tried changing the config to:
```
plugin
groupIdorg.apache.maven.plugins/groupId
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r27116385
--- Diff: pom.xml ---
@@ -1472,6 +1473,45 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r27128892
--- Diff: pom.xml ---
@@ -1472,6 +1473,45 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r27023977
--- Diff: pom.xml ---
@@ -1472,6 +1473,45 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r27024006
--- Diff: pom.xml ---
@@ -1472,6 +1473,45 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user steveloughran commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-85448943
-Updated patch with the indentation corrected; plugin version entrusted to
the apache parent template
---
If your project is set up for it, you can reply to this
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-85766611
+1 from the SQL side. I only duplicated that code because I was afraid of
the maven changes to avoid doing as such. I'll defer to Sean's maven expertise
on when this
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26925189
--- Diff: pom.xml ---
@@ -1472,6 +1474,46 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26925330
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -1,140 +0,0 @@
-/*
--- End diff --
yes. These are the two
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26925134
--- Diff: pom.xml ---
@@ -1472,6 +1474,46 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26925089
--- Diff: pom.xml ---
@@ -158,6 +158,7 @@
fasterxml.jackson.version2.4.4/fasterxml.jackson.version
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26896784
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/QueryTest.scala ---
@@ -1,140 +0,0 @@
-/*
--- End diff --
Just so my head's straight
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5119#issuecomment-84450025
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26896768
--- Diff: pom.xml ---
@@ -158,6 +158,7 @@
fasterxml.jackson.version2.4.4/fasterxml.jackson.version
snappy.version1.1.1.6/snappy.version
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26896779
--- Diff: pom.xml ---
@@ -1472,6 +1474,46 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26896776
--- Diff: pom.xml ---
@@ -1472,6 +1474,46 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5119#discussion_r26897355
--- Diff: pom.xml ---
@@ -1472,6 +1474,46 @@
groupIdorg.scalatest/groupId
artifactIdscalatest-maven-plugin/artifactId
49 matches
Mail list logo
