Github user jegonzal commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r29521247
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -103,8 +132,14 @@ object PageRank extends Logging {
// that
Github user jegonzal commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-98196331
Overall this looks great! I apologize for the delayed response. I am
going to go ahead and merge this now and then we can tune the performance in a
later pull
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-98199444
Thanks Joey, I appreciate it. I can see your concern w/r/t the branching.
If I can get some HW and time, I'll see if I notice a performance regression
with the
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4774
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-96816965
@jegonzal does this algorithm look correct to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-96769570
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-95256308
@jegonzal does this algorithm look correct to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94025941
OK, I'll update w/r/t the comments today. I'd appreciate it if someone
took a glance at the algorithm; it's as specified in the referred paper,
but another set
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94093081
[Test build #30507 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30507/consoleFull)
for PR 4774 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94121865
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94121860
[Test build #30511 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30511/consoleFull)
for PR 4774 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94107018
[Test build #30509 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30509/consoleFull)
for PR 4774 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94107117
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94107110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94107116
[Test build #30509 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30509/consoleFull)
for PR 4774 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94107104
[Test build #30507 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30507/consoleFull)
for PR 4774 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-94112401
[Test build #30511 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30511/consoleFull)
for PR 4774 at commit
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-93562171
Is this going to get merged at some point?
On Tue, Mar 31, 2015 at 10:51 AM, Yusup notificati...@github.com wrote:
+1
â
Reply to this
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-93562703
@dwmclary This doesn't merge, so would at least need a rebase. It's up to
@ankurdave and @jegonzal et al.
---
If your project is set up for it, you can reply to this
Github user ankurdave commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r28465870
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -133,7 +167,29 @@ object PageRank extends Logging {
*
Github user ankurdave commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r28465105
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -89,6 +114,10 @@ object PageRank extends Logging {
// Set the
Github user ankurdave commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r28465270
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -133,7 +167,29 @@ object PageRank extends Logging {
*
Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-93577536
This looks good aside from the comments. I didn't verify the algorithm; it
would be good if @jegonzal could take a look.
---
If your project is set up for it, you can
Github user ankurdave commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r28465288
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -148,6 +204,10 @@ object PageRank extends Logging {
Github user ankurdave commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r28465211
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -104,7 +133,12 @@ object PageRank extends Logging {
// edge
Github user ankurdave commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r28465575
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -170,8 +241,16 @@ object PageRank extends Logging {
val
Github user xperian commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-88186888
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-83669688
Good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81538617
[Test build #28641 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28641/consoleFull)
for PR 4774 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81538624
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81829391
OK, that should fix the binary incompatibility on the vertexProgram.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81831186
[Test build #28661 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28661/consoleFull)
for PR 4774 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81847916
[Test build #28664 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28664/consoleFull)
for PR 4774 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81831781
[Test build #28661 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28661/consoleFull)
for PR 4774 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81831805
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81886679
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81886657
[Test build #28664 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28664/consoleFull)
for PR 4774 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81482802
[Test build #28641 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28641/consoleFull)
for PR 4774 at commit
Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-81480270
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78824623
OK, got 'em.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r26365904
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -148,11 +204,20 @@ object PageRank extends Logging {
.mapVertices(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r26365902
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -148,11 +204,20 @@ object PageRank extends Logging {
.mapVertices(
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/4774#discussion_r26362827
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/lib/PageRank.scala
---
@@ -74,10 +76,35 @@ object PageRank extends Logging {
*
*
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78804717
Whitespace removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78766347
OK, that should be a reasonable solution. Thanks for the advice @rxin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78614976
I certainly agree that binary compatibility matters. I think it's mainly a
question of which is more desirable: fewer repeated LOC or binary
compatibility.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78616511
Also you don't necessarily need to duplicate a lot of code. You can have
one Pregel function calling another.
---
If your project is set up for it, you can reply to this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78616278
Sorry binary compatibility is not a preference. It is a requirement here
... otherwise it is a huge hassle for people to upgrade, which leads to more
fragmentation in
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78606657
Yes but binary compatibility also matters. I can't see the Jenkins output
anymore, but I recall thinking it was probably legitimate. Can you write this
differently
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-78594489
Does anyone have a comment on this MiMa failure? The fact that
PageRankSuite passes illustrates that it's source compatible.
---
If your project is set up for it, you
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77434500
I think this change actually introduces binary incompatability even though
you have only added optional args. It may be source compatible.
---
If your project is set up
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77436963
OK, thanks Sean, that was my reading of it too.
On Thu, Mar 5, 2015 at 11:32 AM, Sean Owen notificati...@github.com wrote:
I think this change actually
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77433149
I'm not really sure what to do about this MiMa error. Suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dwmclary commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77398055
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user shaneknapp commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77410205
jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77410688
[Test build #28301 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28301/consoleFull)
for PR 4774 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77427253
[Test build #28301 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28301/consoleFull)
for PR 4774 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-77427282
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-76252508
Cool!
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dwmclary opened a pull request:
https://github.com/apache/spark/pull/4774
Spark-5854 personalized page rank
Here's a modification to PageRank which does personalized PageRank. The
approach is basically similar to that outlined by Bahmani et al. from 2010
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-76086384
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4774#issuecomment-76120556
cc Ankur @ankurdave
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
62 matches
Mail list logo
