Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/14883
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r78197173
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77306344
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77302207
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class ExternalCatalog {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77292196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77291638
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class ExternalCatalog {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77290783
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77290382
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77284957
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,17 @@ abstract class ExternalCatalog
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77241547
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -69,6 +71,29 @@ private[sql] class SharedState(val sparkContext:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77156638
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -69,6 +71,29 @@ private[sql] class SharedState(val sparkContext:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77125955
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala ---
@@ -69,6 +71,29 @@ private[sql] class SharedState(val sparkContext:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77122799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77118535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77117696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77117555
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77115989
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77114469
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog {
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77114400
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77113584
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77113302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77110718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -184,4 +184,9 @@ abstract class ExternalCatalog
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77110077
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -37,13 +38,13 @@ case class AddJarCommand(path: String)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77099087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -43,6 +40,11 @@ private[sql] class SessionState(sparkSession:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77098769
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -37,7 +37,7 @@ case class AddJarCommand(path: String)
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77098744
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -43,6 +40,11 @@ private[sql] class SessionState(sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77097530
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -43,6 +40,11 @@ private[sql] class SessionState(sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r77097374
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/resources.scala
---
@@ -37,7 +37,7 @@ case class AddJarCommand(path: String)
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r76923998
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -171,6 +171,7 @@ private[sql] class SessionState(sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r76922568
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SessionState.scala ---
@@ -171,6 +171,7 @@ private[sql] class SessionState(sparkSession:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r76922145
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -509,4 +509,10 @@ class InMemoryCatalog(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14883#discussion_r76921445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -509,4 +509,10 @@ class InMemoryCatalog(
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/14883
[SPARK-17319] [SQL] Move addJar from HiveSessionState to HiveExternalCatalog
### What changes were proposed in this pull request?
This is another step to remove Hive client usage in
33 matches
Mail list logo
