[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16219 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread tcondie
Github user tcondie commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91805757 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -303,7 +303,6 @@ private[state]

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91772705 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -303,7 +303,6 @@ private[state]

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91771485 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala --- @@ -376,7 +376,9 @@ class StateStoreSuite

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91770220 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -152,11 +154,16 @@ abstract class

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91769957 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala --- @@ -58,6 +58,8 @@ class StreamExecution(

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91781665 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/FileStreamSinkLogSuite.scala --- @@ -151,10 +151,11 @@ class

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91780225 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -215,21 +219,32 @@ abstract class

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/16219#discussion_r91773409 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQuerySuite.scala --- @@ -369,7 +369,9 @@ class StreamingQuerySuite extends

[GitHub] spark pull request #16219: [SPARK-18790][SS] Keep a general offset history o...

2016-12-08 Thread tcondie
GitHub user tcondie opened a pull request: https://github.com/apache/spark/pull/16219 [SPARK-18790][SS] Keep a general offset history of stream batches ## What changes were proposed in this pull request? Instead of only keeping the minimum number of offsets around, we