[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92982685 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -111,7 +112,8 @@ case class CatalogTablePartition(

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92973560 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -111,7 +112,8 @@ case class CatalogTablePartition(

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92961639 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -135,6 +146,14 @@ case class Cast(child: Expression,

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92962066 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -120,7 +128,10 @@ object Cast { > SELECT

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92961818 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -110,6 +110,14 @@ object Cast { case (_:

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92962327 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -30,21 +30,44 @@ import

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92962286 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -30,21 +30,44 @@ import

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92962120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala --- @@ -41,13 +43,16 @@ object ReplaceExpressions extends

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92916070 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -30,21 +30,44 @@ import

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915894 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -120,7 +128,10 @@ object Cast { > SELECT

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915851 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -111,7 +112,8 @@ case class CatalogTablePartition(

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915771 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -120,7 +128,10 @@ object Cast { > SELECT

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915757 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala --- @@ -110,6 +110,14 @@ object Cast { case (_:

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/16308#discussion_r92915708 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -30,21 +30,44 @@ import

[GitHub] spark pull request #16308: [SPARK-18350][SQL][WIP] Support session local tim...

2016-12-16 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/16308 [SPARK-18350][SQL][WIP] Support session local timezone. ## What changes were proposed in this pull request? As of Spark 2.1, Spark SQL assumes the machine timezone for datetime