[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16487 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95306656 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -469,9 +475,7 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95303491 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -1169,26 +1169,6 @@ class MetastoreDataSourcesSuite

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95298994 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95298747 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95295700 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1289,4 +1290,66 @@ class HiveDDLSuite }

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95295488 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95071633 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1289,4 +1290,66 @@ class HiveDDLSuite }

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95071626 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95061418 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95061397 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1289,4 +1290,66 @@ class HiveDDLSuite }

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95041219 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95040471 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -385,6 +380,8 @@ final class DataFrameWriter[T] private[sql](ds:

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16487#discussion_r95040243 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1289,4 +1290,66 @@ class HiveDDLSuite }

[GitHub] spark pull request #16487: [SPARK-19107][SQL] support creating hive table wi...

2017-01-06 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/16487 [SPARK-19107][SQL] support creating hive table with DataFrameWriter and Catalog ## What changes were proposed in this pull request? After unifying the CREATE TABLE syntax in