Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r175232475
--- Diff: python/pyspark/ml/tests.py ---
@@ -1980,8 +1997,8 @@ def test_java_params(self):
pyspark.ml.regression]
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16770
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r175177201
--- Diff: python/pyspark/ml/feature.py ---
@@ -497,66 +544,61 @@ def setMinTF(self, value):
"""
return self._set(minTF=value)
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r175179623
--- Diff: python/pyspark/ml/feature.py ---
@@ -565,6 +607,20 @@ def vocabulary(self):
"""
return self._call_java("vocabulary")
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r175180172
--- Diff: python/pyspark/ml/tests.py ---
@@ -1980,8 +1997,8 @@ def test_java_params(self):
pyspark.ml.regression]
for
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r175179845
--- Diff: python/pyspark/ml/tests.py ---
@@ -640,6 +640,34 @@ def test_count_vectorizer_with_binary(self):
feature, expected = r
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r174581586
--- Diff: python/pyspark/ml/tests.py ---
@@ -640,6 +640,34 @@ def test_count_vectorizer_with_binary(self):
feature, expected = r
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r174576552
--- Diff: python/pyspark/ml/tests.py ---
@@ -640,6 +640,33 @@ def test_count_vectorizer_with_binary(self):
feature, expected = r
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r174575750
--- Diff: python/pyspark/ml/tests.py ---
@@ -640,6 +640,23 @@ def test_count_vectorizer_with_binary(self):
feature, expected = r
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r174557844
--- Diff: python/pyspark/ml/feature.py ---
@@ -437,33 +498,20 @@ class CountVectorizer(JavaEstimator, HasInputCol,
HasOutputCol, JavaMLReadable,
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r174557635
--- Diff: python/pyspark/ml/tests.py ---
@@ -1980,8 +1997,8 @@ def test_java_params(self):
pyspark.ml.regression]
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r174555673
--- Diff: python/pyspark/ml/tests.py ---
@@ -640,6 +640,23 @@ def test_count_vectorizer_with_binary(self):
feature, expected = r
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r17488
--- Diff: python/pyspark/ml/feature.py ---
@@ -565,6 +607,20 @@ def vocabulary(self):
"""
return self._call_java("vocabulary")
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r174553822
--- Diff: python/pyspark/ml/feature.py ---
@@ -497,66 +544,61 @@ def setMinTF(self, value):
"""
return self._set(minTF=value)
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r173545177
--- Diff: python/pyspark/ml/tests.py ---
@@ -1980,8 +1997,8 @@ def test_java_params(self):
pyspark.ml.regression]
for
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r173545477
--- Diff: python/pyspark/ml/feature.py ---
@@ -437,33 +498,20 @@ class CountVectorizer(JavaEstimator, HasInputCol,
HasOutputCol, JavaMLReadable,
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r173544312
--- Diff: python/pyspark/ml/feature.py ---
@@ -565,6 +607,20 @@ def vocabulary(self):
"""
return self._call_java("vocabulary")
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r173543945
--- Diff: python/pyspark/ml/feature.py ---
@@ -497,66 +544,61 @@ def setMinTF(self, value):
"""
return self._set(minTF=value)
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16770#discussion_r173544594
--- Diff: python/pyspark/ml/tests.py ---
@@ -640,6 +640,23 @@ def test_count_vectorizer_with_binary(self):
feature, expected = r
19 matches
Mail list logo
