[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r116408136 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -2318,8 +2319,8 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115896918 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -2318,8 +2319,8 @@ class

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115813053 --- Diff: mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala --- @@ -2318,8 +2319,8 @@ class LogisticRegressionSuite

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115669376 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -526,7 +526,7 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115453085 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -890,7 +890,7 @@ object LogisticRegression extends

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115451397 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -526,7 +526,7 @@ class LogisticRegression

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115418289 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -526,7 +526,7 @@ class LogisticRegression

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115418315 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -890,7 +890,7 @@ object LogisticRegression extends

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115416085 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -526,7 +526,7 @@ class LogisticRegression @Since("1.2.0")

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/17910#discussion_r115416204 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -890,7 +890,7 @@ object LogisticRegression extends

[GitHub] spark pull request #17910: [SPARK-20669][ML] LogisticRegression family shoul...

GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/17910 [SPARK-20669][ML] LogisticRegression family should be case insensitive ## What changes were proposed in this pull request? make param `family` case insensitive ## How was this