Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122359345
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122356960
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,118 @@ class CodegenContext
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122356982
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,118 @@ class CodegenContext
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122356214
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class CodegenContext
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18075
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122122867
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -93,7 +93,7 @@ private[sql] trait ColumnarBatchScan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122122817
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -62,13 +62,63 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122122765
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -33,10 +33,10 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122122445
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,118 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122017129
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -83,6 +83,58 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122016978
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -83,6 +83,58 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122016799
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122016650
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -629,7 +730,9 @@ class CodegenContext
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122016475
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r122016536
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121989572
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -93,7 +93,7 @@ private[sql] trait ColumnarBatchScan
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121975114
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121968338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121838120
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121837792
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -93,7 +93,7 @@ private[sql] trait ColumnarBatchScan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121837609
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -93,7 +93,7 @@ private[sql] trait ColumnarBatchScan
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121837371
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -83,6 +83,58 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121837140
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/GeneratedProjectionSuite.scala
---
@@ -83,6 +83,58 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121836835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121836537
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -629,7 +730,9 @@ class CodegenContext
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121836403
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121836076
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r121835500
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,124 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r119180019
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -190,15 +190,15 @@ case class Stack(children:
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r119179925
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r119179700
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r119179568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r119179501
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118866096
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118872149
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118865349
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class CodegenContext
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118868339
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala
---
@@ -190,15 +190,15 @@ case class Stack(children:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118866774
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +222,128 @@ class CodegenContext
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118497931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118345866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118344615
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class CodegenContext
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118336805
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118331100
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class CodegenContext
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118323003
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118320606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class CodegenContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118309307
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -299,6 +297,9 @@ case class SampleExec(
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118302075
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -299,6 +297,9 @@ case class SampleExec(
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118302508
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118300406
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,124 @@ class CodegenContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118300347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -299,6 +297,9 @@ case class SampleExec(
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118274669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -629,7 +736,9 @@ class CodegenContext
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118274597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -792,7 +887,18 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118274179
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,129 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118274094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,129 @@ class
Github user bdrillard commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118263506
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -792,7 +887,18 @@ class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118168255
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,129 @@ class CodegenContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118168228
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -233,10 +223,129 @@ class CodegenContext
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118165399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -792,7 +887,18 @@ class CodegenContext {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18075#discussion_r118162963
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -629,7 +736,9 @@ class CodegenContext {
GitHub user bdrillard opened a pull request:
https://github.com/apache/spark/pull/18075
[SPARK-18016][SQL][CATALYST] Code Generation: Constant Pool Limit - Class
Splitting
## What changes were proposed in this pull request?
This pull-request exclusively includes the class
60 matches
Mail list logo
