[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18852 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534323 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534296 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534275 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534246 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534235 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534222 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534217 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131534140 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,15 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131527017 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -270,4 +270,10 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread vinodkc
Github user vinodkc commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131519921 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -808,6 +808,12 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18852#discussion_r131517530 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -808,6 +808,12 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #18852: [SPARK-21588][SQL] SQLContext.getConf(key, null) ...

2017-08-05 Thread vinodkc
GitHub user vinodkc opened a pull request: https://github.com/apache/spark/pull/18852 [SPARK-21588][SQL] SQLContext.getConf(key, null) should return null ## What changes were proposed in this pull request? In SQLContext.get(key,null) for a key that is not defined in the