[GitHub] spark pull request #19974: [SPARK-22779][sql] Resolve default values for fal...

2017-12-14 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19974#discussion_r157027896 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -280,4 +280,34 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #19974: [SPARK-22779][sql] Resolve default values for fal...

2017-12-14 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19974#discussion_r157026037 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -280,4 +280,34 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #19974: [SPARK-22779][sql] Resolve default values for fal...

2017-12-14 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19974#discussion_r156935029 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -280,4 +280,34 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #19974: [SPARK-22779][sql] Resolve default values for fal...

2017-12-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19974 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19974: [SPARK-22779][sql] Resolve default values for fal...

2017-12-13 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19974#discussion_r156863889 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala --- @@ -280,4 +280,34 @@ class SQLConfSuite extends QueryTest with

[GitHub] spark pull request #19974: [SPARK-22779][sql] Resolve default values for fal...

2017-12-13 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/19974 [SPARK-22779][sql] Resolve default values for fallback configs. SQLConf allows some callers to define a custom default value for configs, and that complicates a little bit the handling of