[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20499 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166320786 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166310719 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166302987 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166302599 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166301172 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166300631 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166290471 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166286067 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166278935 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1532,7 +1532,7 @@ def fillna(self, value, subset=None): return

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166220816 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1545,8 +1545,8 @@ def replace(self, to_replace, value=None, subset=None): :param

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166217503 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1587,6 +1597,51 @@ def replace(self, to_replace, value=None, subset=None): |null| null|null|

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-06 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r166216324 --- Diff: python/pyspark/sql/tests.py --- @@ -2175,7 +2175,7 @@ def test_replace(self): # replace with subset specified by a string of a

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165951235 --- Diff: python/pyspark/sql/tests.py --- @@ -2186,7 +2186,7 @@ def test_replace(self): # replace with subset specified with one column

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165950192 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1557,6 +1557,9 @@ def replace(self, to_replace, value=None, subset=None): For

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165883566 --- Diff: python/pyspark/sql/tests.py --- @@ -2186,7 +2186,7 @@ def test_replace(self): # replace with subset specified with one column

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165884365 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1587,6 +1600,52 @@ def replace(self, to_replace, value=None, subset=None): |null| null|null|

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165883051 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1557,6 +1557,9 @@ def replace(self, to_replace, value=None, subset=None): For example, if

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165834947 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1587,6 +1600,51 @@ def replace(self, to_replace, value=None, subset=None): |null|

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165828519 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1587,6 +1600,51 @@ def replace(self, to_replace, value=None, subset=None): |null| null|null|

[GitHub] spark pull request #20499: [SPARK-23328][PYTHON] Disallow default value None...

2018-02-03 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20499#discussion_r165828448 --- Diff: python/pyspark/sql/dataframe.py --- @@ -1587,6 +1600,51 @@ def replace(self, to_replace, value=None, subset=None): |null| null|null|