[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-07 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179931481 --- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala --- @@ -257,19 +281,32 @@ class ExecutorSuite extends SparkFunSuite with LocalSp

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-06 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179806228 --- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala --- @@ -257,19 +281,32 @@ class ExecutorSuite extends SparkFunSuite with LocalSp

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-06 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179776800 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -494,19 +507,6 @@ private[spark] class Executor( setTaskFinishedA

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-06 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179776639 --- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala --- @@ -173,8 +173,26 @@ class ExecutorSuite extends SparkFunSuite with LocalSpa

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-06 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179776576 --- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala --- @@ -330,6 +362,15 @@ class FetchFailureHidingRDD( case t: Throwabl

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-05 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179654822 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -494,19 +507,6 @@ private[spark] class Executor( setTaskFinished

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-05 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179647613 --- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala --- @@ -173,8 +173,26 @@ class ExecutorSuite extends SparkFunSuite with LocalSp

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-05 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20987#discussion_r179647240 --- Diff: core/src/test/scala/org/apache/spark/executor/ExecutorSuite.scala --- @@ -330,6 +362,15 @@ class FetchFailureHidingRDD( case t: Throwab

[GitHub] spark pull request #20987: [SPARK-23816][CORE] Killed tasks should ignore Fe...

2018-04-05 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/20987 [SPARK-23816][CORE] Killed tasks should ignore FetchFailures. SPARK-19276 ensured that FetchFailures do not get swallowed by other layers of exception handling, but it also meant that a killed ta