Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21659
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r201196914
--- Diff: docs/README.md ---
@@ -69,7 +69,8 @@ You can build just the Spark scaladoc and javadoc by
running `build/sbt unidoc`
Similarly, you
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r200870956
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,44 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXBUILD
+ifndef SPHINXPYTH
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r200869393
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,44 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXBUILD
+ifndef SPHINXPYTHON
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r200869531
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,44 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXBUILD
+ifndef SPHINXPYTHON
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199989581
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,44 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXBUILD
+ifndef SPHINXPYTH
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199916087
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,44 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXBUILD
+ifndef SPHINXPYTHON
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199384118
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= sphin
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199384289
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= sphin
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199104696
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199099575
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= s
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199098475
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= s
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199096185
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= sphinx
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199096928
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,35 @@
# Makefile for Sphinx documentation
#
+ifndef SPHINXPYTHON
+SPHINXBUILD ?= sphinx
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r199053321
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,36 @@
# Makefile for Sphinx documentation
#
+# You can set this variable from command line
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21659#discussion_r198928988
--- Diff: python/docs/Makefile ---
@@ -1,19 +1,36 @@
# Makefile for Sphinx documentation
#
+# You can set this variable from comman
16 matches
Mail list logo