Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21930
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009415
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -366,14 +423,26 @@ private[spark] object ClosureCleaner extends Logging {
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009284
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009194
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207009085
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207008830
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging {
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r207008732
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206969720
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -366,14 +423,26 @@ private[spark] object ClosureCleaner extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206969409
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206969057
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206968792
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206969293
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206968600
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206968962
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -218,118 +261,132 @@ private[spark] object ClosureCleaner extends
Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206968430
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206968703
--- Diff: core/src/main/scala/org/apache/spark/util/ClosureCleaner.scala ---
@@ -159,6 +160,43 @@ private[spark] object ClosureCleaner extends Logging {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206605419
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -123,7 +123,7 @@ abstract class TaskContext extends Serializable {
*
*
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206562302
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -123,7 +123,7 @@ abstract class TaskContext extends Serializable {
*
*
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206549150
--- Diff:
core/src/test/scala/org/apache/spark/util/ClosureCleanerSuite2.scala ---
@@ -538,17 +543,22 @@ class ClosureCleanerSuite2 extends SparkFunSuite wit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206541904
--- Diff:
core/src/test/scala/org/apache/spark/util/ClosureCleanerSuite2.scala ---
@@ -538,17 +543,22 @@ class ClosureCleanerSuite2 extends SparkFunSuite wit
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206542154
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -123,7 +123,7 @@ abstract class TaskContext extends Serializable {
*
*
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21930#discussion_r206540368
--- Diff: core/src/main/scala/org/apache/spark/TaskContext.scala ---
@@ -123,7 +123,7 @@ abstract class TaskContext extends Serializable {
*
GitHub user skonto opened a pull request:
https://github.com/apache/spark/pull/21930
[SPARK-14540][Core] Fix remaining major issues for Scala 2.12 Support
## What changes were proposed in this pull request?
This PR addresses issues 2,3 in the
[document](https://docs.google.com/
23 matches
Mail list logo